From nobody@FreeBSD.org  Mon Dec 24 15:42:20 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6F9C16A46B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Dec 2007 15:42:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A36BC13C4D9
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Dec 2007 15:42:20 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lBOFfnBZ012556
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Dec 2007 15:41:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lBOFfnR0012555;
	Mon, 24 Dec 2007 15:41:49 GMT
	(envelope-from nobody)
Message-Id: <200712241541.lBOFfnR0012555@www.freebsd.org>
Date: Mon, 24 Dec 2007 15:41:49 GMT
From: KOIE Hidetaka <hide@koie.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: japanese/skkserv crashes always
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118996
>Category:       ports
>Synopsis:       japanese/skkserv crashes always
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 24 15:50:03 UTC 2007
>Closed-Date:    Tue Jan 01 19:03:53 UTC 2008
>Last-Modified:  Tue Jan  1 19:10:01 UTC 2008
>Originator:     KOIE Hidetaka
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
FreeBSD guriandgura 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Mon Dec 24 17:01:22 JST 2007 koie@guriandgura:/usr/obj/usr/src/sys/GURIANDGURA amd64
>Description:
skkserv causes SEGV in initializing on amd64.
>How-To-Repeat:
        koie@guriandgura% skkserv
        Segmentation fault (core dumped)
        koie@guriandgura%
>Fix:
Need prototypes in the environment sizeof (int) != sizeof (pointer).

diff -rpub japanese/skkserv/work/skk-9.6/skkserv/skkserv.h japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.h
--- japanese/skkserv/work/skk-9.6/skkserv/skkserv.h     1997-01-21 04:16:36.000000000 +0900
+++ japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.h        2007-12-21 22:39:29.671144656 +0900
@@ -37,6 +37,8 @@
 /* Necessary for SunOS 3.x and maybe other old systems */

 #include       <stdio.h>
+#include       <stdlib.h>
+#include       <string.h>

 #include       <sys/types.h>
 #ifdef HAVE_SYS_IOCTL_H
@@ -44,6 +46,7 @@
 #endif
 #include       <sys/socket.h>
 #include       <netinet/in.h>
+#include       <arpa/inet.h>
 #include       <netdb.h>
 #include       <signal.h>
 #include       <errno.h>



The following patch is to suppress a warning.

diff -rpub japanese/skkserv/work/skk-9.6/skkserv/skkserv.c japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.c
--- japanese/skkserv/work/skk-9.6/skkserv/skkserv.c     1997-01-21 04:16:36.000000000 +0900
+++ japanese/skkserv/work.koie/skk-9.6/skkserv/skkserv.c        2007-12-21 22:40:06.368544948 +0900
@@ -476,7 +476,7 @@ main_loop()

     if (FD_ISSET(initsock, &readfds)) {
       len = sizeof(from);
-      if ((clientsock[nclients ++] = accept(initsock, &from, &len)) < 0) {
+      if ((clientsock[nclients ++] = accept(initsock, (struct sockaddr*)&from, &len)) < 0) {
        err("accept error; something wrong happened with the socket");
       }
       if (nclients >= MAXDTAB - 3 - debug * 2) {

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: arved 
State-Changed-When: Tue Jan 1 19:03:47 UTC 2008 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118996 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/118996: commit references a PR
Date: Tue,  1 Jan 2008 19:03:42 +0000 (UTC)

 arved       2008-01-01 19:03:36 UTC
 
   FreeBSD ports repository
 
   Modified files:
     japanese/skkserv     Makefile 
   Added files:
     japanese/skkserv/files patch-skkserv.c patch-skkserv.h 
   Log:
   Fix segfault on amd64
   
   PR:             118996
   Submitted by    KOIE Hidetaka
   
   Revision  Changes    Path
   1.18      +1 -0      ports/japanese/skkserv/Makefile
   1.1       +11 -0     ports/japanese/skkserv/files/patch-skkserv.c (new)
   1.1       +19 -0     ports/japanese/skkserv/files/patch-skkserv.h (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
