From gahr@gahr.ch  Wed Dec 19 15:23:05 2007
Return-Path: <gahr@gahr.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 055C316A418
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Dec 2007 15:23:05 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73])
	by mx1.freebsd.org (Postfix) with ESMTP id 960D613C469
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Dec 2007 15:23:04 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from 80-218-191-236.dclient.hispeed.ch ([80.218.191.236] helo=gahrtop.localhost)
	by cpanel03.rubas-s03.net with esmtpa (Exim 4.68)
	(envelope-from <gahr@gahr.ch>)
	id 1J50lD-0000cV-PI
	for FreeBSD-gnats-submit@freebsd.org; Wed, 19 Dec 2007 16:23:03 +0100
Received: from gahrtop.localhost (localhost [127.0.0.1])
	by gahrtop.localhost (Postfix) with ESMTP id BE9DC73070
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Dec 2007 16:21:29 +0100 (CET)
Message-Id: <1198077689.45208@gahrtop.localhost>
Date: Wed, 19 Dec 2007 16:21:29 +0100
From: "Pietro Cerutti" <gahr@gahr.ch>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [change] misc/chmlib enable installation of example applications + adopt maintainship
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         118861
>Category:       ports
>Synopsis:       [change] misc/chmlib enable installation of example applications + adopt maintainship
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 19 15:30:00 UTC 2007
>Closed-Date:    Fri Dec 21 13:37:01 UTC 2007
>Last-Modified:  Fri Dec 21 13:37:01 UTC 2007
>Originator:     Pietro Cerutti
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 8.0-CURRENT #18: Tue Dec 18 12:48:22 CET 2007
    root@gahrtop.localhost:/usr/obj/usr/src/sys/MSI1034



>Description:


The patch below:

- adds an OPTION to install a few sample application along with the libs
- sets maintainship to me


>How-To-Repeat:





>Fix:


--- _chmlib.diff begins here ---
--- Makefile.orig	2007-12-19 16:18:21.000000000 +0100
+++ Makefile	2007-12-19 16:18:59.000000000 +0100
@@ -11,16 +11,27 @@
 CATEGORIES=	misc
 MASTER_SITES=	http://www.jedrea.com/chmlib/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	gahr@gahr.ch
 COMMENT=	A library for dealing with Microsoft ITSS/CHM format files
 
+OPTIONS=	EXAMPLES "build example applications" ON
+
 USE_BZIP2=	yes
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--disable-io64 --disable-pread --exec-prefix=${PREFIX} --disable-static
 USE_GMAKE=	yes
 USE_LDCONFIG=	yes
 
+.include <bsd.port.pre.mk>
+
+.if defined(WITH_EXAMPLES)
+CONFIGURE_ARGS+=	-enable-examples
+PLIST_SUB+=	EXAMPLES=""
+.else
+PLIST_SUB+=	EXAMPLES="@comment "
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e "s,-lpthread,${PTHREAD_LIBS}," ${WRKSRC}/configure
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- pkg-plist.orig	2007-12-19 16:18:32.000000000 +0100
+++ pkg-plist	2007-12-19 16:18:39.000000000 +0100
@@ -2,3 +2,8 @@
 include/lzx.h
 lib/libchm.so
 lib/libchm.so.0
+%%EXAMPLES%%bin/chm_http
+%%EXAMPLES%%bin/enum_chmLib
+%%EXAMPLES%%bin/enumdir_chmLib
+%%EXAMPLES%%bin/extract_chmLib
+%%EXAMPLES%%bin/test_chmLib
--- _chmlib.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 19 15:30:10 UTC 2007 
Responsible-Changed-Why:  
miwi@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118861 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Wed Dec 19 15:43:34 UTC 2007 
State-Changed-Why:  
Is there any reason not to always install the example apps? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118861 

From: Pietro Cerutti <gahr@gahr.ch>
To: pav@FreeBSD.org
Cc: miwi@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/118861: [change] misc/chmlib enable installation of example
 applications + adopt maintainship
Date: Wed, 19 Dec 2007 16:48:00 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig6F9867F6D7EBB43AD606D771
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 pav@FreeBSD.org wrote:
 
 > Is there any reason not to always install the example apps?
 
 Not a technical one, indeed. But why not give a user the choice to
 install only what she need?
 
 Please note that I've put the option ON by default.
 
 --=20
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 
 --------------enig6F9867F6D7EBB43AD606D771
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFHaT00wMJqmJVx944RChk/AKCALpJjz8lOxuKHAQQKJnwHEJhPGQCdGsh7
 B33v0kF+3diYU3EL2r+bWTI=
 =dDAT
 -----END PGP SIGNATURE-----
 
 --------------enig6F9867F6D7EBB43AD606D771--

From: Pav Lucistnik <pav@FreeBSD.org>
To: Pietro Cerutti <gahr@gahr.ch>
Cc: miwi@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/118861: [change] misc/chmlib enable installation of
	example applications + adopt maintainship
Date: Wed, 19 Dec 2007 17:24:02 +0100

 > > Is there any reason not to always install the example apps?
 > 
 > Not a technical one, indeed. But why not give a user the choice to
 > install only what she need?
 > 
 > Please note that I've put the option ON by default.
 
 My personal recommendation is to install these always.
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Some programmers are able to write FORTRAN in any language.

From: Pietro Cerutti <gahr@gahr.ch>
To: pav@FreeBSD.org
Cc: miwi@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/118861: [change] misc/chmlib enable installation of	example
 applications + adopt maintainship
Date: Wed, 19 Dec 2007 17:25:54 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig99F4F417CB34C84DFF64CB69
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Pav Lucistnik wrote:
 >>> Is there any reason not to always install the example apps?
 >> Not a technical one, indeed. But why not give a user the choice to
 >> install only what she need?
 >>
 >> Please note that I've put the option ON by default.
 >=20
 > My personal recommendation is to install these always.
 >=20
 
 What's the argument?
 
 I'm not saying that I don't agree, I'm just willing to understand the
 basis for your recommendation and the global philosophy here..
 
 Thanks
 
 --=20
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 
 --------------enig99F4F417CB34C84DFF64CB69
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFHaUYWwMJqmJVx944RCkB2AJ474uZ2GgqGkwJBs1bGynxVPinBjwCfSM+4
 /sB1PwNs3fdh6JtdngklvGo=
 =y8TX
 -----END PGP SIGNATURE-----
 
 --------------enig99F4F417CB34C84DFF64CB69--

From: Pav Lucistnik <pav@FreeBSD.org>
To: Pietro Cerutti <gahr@gahr.ch>
Cc: miwi@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/118861: [change] misc/chmlib enable installation
	of	example applications + adopt maintainship
Date: Wed, 19 Dec 2007 17:31:04 +0100

 > > My personal recommendation is to install these always.
 > > 
 > 
 > What's the argument?
 > 
 > I'm not saying that I don't agree, I'm just willing to understand the
 > basis for your recommendation and the global philosophy here..
 
 The argument is to keep the things as simple as possible.
 
 In my opinion, it's not worth bothering the user with the blue screen
 just for such a minor thing like this one.
 
 -- 
 Pav Lucistnik <pav@oook.cz>
               <pav@FreeBSD.org>
 
 Oh, no! Aaargh! It is the most unnatural, most disgusting
 creature imaginable: a two-eyed cyclops!

From: Pietro Cerutti <gahr@gahr.ch>
To: pav@FreeBSD.org
Cc: miwi@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/118861: [change] misc/chmlib enable installation	of	example
 applications + adopt maintainship
Date: Wed, 19 Dec 2007 17:51:35 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig926F027FAEBEC48C72781DBB
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Pav Lucistnik wrote:
 >>> My personal recommendation is to install these always.
 >>>
 >> What's the argument?
 >>
 >> I'm not saying that I don't agree, I'm just willing to understand the
 >> basis for your recommendation and the global philosophy here..
 >=20
 > The argument is to keep the things as simple as possible.
 >=20
 > In my opinion, it's not worth bothering the user with the blue screen
 > just for such a minor thing like this one.
 >=20
 
 Agreed. Please find the updated patch here:
 
 http://www.gahr.ch/FreeBSD/patches/118861_chmlib_no_option.diff
 
 --=20
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 
 --------------enig926F027FAEBEC48C72781DBB
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFHaUwbwMJqmJVx944RCg3/AKCi2PPihfx8eRFuEL+f4nbjlCG8EACggwQq
 acxsZzdyxcUVUNhItYSKhWw=
 =dQYU
 -----END PGP SIGNATURE-----
 
 --------------enig926F027FAEBEC48C72781DBB--
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Wed Dec 19 17:00:02 UTC 2007 
State-Changed-Why:  
Feedback received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118861 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Fri Dec 21 13:36:59 UTC 2007 
State-Changed-Why:  
other committer was faster. sorry and thanks for your submission. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118861 
>Unformatted:
