From gahr@gahr.ch  Mon Dec 17 22:13:43 2007
Return-Path: <gahr@gahr.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5AA9016A46B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Dec 2007 22:13:43 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73])
	by mx1.freebsd.org (Postfix) with ESMTP id EEA6913C442
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Dec 2007 22:13:42 +0000 (UTC)
	(envelope-from gahr@gahr.ch)
Received: from 80-218-191-236.dclient.hispeed.ch ([80.218.191.236] helo=gahrtop.localhost)
	by cpanel03.rubas-s03.net with esmtpa (Exim 4.68)
	(envelope-from <gahr@gahr.ch>)
	id 1J4ODU-0007So-Ce
	for FreeBSD-gnats-submit@freebsd.org; Mon, 17 Dec 2007 23:13:41 +0100
Received: from gahrtop.localhost (localhost [127.0.0.1])
	by gahrtop.localhost (Postfix) with ESMTP id 4085973070
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 17 Dec 2007 23:12:11 +0100 (CET)
Message-Id: <1197929531.71105@gahrtop.localhost>
Date: Mon, 17 Dec 2007 23:12:11 +0100
From: "Pietro Cerutti" <gahr@gahr.ch>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: [patch] ftp/junglemonkey unbreak fix linker problem
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         118797
>Category:       ports
>Synopsis:       [patch] ftp/junglemonkey unbreak fix linker problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 17 22:20:01 UTC 2007
>Closed-Date:    Tue Dec 18 18:37:16 UTC 2007
>Last-Modified:  Tue Dec 18 18:40:03 UTC 2007
>Originator:     Pietro Cerutti
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:


System: FreeBSD 8.0-CURRENT #17: Thu Dec 13 11:23:40 CET 2007
    root@gahrtop.localhost:/usr/obj/usr/src/sys/MSI1034



>Description:


The patch below:

- fixes a linker problem when not using libtool 15
- fixes a bug causing the program to crash on exit if the hostname was not set yet


>How-To-Repeat:





>Fix:


--- _junglemonkey.diff begins here ---
--- Makefile.orig	2007-12-17 22:55:08.000000000 +0100
+++ Makefile	2007-12-17 23:00:46.000000000 +0100
@@ -17,11 +17,10 @@
 
 LIB_DEPENDS=	gnet.7:${PORTSDIR}/net/gnet
 
-BROKEN=		Does not build
-
 USE_X_PREFIX=	yes
 USE_GNOME=	gnomehack gnomeprefix libglade
 USE_GMAKE=	yes
+USE_AUTOTOOLS=	libtool:15
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--enable-gnome=yes --enable-debug=no
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
--- /dev/null	2007-12-17 23:11:28.000000000 +0100
+++ files/patch-src-util_sha_cache.c	2007-12-17 23:09:28.000000000 +0100
@@ -0,0 +1,11 @@
+--- src/util/sha_cache.c.orig	2007-12-17 23:04:06.000000000 +0100
++++ src/util/sha_cache.c	2007-12-17 23:09:16.000000000 +0100
+@@ -213,7 +213,7 @@
+   g_return_if_fail (sha_cache);
+   g_return_if_fail (file);
+ 
+-  g_hash_table_foreach (sha_cache->path_to_sha, write_hfunc, file);
++  if(sha_cache) g_hash_table_foreach (sha_cache->path_to_sha, write_hfunc, file);
+ }
+ 
+ 
--- _junglemonkey.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Dec 17 22:20:10 UTC 2007 
Responsible-Changed-Why:  
miwi@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118797 

From: Pietro Cerutti <gahr@gahr.ch>
To: bug-followup@FreeBSD.org, gahr@gahr.ch
Cc:  
Subject: Re: ports/118797: [patch] ftp/junglemonkey unbreak fix linker problem
Date: Mon, 17 Dec 2007 23:47:18 +0100

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enigCAEA26C8BCB91FB1030B68BD
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Forgot to mention..
 
 Tested on:
 
 - 8.0-CURRENT i386
 - 7.0-BETA3 sparc64
 
 --=20
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 
 --------------enigCAEA26C8BCB91FB1030B68BD
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFHZvx6wMJqmJVx944RCuzqAKCL/5k7uIeUj1qCsZnwT+e5OZDpawCdHgPx
 J+H4OXoiwYZSH1q0J7LVTRw=
 =aJBn
 -----END PGP SIGNATURE-----
 
 --------------enigCAEA26C8BCB91FB1030B68BD--
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Dec 18 18:37:15 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118797 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/118797: commit references a PR
Date: Tue, 18 Dec 2007 18:37:23 +0000 (UTC)

 miwi        2007-12-18 18:37:18 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ftp/junglemonkey     Makefile 
   Added files:
     ftp/junglemonkey/files patch-src-util_sha_cache.c 
   Log:
   - Fixes a linker problem when not using libtool 15
   - Fixes a bug causing the program to crash on exit
     if the hostname was not set yet
   
   PR:             118797
   Submitted by:   Pietro Cerutti <gahr@gahr.ch>
   
   Revision  Changes    Path
   1.31      +1 -2      ports/ftp/junglemonkey/Makefile
   1.1       +11 -0     ports/ftp/junglemonkey/files/patch-src-util_sha_cache.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
