From nobody@FreeBSD.org  Wed Nov 28 14:06:30 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D717616A417
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 14:06:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A7DA513C458
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 14:05:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lASE4A1s025312
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 14:04:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lASE4AZ8025307;
	Wed, 28 Nov 2007 14:04:10 GMT
	(envelope-from nobody)
Message-Id: <200711281404.lASE4AZ8025307@www.freebsd.org>
Date: Wed, 28 Nov 2007 14:04:10 GMT
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: misc/hello: [PATCH]: 2.1.1_2 -> 2.3, install-info cleanup, portlint cleanup
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: shipley@dis.org

>Number:         118311
>Category:       ports
>Synopsis:       misc/hello: [PATCH]: 2.1.1_2 -> 2.3, install-info cleanup, portlint cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 28 14:10:02 UTC 2007
>Closed-Date:    Thu Feb 07 08:31:21 UTC 2008
>Last-Modified:  Thu Feb  7 08:40:01 UTC 2008
>Originator:     Philip M. Gollucci
>Release:        8.0-CURRENT
>Organization:
Riderway Inc.
>Environment:
FreeBSD tb1.p6m7g8.net 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Tue Nov  6 16:28:12 EST 2007     pgollucci@philip.hq.rws:/usr/obj/usr/src/sys/RIDERWAY  i386

>Description:
1) use INFO macro
2) doesn't depend on USE_PERL5_BUILD
3) install-sh is missing +x bit in the dist tar ball, so set it
4) update to 2.3, drop PORTREVISION

>How-To-Repeat:

>Fix:
Apply patch

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/hello/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile	10 Jul 2004 19:25:03 -0000	1.11
+++ Makefile	28 Nov 2007 13:56:04 -0000
@@ -6,8 +6,7 @@
 #
 
 PORTNAME=	hello
-PORTVERSION=	2.1.1
-PORTREVISION=	2
+PORTVERSION=	2.3
 CATEGORIES=	misc
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	hello
@@ -19,14 +18,18 @@
 GNU_CONFIGURE=	YES
 CONFIGURE_TARGET=	--build=${ARCH}-portbld-freebsd${OSREL}
 
-MAN1=		hello.1
+MAN1=	hello.1
+INFO=	hello
 
 .if !defined(WITHOUT_NLS)
 USE_GETTEXT=	yes
 PLIST_SUB+=	NLS=""
 .else
-CONFIGURE_ARGS+=--disable-nls
+CONFIGURE_ARGS+=	--disable-nls
 PLIST_SUB+=	NLS="@comment "
 .endif
 
+pre-install:
+	${CHMOD} a+x ${WRKSRC}/build-aux/install-sh
+
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/misc/hello/distinfo,v
retrieving revision 1.4
diff -u -r1.4 distinfo
--- distinfo	22 Jan 2006 12:59:19 -0000	1.4
+++ distinfo	28 Nov 2007 13:19:25 -0000
@@ -1,3 +1,3 @@
-MD5 (hello-2.1.1.tar.gz) = 70c9ccf9fac07f762c24f2df2290784d
-SHA256 (hello-2.1.1.tar.gz) = c510e3ad0200517e3a14534e494b37dc0770efd733fc35ce2f445dd49c96a7d5
-SIZE (hello-2.1.1.tar.gz) = 389363
+MD5 (hello-2.3.tar.gz) = de3187eac06baf5f0506c06935a1fd29
+SHA256 (hello-2.3.tar.gz) = 429c779083c7c51ece716ae2f69e66caf383537a23119f9e200baf0f54c71c7a
+SIZE (hello-2.3.tar.gz) = 431983
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/misc/hello/pkg-plist,v
retrieving revision 1.6
diff -u -r1.6 pkg-plist
--- pkg-plist	22 Jan 2006 05:52:26 -0000	1.6
+++ pkg-plist	28 Nov 2007 13:50:42 -0000
@@ -1,7 +1,4 @@
 bin/hello
-@unexec install-info --delete %D/info/hello.info %D/info/dir
-info/hello.info
-@exec install-info --dir-file=%D/info/dir --entry="* Hello: (hello).		Hello Reference Manual." %D/info/hello.info
 %%NLS%%share/locale/ca/LC_MESSAGES/hello.mo
 %%NLS%%share/locale/da/LC_MESSAGES/hello.mo
 %%NLS%%share/locale/de/LC_MESSAGES/hello.mo


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Nov 28 14:13:27 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118311 

From: "Philip M. Gollucci" <philip@ridecharge.com>
To: bug-followup@FreeBSD.org,  pgollucci@p6m7g8.com
Cc:  
Subject: Re: ports/118311: misc/hello: [PATCH]: 2.1.1_2 -&gt; 2.3, install-info
 cleanup, portlint cleanup
Date: Wed, 6 Feb 2008 17:51:46 -0500

 poke, its been 2.3 months.
 
State-Changed-From-To: feedback->closed 
State-Changed-By: rafan 
State-Changed-When: Thu Feb 7 08:31:20 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118311 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/118311: commit references a PR
Date: Thu,  7 Feb 2008 08:31:13 +0000 (UTC)

 rafan       2008-02-07 08:31:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     misc/hello           Makefile distinfo pkg-plist 
   Log:
   - Update to 2.3
   - Use INFO macro
   - Add proper CFLAGS/LDFLAGS for USE_GETTEXT
   
   PR:             ports/118311
   Submitted by:   Philip M. Gollucci <pgollucci at p6m7g8.com>
   Approved by:    maintainer timeout (10 weeks)
   
   Revision  Changes    Path
   1.12      +11 -3     ports/misc/hello/Makefile
   1.5       +3 -3      ports/misc/hello/distinfo
   1.7       +13 -3     ports/misc/hello/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
