From nobody@FreeBSD.org  Mon Nov 19 22:01:24 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 92AA616A417
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Nov 2007 22:01:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A73B13C45D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Nov 2007 22:01:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lAJM0gDh077330
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 19 Nov 2007 22:00:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id lAJM0gY2077329;
	Mon, 19 Nov 2007 22:00:42 GMT
	(envelope-from nobody)
Message-Id: <200711192200.lAJM0gY2077329@www.freebsd.org>
Date: Mon, 19 Nov 2007 22:00:42 GMT
From: Rainer Schwarze <rsc@admadic.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY not correctly passed to configure
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: lippe@freebsdbrasil.com.br

>Number:         118139
>Category:       ports
>Synopsis:       [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY not correctly passed to configure
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 19 22:10:01 UTC 2007
>Closed-Date:    Sat Dec 15 22:26:17 UTC 2007
>Last-Modified:  Sat Dec 15 22:30:02 UTC 2007
>Originator:     Rainer Schwarze
>Release:        FreeBSD 6,2-RELEASE i386
>Organization:
admaDIC
>Environment:
FreeBSD <not-shown> 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 10:40:27 UTC 2007     root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
In port mail/qmail-scanner the Makefile does not correctly append the QS_NOTIFY value to CONFIGURE_ARGS when QS_NOTIFY has been specified with the make call. 

When QS_NOTIFY is not specified, the Makefile defaults will be used, when it is specified, the Makefile does not append "--notify ..." to CONFIGURE_ARGS and the defaults of the configure script are used.

For instance, if the notifications should only be sent to the admin ( make QS_NOTIFY=admin ), the result of the build process is as if configure was called with "--notify psender,precips" instead of "--notify admin".
>How-To-Repeat:
Run "make QS_NOTIFY=admin". Run "grep NOTIFY_ADDRS work/qmail-scanner-2.01/qmail-scanner-queue.pl" - the first line will read "my $NOTIFY_ADDRS='psender,nmlvadm'". It should be "my $NOTIFY_ADDRS='admin'"
>Fix:
(See patch file)

After these lines in Makefile:

.if !defined(QS_NOTIFY)
CONFIGURE_ARGS+=        --notify psender,precips
.endif

add these lines:

.if defined(QS_NOTIFY)
CONFIGURE_ARGS+=        --notify "${QS_NOTIFY}"
.endif


Patch attached with submission follows:

--- /usr/ports/mail/qmail-scanner/Makefile	Sat Nov 17 15:14:58 2007
+++ ./Makefile	Fri Nov  9 23:24:42 2007
@@ -109,6 +109,10 @@
 CONFIGURE_ARGS+=	--notify psender,precips
 .endif
 
+.if defined(QS_NOTIFY)
+CONFIGURE_ARGS+=	--notify "${QS_NOTIFY}"
+.endif
+
 .if defined(QS_LOCALDOMAINS) && !empty(QS_LOCALDOMAINS)
 CONFIGURE_ARGS+=	--local-domains "${QS_LOCALDOMAINS}"
 .endif


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Nov 19 22:10:08 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118139 

From: Felippe de Meirelles Motta <lippe@freebsdbrasil.com.br>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/118139: [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY
 not correctly passed to configure
Date: Tue, 20 Nov 2007 13:33:04 +0000

 This is a multi-part message in MIME format.
 --------------030808080704040509040809
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Edwin Groothuis escreveu:
 > Maintainer of mail/qmail-scanner,
 > 
 > Please note that PR ports/118139 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/118139
 > 
 
 Hello Edwin,
 
 Yes, I agree that with minor changes, follow as attach, thanks!
 
 -- 
 
 Atenciosamente,
 Felippe de Meirelles Motta
 FreeBSD Brasil LTDA.
 http://www.freebsdbrasil.com.br
 
 --------------030808080704040509040809
 Content-Type: text/x-patch;
  name="qscanner.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="qscanner.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/ports/mail/qmail-scanner/Makefile,v
 retrieving revision 1.18
 diff -u -r1.18 Makefile
 --- Makefile	5 Oct 2007 14:19:51 -0000	1.18
 +++ Makefile	20 Nov 2007 13:27:17 -0000
 @@ -85,11 +85,11 @@
  CONFIGURE_ARGS+=	--normalize no
  .endif
  
 -.if !defined(QS_USER)
 +.if defined(QS_USER)
  CONFIGURE_ARGS+=	--qs-user "${QS_USER}"
  .endif
  
 -.if !defined(QS_ADMIN)
 +.if defined(QS_ADMIN)
  CONFIGURE_ARGS+=	--admin "${QS_ADMIN}"
  .endif
  
 @@ -107,6 +107,8 @@
  
  .if !defined(QS_NOTIFY)
  CONFIGURE_ARGS+=	--notify psender,precips
 +.else
 +CONFIGURE_ARGS+=	--notify "${QS_NOTIFY}"
  .endif
  
  .if defined(QS_LOCALDOMAINS) && !empty(QS_LOCALDOMAINS)
 
 --------------030808080704040509040809--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Nov 20 14:56:42 UTC 2007 
State-Changed-Why:  
Maintainer has supplied a patch in the followup. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118139 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sat Dec 15 22:22:37 UTC 2007 
State-Changed-Why:  
Patch from maintainer committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118139 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/118139: commit references a PR
Date: Sat, 15 Dec 2007 22:26:05 +0000 (UTC)

 pav         2007-12-15 22:26:01 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/qmail-scanner   Makefile 
   Log:
   - Properly pass QS_USER, QS_ADMIN and QS_NOTIFY values to configure script
   
   PR:             ports/118139
   Submitted by:   Rainer Schwarze <rsc@admadic.de>,
                   Felippe de Meirelles Motta <lippe@freebsdbrasil.com.br> (maintainer) (patch used)
   
   Revision  Changes    Path
   1.19      +5 -3      ports/mail/qmail-scanner/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
