From nobody@FreeBSD.org  Wed Nov  7 21:10:16 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45A9416A46B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Nov 2007 21:10:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 14F5313C4B5
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Nov 2007 21:10:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lA7L9xO3083586
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 7 Nov 2007 21:09:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id lA7L9x5c083585;
	Wed, 7 Nov 2007 21:09:59 GMT
	(envelope-from nobody)
Message-Id: <200711072109.lA7L9x5c083585@www.freebsd.org>
Date: Wed, 7 Nov 2007 21:09:59 GMT
From: Stephen Hurd <shurd@sasktel.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] net-im/amsn configure script broken
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: yinjieh@csie.nctu.edu.tw

>Number:         117897
>Category:       ports
>Synopsis:       [PATCH] net-im/amsn configure script broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tabthorpe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 07 21:20:01 UTC 2007
>Closed-Date:    Sat Jan 26 03:13:01 UTC 2008
>Last-Modified:  Sat Jan 26 03:20:01 UTC 2008
>Originator:     Stephen Hurd
>Release:        6.2-RELEASE-p6
>Organization:
>Environment:
FreeBSD server.hurd.local 6.2-RELEASE-p6 FreeBSD 6.2-RELEASE-p6 #3: Tue Jul 24 22:03:03 PDT 2007     root@server.hurd.local:/usr/src/sys/i386/compile/SERVER  i386

>Description:
The configure script in net-im/amsn uses gtest-isms, tclsh, doesn't pass additional include paths to cc -E for header tests, and overrides command-line parameters in favour of ones from /usr/local/lib/tk8.4/tkConfig.sh.

>How-To-Repeat:
Attempt to build net-im/amsn
>Fix:
Add the attached file to the files directory.

Patch attached with submission follows:

--- configure.orig	Wed Nov  1 09:05:49 2006
+++ configure	Wed Nov  7 13:03:49 2007
@@ -1334,7 +1334,7 @@
 fi;
 
 
-if test "$enable_debug" == "yes" ; then
+if test "$enable_debug" = "yes" ; then
     DEBUG="yes"
 else
     DEBUG="no"
@@ -1347,7 +1347,7 @@
 fi;
 
 
-if test "$enable_static" == "yes" ; then
+if test "$enable_static" = "yes" ; then
     STATIC="yes"
 else
     STATIC="no"
@@ -1472,7 +1472,7 @@
 fi
 
 
-TCLSH=`which tclsh`
+TCLSH=`which tclsh8.4`
 VERSION=`echo "puts $::tcl_version ; exit" | ${TCLSH}`
 # Check whether --enable-version-check or --disable-version-check was given.
 if test "${enable_version_check+set}" = set; then
@@ -1484,7 +1484,7 @@
 
 OLDV=`expr $VERSION \< 8.4`
 
-if test "x${version_ok}" == "xyes" -a $OLDV == 1; then
+if test "x${version_ok}" = "xyes" -a "$OLDV" = "1"; then
     { { echo "$as_me:$LINENO: error: Your current Tcl/Tk installation has a version number of $VERSION. The minimal version required for aMSN to run is Tcl/Tk 8.4" >&5
 echo "$as_me: error: Your current Tcl/Tk installation has a version number of $VERSION. The minimal version required for aMSN to run is Tcl/Tk 8.4" >&2;}
    { (exit 1); exit 1; }; }
@@ -2425,7 +2425,7 @@
 
 
 CC_INSTALLED=`which $CC`
-if test "x${CC_INSTALLED}" == "x"; then
+if test "x${CC_INSTALLED}" = "x"; then
     { { echo "$as_me:$LINENO: error: You need a C compiler (gcc) to compiler aMSN. Please install gcc and try again" >&5
 echo "$as_me: error: You need a C compiler (gcc) to compiler aMSN. Please install gcc and try again" >&2;}
    { (exit 1); exit 1; }; }
@@ -2788,7 +2788,7 @@
 
 
 CXX_INSTALLED=`which $CXX`
-if test "x${CXX_INSTALLED}" == "x"; then
+if test "x${CXX_INSTALLED}" = "x"; then
      { { echo "$as_me:$LINENO: error: You need a C++ compiler (g++) to compiler aMSN. Please install g++ and try again" >&5
 echo "$as_me: error: You need a C++ compiler (g++) to compiler aMSN. Please install g++ and try again" >&2;}
    { (exit 1); exit 1; }; }
@@ -2864,10 +2864,9 @@
 			if test "x${version_ok}" != "xyes"; then
 			VERSION=${TCL_VERSION}
 			fi
-
 				if  test "x${TCL_INC_DIR}" != "x" -o "x${TCL_INC_SPEC}" != "x" \
 					-o "x${TCL_INCLUDE_DIR}" != "x" -o "x${TCL_INCLUDE_SPEC}" != "x"; then
-				if test "x${TCL_VERSION}" == "x${VERSION}" ; then
+				if test "x${TCL_VERSION}" = "x${VERSION}" ; then
 				TCL_LIB_DIR=`cd $i; pwd`
 				break;
 				fi
@@ -2924,15 +2923,15 @@
 	TCL_INC_DIR=$TCL_INCLUDE_SPEC
 	fi
 
-	if test "x${TCL_INC_DIR}" == "x"; then
+	if test "x${TCL_INC_DIR}" = "x"; then
 	TCL_INC_DIR=$TCL_INCLUDE_DIR
 	fi
 
-	if test "x${TCL_INC_DIR}" == "x" -a -f ${TCL_PREFIX}/include/tcl.h; then
+	if test "x${TCL_INC_DIR}" = "x" -a -f ${TCL_PREFIX}/include/tcl.h; then
 	TCL_INC_DIR=${TCL_PREFIX}/include
 	fi
 
-	if test "x${TCL_INC_DIR}" == "x"; then
+	if test "x${TCL_INC_DIR}" = "x"; then
 	{ { echo "$as_me:$LINENO: error: You dot not have a devel package of Tcl" >&5
 echo "$as_me: error: You dot not have a devel package of Tcl" >&2;}
    { (exit 1); exit 1; }; }
@@ -2946,7 +2945,7 @@
 	TCL_INC_SPEC=$TCL_INC_DIR
 
 	framework=`echo "${TCL_BASE}" | grep -- "-framework"`
-	if test "x${framework}" == "x"; then
+	if test "x${framework}" = "x"; then
 	TCL_LIB_SPEC="-L${TCL_LIB_DIR} -l${TCL_BASE}"
 	fi
 	TCL_STUB_LIB_SPEC="-L${TCL_LIB_DIR} -l${TCL_STUB_BASE}"
@@ -3016,7 +3015,7 @@
 
 		if  test "x${TK_INC_DIR}" != "x" -o "x${TK_INC_SPEC}" != "x" \
 				-o "x${TK_INCLUDE_DIR}" != "x" -o "x${TK_INCLUDE_SPEC}" != "x"; then
-				if test "x${TK_VERSION}" == "x${VERSION}"; then
+				if test "x${TK_VERSION}" = "x${VERSION}"; then
 			TK_LIB_DIR=`cd $i; pwd`
 			break;
 			fi
@@ -3060,19 +3059,19 @@
 	TK_INC_DIR=$TK_INC_SPEC
 	fi
 
-	if  test "x${TK_INCLUDE_SPEC}" != "x"; then
-	TK_INC_DIR=$TK_INCLUDE_SPEC
-	fi
+	#if  test "x${TK_INCLUDE_SPEC}" != "x"; then
+	#TK_INC_DIR=$TK_INCLUDE_SPEC
+	#fi
 
-	if test "x${TK_INC_DIR}" == "x"; then
+	if test "x${TK_INC_DIR}" = "x"; then
 	TK_INC_DIR=$TK_INCLUDE_DIR
 	fi
 
-	if test "x${TK_INC_DIR}" == "x" -a -f ${TK_PREFIX}/include/tk.h; then
+	if test "x${TK_INC_DIR}" = "x" -a -f ${TK_PREFIX}/include/tk.h; then
 	TK_INC_DIR=${TK_PREFIX}/include
 	fi
 
-	if test "x${TK_INC_DIR}" == "x"; then
+	if test "x${TK_INC_DIR}" = "x"; then
 	{ { echo "$as_me:$LINENO: error: You dot not have a devel package of Tk" >&5
 echo "$as_me: error: You dot not have a devel package of Tk" >&2;}
    { (exit 1); exit 1; }; }
@@ -3186,7 +3185,7 @@
   echo $ECHO_N "(cached) $ECHO_C" >&6
 else
       # Double quotes because CPP needs to be expanded
-    for CPP in "$CC -E" "$CC -E -traditional-cpp" "/lib/cpp"
+    for CPP in "$CC -E $CFLAGS $CPPFLAGS" "$CC -E -traditional-cpp" "/lib/cpp"
     do
       ac_preproc_ok=false
 for ac_c_preproc_warn_flag in '' yes


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Nov 7 21:22:39 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117897 

From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org, shurd@sasktel.net
Cc:  
Subject: Re: ports/117897: [PATCH] net-im/amsn configure script broken
Date: Sun, 25 Nov 2007 20:29:51 +0000 (GMT)

 I can confirm that this patch fixes the port for me too.
 
 Gavin

From: "Stephen Hurd" <shurd@broadcom.com>
To: bug-followup@FreeBSD.org
Cc: shurd@sasktel.net,
	yinjieh@csie.nctu.edu.tw
Subject: Re: ports/117897: [PATCH] net-im/amsn configure script broken
Date: Thu, 17 Jan 2008 17:11:46 -0800

 This is a multi-part message in MIME format.
 
 ------_=_NextPart_001_01C8596F.1929FB74
 Content-Type: text/plain;
  charset=us-ascii
 Content-Transfer-Encoding: quoted-printable
 
 Ping?
 
 ------_=_NextPart_001_01C8596F.1929FB74
 Content-Type: text/html;
  charset=us-ascii
 Content-Transfer-Encoding: quoted-printable
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
 <HTML><HEAD>
 <META http-equiv=3DContent-Type content=3D"text/html; =
 charset=3Dus-ascii">
 <META content=3D"MSHTML 6.00.2900.3243" name=3DGENERATOR></HEAD>
 <BODY>
 <DIV><SPAN class=3D120501001-18012008><FONT face=3DArial=20
 size=3D2>Ping?</FONT></SPAN></DIV></BODY></HTML>
 
 ------_=_NextPart_001_01C8596F.1929FB74--
 

From: Ying-Chieh Chen <yinjieh@csie.nctu.edu.tw>
To: Stephen Hurd <shurd@broadcom.com>
Cc: bug-followup@FreeBSD.org, shurd@sasktel.net
Subject: Re: ports/117897: [PATCH] net-im/amsn configure script broken
Date: Fri, 18 Jan 2008 15:44:23 +0800

 I approve this patch, please commit it.
 
 Thanks!
 
 - yinjieh
 
 On Thu, Jan 17, 2008 at 05:11:46PM -0800, Stephen Hurd wrote:
 > Ping?
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Jan 18 09:35:55 UTC 2008 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117897 
Responsible-Changed-From-To: freebsd-ports-bugs->tabthorpe 
Responsible-Changed-By: tabthorpe 
Responsible-Changed-When: Fri Jan 25 19:36:22 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117897 
State-Changed-From-To: open->closed 
State-Changed-By: tabthorpe 
State-Changed-When: Sat Jan 26 03:13:00 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117897 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/117897: commit references a PR
Date: Sat, 26 Jan 2008 03:12:30 +0000 (UTC)

 tabthorpe    2008-01-26 03:12:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-im/amsn          Makefile 
     net-im/amsn/files    patch-configure 
   Log:
   - Fix configure script
   - While I am here, use SF macro
   
   PR:             ports/117897
   Submitted by:   Stephen Hurd <shurd sasktel.net>
   Approved by:    Ying-Chieh Chen <yinjieh csie.nctu.edu.tw> (maintainer)
   Sponsored by:   FreeBSD Bug-a-thon #3
   
   Revision  Changes    Path
   1.32      +1 -2      ports/net-im/amsn/Makefile
   1.2       +135 -7    ports/net-im/amsn/files/patch-configure
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
