From nobody@FreeBSD.org  Tue Oct 30 17:30:17 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0FC7316A420
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Oct 2007 17:30:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0053F13C4A5
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Oct 2007 17:30:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9UHUG7Z008949
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 30 Oct 2007 17:30:16 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9UHUGAh008946;
	Tue, 30 Oct 2007 17:30:16 GMT
	(envelope-from nobody)
Message-Id: <200710301730.l9UHUGAh008946@www.freebsd.org>
Date: Tue, 30 Oct 2007 17:30:16 GMT
From: Olivier Smedts <olivier@gid0.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: print/fontforge : extract fails when building with NOPORTDOCS=yes
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: cyberbotx@cyberbotx.com

>Number:         117686
>Category:       ports
>Synopsis:       print/fontforge : extract fails when building with NOPORTDOCS=yes
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 30 17:40:02 UTC 2007
>Closed-Date:    Fri Dec 14 12:06:35 UTC 2007
>Last-Modified:  Fri Dec 14 12:06:35 UTC 2007
>Originator:     Olivier Smedts
>Release:        6.2-STABLE
>Organization:
gid0.org
>Environment:
>Description:
print/fontforge fails during post-extract when building with NOPORTDOCS=yes, cause  ${DOCFILES} is empty.
>How-To-Repeat:
# cd /usr/ports/print/fontforge
# make
===>  Vulnerability check disabled, database not found
===>  Extracting for fontforge-20071002
=> MD5 Checksum OK for fontforge_full-20071002.tar.bz2.
=> SHA256 Checksum OK for fontforge_full-20071002.tar.bz2.
/bin/mkdir -p /work/ports/print/fontforge/work/html /work/ports/print/fontforge/work/fontforge-20071002/cidmap
for doc in  ;  do /usr/bin/tar -xjC /work/ports/print/fontforge/work/html -f /usr/ports/distfiles/${doc} ;  done
/usr/bin/tar -xzC /work/ports/print/fontforge/work/fontforge-20071002/cidmap -f /work/ports/print/fontforge/work/html/cidmaps.tgz
tar: Error opening archive: Failed to open '/work/ports/print/fontforge/work/html/cidmaps.tgz': No such file or directory
*** Error code 1

Stop in /work/ports/print/fontforge.

>Fix:
I think the "for doc in ${DOCFILES}" loop should be enclodes in an "if !defined(NOPORTDOCS)".

>Release-Note:
>Audit-Trail:

From: "Olivier SMEDTS" <olivier@gid0.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/117686: print/fontforge : extract fails when building with NOPORTDOCS=yes
Date: Tue, 30 Oct 2007 21:03:34 +0100

 In fact, all post-extract should be enclosed by if !defined(NOPORTDOCS) :
 
 --- /tmp/Makefile       2007-10-30 21:00:26.000000000 +0100
 +++ /usr/ports/print/fontforge/Makefile 2007-10-30 18:32:42.000000000 +0100
 @@ -84,6 +84,7 @@
         @${ECHO_MSG} ""
  .endif
 
 +.if !defined(NOPORTDOCS)
  post-extract:
         ${MKDIR} ${WRKDIR}/html ${WRKSRC}/cidmap
         for doc in ${DOCFILES} ; \
 @@ -91,6 +92,7 @@
         done
         ${TAR} -xzC ${WRKSRC}/cidmap -f ${WRKDIR}/html/cidmaps.tgz
         ${RM} ${WRKDIR}/html/cidmaps.tgz
 +.endif
 
  .if !defined(FONTFORGE_NO_PLUGINS)
  post-build:
 
 -- 
 Olivier Smedts                                                 _
                                         ASCII ribbon campaign ( )
 e-mail: olivier@gid0.org        - against HTML email & vCards  X
 www: http://www.gid0.org    - against proprietary attachments / \
 
   "Il y a seulement 10 sortes de gens dans le monde :
   ceux qui comprennent le binaire,
   et ceux qui ne le comprennent pas."
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Oct 31 00:58:42 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117686 
State-Changed-From-To: feedback->analyzed 
State-Changed-By: pav 
State-Changed-When: Thu Dec 13 23:46:38 UTC 2007 
State-Changed-Why:  
This patch included in maintainer's update in ports/118637 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Thu Dec 13 23:46:38 UTC 2007 
Responsible-Changed-Why:  
Grab 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117686 
State-Changed-From-To: analyzed->closed 
State-Changed-By: pav 
State-Changed-When: Fri Dec 14 12:06:28 UTC 2007 
State-Changed-Why:  
Fixed in cvs 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117686 
>Unformatted:
