From nobody@FreeBSD.org  Fri Oct 26 19:32:39 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 63AD316A418
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Oct 2007 19:32:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 5398913C491
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Oct 2007 19:32:39 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9QJW865098377
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 26 Oct 2007 19:32:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9QJW8oL098376;
	Fri, 26 Oct 2007 19:32:08 GMT
	(envelope-from nobody)
Message-Id: <200710261932.l9QJW8oL098376@www.freebsd.org>
Date: Fri, 26 Oct 2007 19:32:08 GMT
From: pluknet <pluknet@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] unbrake www/mod_ntlm on gcc 4.2
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         117540
>Category:       ports
>Synopsis:       [patch] unbrake www/mod_ntlm on gcc 4.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    skv
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 26 19:40:01 UTC 2007
>Closed-Date:    Wed Dec 12 23:29:28 UTC 2007
>Last-Modified:  Wed Dec 12 23:30:07 UTC 2007
>Originator:     pluknet
>Release:        7.0-BETA1
>Organization:
>Environment:
7.0-BETA1, gcc 4.2.1 20070719  [FreeBSD]
>Description:
this patch helps to build www/mod_ntlm on OSVERSION >= 700042 (with gcc 4.2.1)
I have at least one positive response from testers.
>How-To-Repeat:
run 'make' to see that: "Does not compile with GCC 4.2"
>Fix:
Apply the patch against www/mod_ntlm/

Patch attached with submission follows:

--- Makefile.orig	2007-10-26 09:16:41.000000000 +0400
+++ Makefile	2007-10-26 09:29:46.000000000 +0400
@@ -2,7 +2,7 @@
 # Date created:	   04 July 2004
 # Whom:		   Sergey Skvortsov <skv@protey.ru>
 #
-# $FreeBSD: ports/www/mod_ntlm/Makefile,v 1.3 2007/09/30 09:35:55 linimon Exp $
+# $FreeBSD$
 #
 
 PORTNAME=	mod_ntlm
@@ -17,12 +17,17 @@
 USE_APACHE=	YES
 MAKE_ENV=	APXS=${APXS}
 
+.include <bsd.port.pre.mk>
+
 post-patch:
 	${FIND} ${WRKSRC}/smbval -name "*.inc.c" -type f|${XARGS} \
 		${REINPLACE_CMD} -e "s/malloc.h/stdlib.h/g"
 	${REINPLACE_CMD} -e "s/APXS=.*//" ${WRKSRC}/Makefile
 	${REINPLACE_CMD} -e "s!#include <sys/vfs.*!!" \
 		${WRKSRC}/smbval/smbencrypt.inc.c
+.if ${OSVERSION} >= 700042
+	${REINPLACE_CMD} -e "s/extern/static/" ${WRKSRC}/smbval/smblib-priv.h
+.endif
 
 post-install:
 .ifndef(NOPORTDOCS)
@@ -31,10 +36,4 @@
 	${INSTALL_DATA} ${WRKSRC}/Documentation/mod_ntlm.html ${DOCSDIR}
 .endif
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 700042
-BROKEN=                Does not compile with GCC 4.2
-.endif
-
 .include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->skv 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Oct 26 19:40:08 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117540 
State-Changed-From-To: open->closed 
State-Changed-By: skv 
State-Changed-When: Wed Dec 12 23:29:22 UTC 2007 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117540 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/117540: commit references a PR
Date: Wed, 12 Dec 2007 23:29:21 +0000 (UTC)

 skv         2007-12-12 23:29:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/mod_ntlm         Makefile 
   Log:
   Unbreak build with GCC 4.2
   
   PR:             ports/117540
   Submitted by:   pluknet xx gmail.com
   
   Revision  Changes    Path
   1.4       +5 -6      ports/www/mod_ntlm/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
