From nobody@FreeBSD.org  Sat Oct 20 13:45:06 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AD88216A41A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 20 Oct 2007 13:45:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A4CE513C448
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 20 Oct 2007 13:45:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9KDim0L047671
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 20 Oct 2007 13:44:48 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9KDimTZ047670;
	Sat, 20 Oct 2007 13:44:48 GMT
	(envelope-from nobody)
Message-Id: <200710201344.l9KDimTZ047670@www.freebsd.org>
Date: Sat, 20 Oct 2007 13:44:48 GMT
From: bf <bf2006a@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]multimedia/gxine: respect CFLAGS
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: makc@issp.ac.ru

>Number:         117360
>Category:       ports
>Synopsis:       [PATCH]multimedia/gxine: respect CFLAGS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 20 13:50:00 UTC 2007
>Closed-Date:    Sat Dec 22 17:22:24 UTC 2007
>Last-Modified:  Sat Dec 22 17:22:24 UTC 2007
>Originator:     bf
>Release:        6.2-Stable i386
>Organization:
-
>Environment:
>Description:
I think it would be best to respect CFLAGS.  If some flags are problematic, a note  recommending a certain set and warning against others could be added, instead of forcing the users to adopt a default set or to make a custom build:

diff -ruN gxine.orig/Makefile gxine/Makefile
--- gxine.orig/Makefile	Sat Oct 20 04:48:31 2007
+++ gxine/Makefile	Sat Oct 20 04:49:30 2007
@@ -25,7 +25,7 @@
 		LDFLAGS="-L${LOCALBASE}/lib -I${X11BASE}/lib"
 CONFIGURE_ARGS+=--x-includes=${X11BASE}/include \
 		--x-libraries=${X11BASE}/lib
-CFLAGS=		-O2 -fno-strict-aliasing -pipe
+CFLAGS?=	-O2 -fno-strict-aliasing -pipe
 INSTALLS_ICONS=	yes
 
 MANLANG=	"" de
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Oct 20 13:50:05 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117360 

From: Max Brazhnikov <makc@issp.ac.ru>
To: bug-followup@freebsd.org, bf2006a@yahoo.com
Cc:  
Subject: Re: ports/117360: [PATCH]multimedia/gxine: respect CFLAGS
Date: Sat, 20 Oct 2007 23:43:15 +0400

 The problem is that gxine fails to compile on pointyhat with default 
 (non-optimized) CFLAGS.
 I'll play with flags with next release, until then I wouldn't change anything.
 Regards
State-Changed-From-To: feedback->closed 
State-Changed-By: stefan 
State-Changed-When: Sat Dec 22 17:19:50 UTC 2007 
State-Changed-Why:  
Maintainer prefers to explicitly set CFLAGS to a working value and will check if 
the user's CFLAGS can be respected with the next version. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117360 
>Unformatted:
