From nobody@FreeBSD.org  Thu Oct 18 00:27:11 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1074416A420
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Oct 2007 00:27:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0848113C45B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Oct 2007 00:27:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9I0Qwfc026096
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Oct 2007 00:26:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9I0QwK6026095;
	Thu, 18 Oct 2007 00:26:58 GMT
	(envelope-from nobody)
Message-Id: <200710180026.l9I0QwK6026095@www.freebsd.org>
Date: Thu, 18 Oct 2007 00:26:58 GMT
From: Oleg Pudeyev <oleg.pudeyev@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] graphics/feh: remove dependency on shells/bash
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         117284
>Category:       ports
>Synopsis:       [patch] graphics/feh: remove dependency on shells/bash
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 18 00:30:01 UTC 2007
>Closed-Date:    Tue Oct 23 13:36:12 UTC 2007
>Last-Modified:  Tue Oct 23 15:20:01 UTC 2007
>Originator:     Oleg Pudeyev
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD kappa.universe 6.2-RELEASE FreeBSD 6.2-RELEASE #2: Wed Jul 18 01:25:26 EDT 2007     root@kappa.universe:/build/src/sys/i386/compile/KAPPA  i386
>Description:
Attached patch removes dependency of graphics/feh on shells/bash. Only one installed shell script (gen_cam_menu.sh) appears to use bash, and nothing in that shell script seems to require bash. The patch replaces /bin/bash reference with /bin/sh and removes bash from RUN_DEPENDS.

I have also filed a ticket with feh developers at http://linuxbrit.co.uk/feh/ticket/34.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/graphics/feh/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile	19 May 2007 20:08:59 -0000	1.24
+++ Makefile	18 Oct 2007 00:19:37 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	feh
 PORTVERSION=	1.3.4
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	graphics
 MASTER_SITES=	http://linuxbrit.co.uk/downloads/
 
@@ -15,7 +15,6 @@
 COMMENT=	An image viewer that utilizes Imlib2
 
 LIB_DEPENDS=	giblib.1:${PORTSDIR}/graphics/giblib
-RUN_DEPENDS=	bash:${PORTSDIR}/shells/bash
 
 USE_X_PREFIX=	yes
 USE_PERL5=	yes
@@ -36,7 +35,7 @@
 	@${PERL} -pi.bak -e \
 		's|-man install-docsDATA|-man|g' ${WRKSRC}/Makefile.in
 	@${PERL} -pi.bak -e \
-		's|^#!/bin|#!${LOCALBASE}/bin|g' ${WRKSRC}/cam/gen_cam_menu.sh
+		's|^#!/bin/bash|#!/bin/sh|g' ${WRKSRC}/cam/gen_cam_menu.sh
 	@${PERL} -pi.bak -e \
 		's|^LDFLAGS.*$$|LDFLAGS = \@LDFLAGS\@|g ; \
 		 s|-I/usr/X11R6/include||g ; \


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Sat Oct 20 12:26:17 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117284 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Oct 23 13:36:11 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117284 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/117284: commit references a PR
Date: Tue, 23 Oct 2007 15:19:03 +0000 (UTC)

 miwi        2007-10-23 13:35:50 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/feh         Makefile 
   Log:
   - Remove dependency on shells/bash
   
   PR:             117284
   Submitted by:   Oleg Pudeyev <oleg.pudeyev@gmail.com>
   
   Revision  Changes    Path
   1.25      +2 -3      ports/graphics/feh/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
