From nobody@FreeBSD.org  Tue Oct 16 22:39:07 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D990516A418
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Oct 2007 22:39:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D214913C491
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Oct 2007 22:39:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9GMcvvY041039
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Oct 2007 22:38:57 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9GMcv0d041038;
	Tue, 16 Oct 2007 22:38:57 GMT
	(envelope-from nobody)
Message-Id: <200710162238.l9GMcv0d041038@www.freebsd.org>
Date: Tue, 16 Oct 2007 22:38:57 GMT
From: Dominic Fandrey <lon_kamikaze@gmx.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch][graphics/libvisual] fix for RELENG_7
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         117258
>Category:       ports
>Synopsis:       [patch] graphics/libvisual: fix for RELENG_7
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 16 22:40:02 UTC 2007
>Closed-Date:    Wed Oct 17 11:12:04 UTC 2007
>Last-Modified:  Wed Oct 17 11:20:01 UTC 2007
>Originator:     Dominic Fandrey
>Release:        RELENG_7
>Organization:
private
>Environment:
FreeBSD mobileKamikaze.norad 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Fri Oct 12 16:36:39 CEST 2007     root@homeKamikaze.norad:/usr/obj/TPR40-7/i386/usr/src/sys/TPR40-7  i386
>Description:
Libvisual does not build on RELENG_7, because libvisual requires MMX and the port ignores CFLAGS (and thus CPUTYPE). This patch fixes it and adds -mmmx to the CFLAGS, to make sure that MMX support is activated, even for conservative CPUTYPEs.
>How-To-Repeat:

>Fix:
--- graphics/libvisual/Makefile.orig	2007-10-17 00:29:15.000000000 +0200
+++ graphics/libvisual/Makefile	2007-10-17 00:31:42.000000000 +0200
@@ -21,20 +21,14 @@
 USE_XLIBS=	yes
 USE_GNOME=	gnomehack pkgconfig
 USE_AUTOTOOLS=	libtool:15
-CONFIGURE_ENV=	CFLAGS="-I${LOCALBASE}/include -I${X11BASE}/include ${PTHREAD_CFLAGS}" \
+CONFIGURE_ENV=	CFLAGS="${CFLAGS} -mmmx -I${LOCALBASE}/include -I${X11BASE}/include ${PTHREAD_CFLAGS}" \
 		LIBS="-L${LOCALBASE}/lib -L${X11BASE}/lib ${PTHREAD_LIBS}"
 CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
 USE_LDCONFIG=	yes
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 700042 && ${ARCH} == i386
-BROKEN=		Does not compile with GCC 4.2 on i386
-.endif
-
 post-patch:
 	@${REINPLACE_CMD} -e 's|-Wno-unused-variable||g' \
 		-e 's|-O3|${CFLAGS}|g' \
 		${WRKSRC}/libvisual/Makefile.in
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Wed Oct 17 11:12:03 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117258 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/117258: commit references a PR
Date: Wed, 17 Oct 2007 11:12:00 +0000 (UTC)

 miwi        2007-10-17 11:11:54 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/libvisual   Makefile 
   Log:
   - Fix build with gcc 4.2
   - Unbreak
   
   PR:             117258
   Submitted by:   Dominic Fandrey <lon_kamikaze@gmx.de>
   
   Revision  Changes    Path
   1.13      +3 -10     ports/graphics/libvisual/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
