From nobody@FreeBSD.org  Sat Sep 29 18:47:06 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 988AF16A420
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2007 18:47:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7480513C469
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2007 18:47:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l8TIl6vr019058
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 29 Sep 2007 18:47:06 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l8TIl6ee019057;
	Sat, 29 Sep 2007 18:47:06 GMT
	(envelope-from nobody)
Message-Id: <200709291847.l8TIl6ee019057@www.freebsd.org>
Date: Sat, 29 Sep 2007 18:47:06 GMT
From: Scot Hetzel <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] x11-toolkits/gtk20: fails to build when print/cups-base (1.3*) is installed
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         116750
>Category:       ports
>Synopsis:       [patch] x11-toolkits/gtk20: fails to build when print/cups-base (1.3*) is installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 29 18:50:01 GMT 2007
>Closed-Date:    Sun Sep 30 22:43:09 GMT 2007
>Last-Modified:  Sun Sep 30 22:50:05 GMT 2007
>Originator:     Scot Hetzel
>Release:        7.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010.hetzel.org 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Wed Sep 26 01:11:17 CDT 2007     root@hp010.hetzel.org:/usr/src/amd64/compile/GENERIC.debug  amd64

>Description:
Since the upgrade of print/cups-base to 1.3, gtk20 will no longer build when cups-base is installed.

Found fix at:

http://bugzilla.gnome.org/show_bug.cgi?id=467414
>How-To-Repeat:
install cups-base or define WITH_CUPS when building x11-toolkits/gtk20

cd /usr/ports/x11-toolkits/gtk20
make build
:
 cc -DHAVE_CONFIG_H -I. -I. -I../../.. -I../../.. -I../../../gtk -I../../../gtk -I../../../gdk -I../../../gdk -I/usr/local/include -DGTK_PRINT_BACKEND_ENABLE_UNSUPPORTED -D_REENTRANT -D_THREAD_SAFE -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include/cairo -I/usr/local/include -I/usr/local/include/freetype2 -I/usr/local/include/atk-1.0 -DG_DISABLE_CAST_CHECKS -I/usr/local/include/freetype2 -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include -DG_DISABLE_DEPRECATED -O2 -fno-strict-aliasing -pipe -march=k8 -Wall -MT gtkcupsutils.lo -MD -MP -MF .deps/gtkcupsutils.Tpo -c gtkcupsutils.c  -fPIC -DPIC -o .libs/gtkcupsutils.o
gtkcupsutils.c: In function '_post_send':
gtkcupsutils.c:631: error: dereferencing pointer to incomplete type
gtkcupsutils.c: In function '_get_send':
gtkcupsutils.c:970: error: dereferencing pointer to incomplete type
gmake[4]: *** [gtkcupsutils.lo] Error 1
gmake[4]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules/printbackends/cups'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules/printbackends'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/x11-toolkits/gtk20/work/gtk+-2.10.14'
gmake: *** [all] Error 2
*** Error code 2

Stop in /usr/ports/x11-toolkits/gtk20.

>Fix:
add the attached file to the port.

NOTE: The attached patch will break the port for users of cups-base < 1.3 due to the use of httpGetAuthString.

Patch attached with submission follows:

--- modules/printbackends/cups/gtkcupsutils.c-orig	2007-09-29 13:01:34.226093342 -0500
+++ modules/printbackends/cups/gtkcupsutils.c	2007-09-29 13:04:59.458078750 -0500
@@ -628,7 +628,7 @@
   httpSetField(request->http, HTTP_FIELD_CONTENT_LENGTH, length);
   httpSetField(request->http, HTTP_FIELD_CONTENT_TYPE, "application/ipp");
 #ifdef HAVE_HTTP_AUTHSTRING
-  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, request->http->authstring);
+  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, httpGetAuthString (request->http));
 #endif
 
   if (httpPost(request->http, request->resource))
@@ -967,7 +967,7 @@
 
   httpClearFields(request->http);
 #ifdef HAVE_HTTP_AUTHSTRING
-  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, request->http->authstring);
+  httpSetField(request->http, HTTP_FIELD_AUTHORIZATION, httpGetAuthString (request->http));
 #endif
 
   if (httpGet(request->http, request->resource))


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 29 18:50:09 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116750 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sun Sep 30 22:42:55 UTC 2007 
State-Changed-Why:  
Bugzilla patch committed.  Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116750 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/116750: commit references a PR
Date: Sun, 30 Sep 2007 22:42:51 +0000 (UTC)

 marcus      2007-09-30 22:42:46 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-toolkits/gtk20   Makefile 
   Added files:
     x11-toolkits/gtk20/files 
                              patch-modules_printbackends_cups_gtkcupsutils.c 
   Log:
   Fix build and subsequent functionality of the CUPS printer backend
   in GTK+.
   
   PR:             116750
   Obtained from:  http://bugzilla.gnome.org/show_bug.cgi?id=467414
   
   Revision  Changes    Path
   1.203     +1 -1      ports/x11-toolkits/gtk20/Makefile
   1.1       +13 -0     ports/x11-toolkits/gtk20/files/patch-modules_printbackends_cups_gtkcupsutils.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
