From moonshade@pnhz.kz  Wed Sep 19 04:20:41 2007
Return-Path: <moonshade@pnhz.kz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B741C16A417
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Sep 2007 04:20:41 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from relay.pnhz.kz (relay.pnhz.kz [212.154.198.217])
	by mx1.freebsd.org (Postfix) with ESMTP id E38C813C461
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Sep 2007 04:20:40 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from abyss.pnhz.kz (Abyss.pnhz.kz [192.168.121.40])
	by relay.pnhz.kz with ESMTP id l8J49uvn089719
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 19 Sep 2007 10:10:19 +0600 (ALMT)
	(envelope-from moonshade@pnhz.kz)
Message-Id: <1190175018.28131@abyss.pnhz.kz>
Date: Wed, 19 Sep 2007 10:10:18 +0600
From: "Denis Eremenko <moonshade@pnhz.kz>" <moonshade@pnhz.kz>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: net/unison: should depend on X11-enabled ocaml when built WITH_GTK2
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify: daniel+unison@pelleg.org

>Number:         116454
>Category:       ports
>Synopsis:       net/unison: should depend on X11-enabled ocaml when built WITH_GTK2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    tabthorpe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 19 04:30:01 GMT 2007
>Closed-Date:    Thu Nov 29 03:55:20 UTC 2007
>Last-Modified:  Thu Nov 29 03:55:20 UTC 2007
>Originator:     Denis Eremenko <moonshade@pnhz.kz>
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:


System: FreeBSD 6.2-STABLE #0: Mon Sep 17 15:13:10 ALMT 2007
    root@abyss.pnhz.kz:/usr/obj/data/os/FreeBSD/src/6/src/sys/ABYSS-6



>Description:


net/unison depend on ocaml-nox11, but its BUILD_DEPEND, x11-toolkits/ocaml-lablgtk2, fails when net/unison built WITH_GTK2.



>How-To-Repeat:


cd /usr/port/net/unison && make WITH_GTK2=yes



>Fix:


--- Makefile-patch begins here ---
--- Makefile.orig	2007-09-19 09:49:28.000000000 +0600
+++ Makefile	2007-09-19 09:50:50.000000000 +0600
@@ -17,9 +17,6 @@
 MAINTAINER=	daniel+unison@pelleg.org
 COMMENT=	A user-level file synchronization tool
 
-BUILD_DEPENDS=	ocamlc:${PORTSDIR}/lang/ocaml-nox11
-PATCH_DEPENDS=	${BUILD_DEPENDS}
-
 PLIST_SUB=	PORTVERSION=${PORTVERSION}
 USE_GMAKE=	yes
 MAKE_ARGS=	CFLAGS=""
@@ -44,6 +41,8 @@
 .else
 MAKE_ARGS+=	UISTYLE=text
 PLIST_SUB+=	TEXT="@comment "
+BUILD_DEPENDS=	ocamlc:${PORTSDIR}/lang/ocaml-nox11
+PATCH_DEPENDS=	${BUILD_DEPENDS}
 .endif
 
 .if defined(WITH_GTK2)
--- Makefile-patch ends here ---



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Sep 19 04:30:11 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116454 

From: Dan Pelleg <daniel+unison@pelleg.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/116454: net/unison: should depend on X11-enabled ocaml when built WITH_GTK2
Date: Fri, 21 Sep 2007 16:21:20 +0200

 I think ocaml-nox11 should be noted as a conflict in the GTK2 case.
 
 I'm sitting on a patch for unison-2.27.12 that solve this issue (and
 others). I was waiting for it to be released, but that isn't
 happening. I'll submit it as a new port unison-devel, and we could then
 backport the fixes.
 
 -- 
   Dan

From: Dan Pelleg <daniel-unison@pelleg.org>
To: bug-followup@FreeBSD.org, moonshade@pnhz.kz
Cc:  
Subject: Re: ports/116454: net/unison: should depend on X11-enabled ocaml when built WITH_GTK2
Date: Fri, 28 Sep 2007 17:06:56 +0200

 I just submitted a PR for a unison-devel port here:
 http://www.freebsd.org/cgi/query-pr.cgi?pr=116713
 
 It contains the proposed fix, as well as some other minor tweaks. Once it's
 approved, I'll merge the changes to the stable unison port and send a PR.
 
 --
  Dan
Responsible-Changed-From-To: freebsd-ports-bugs->tabthorpe 
Responsible-Changed-By: tabthorpe 
Responsible-Changed-When: Wed Nov 28 19:55:12 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116454 
State-Changed-From-To: feedback->closed 
State-Changed-By: tabthorpe 
State-Changed-When: Thu Nov 29 03:55:18 UTC 2007 
State-Changed-Why:  
Maintainer provided newer patch, ports/117563 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116454 
>Unformatted:
