From shoemaker@bluebottle.com  Sat Sep 15 20:56:18 2007
Return-Path: <shoemaker@bluebottle.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 08E1216A419
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2007 20:56:18 +0000 (UTC)
	(envelope-from shoemaker@bluebottle.com)
Received: from mi0.bluebottle.com (mi0.bluebottle.com [206.188.25.15])
	by mx1.freebsd.org (Postfix) with ESMTP id CCFC513C48A
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2007 20:56:17 +0000 (UTC)
	(envelope-from shoemaker@bluebottle.com)
Received: from fe0.bluebottle.com (internal.bluebottle.com [206.188.24.43])
	by mi0.bluebottle.com (8.13.1/8.13.1) with ESMTP id l8FKuHu4002916
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2007 13:56:17 -0700
Received: from localhost.lan (host-69-144-73-208.msl-mt.client.bresnan.net [69.144.73.208])
	(authenticated bits=0)
	by fe0.bluebottle.com (8.13.1/8.13.1) with ESMTP id l8FKuFvf028275
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2007 13:56:17 -0700
Received: from localhost.lan (localhost [127.0.0.1])
	by localhost.lan (8.14.1/8.14.1) with ESMTP id l8FKuFnD096151
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2007 14:56:15 -0600 (MDT)
	(envelope-from shoemaker@bluebottle.com)
Received: (from js@localhost)
	by localhost.lan (8.14.1/8.13.8/Submit) id l8FKuEN2096148;
	Sat, 15 Sep 2007 14:56:14 -0600 (MDT)
	(envelope-from shoemaker@bluebottle.com)
Message-Id: <864phvodg1.fsf@localhost.lan>
Date: 15 Sep 2007 14:56:14 -0600
From: shoemaker@bluebottle.com (Jonathan Shoemaker)
Sender: js@localhost.lan
To: FreeBSD-gnats-submit@freebsd.org
Subject: [Maintainer Update]: fix arch-related issues
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         116379
>Category:       ports
>Synopsis:       [Maintainer Update]: games/crafty - fix arch-related issues
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 15 21:00:03 GMT 2007
>Closed-Date:    Sun Sep 23 03:44:47 GMT 2007
>Last-Modified:  Sun Sep 23 03:50:01 GMT 2007
>Originator:     Jonathan Shoemaker
>Release:        FreeBSD 6.2-RELEASE-p7 i386
>Organization:
>Environment:
System: FreeBSD localhost 6.2-RELEASE-p7 FreeBSD 6.2-RELEASE-p7 #0: Sat Sep 8 13:47:46 MDT 2007 root@localhost:/var/obj/usr/src/sys/CUSTOM i386

>Description:

	Received email stating "build fails on amd64 system with a
message about unsupported instructions. [...] Modifying patch-Makefile
so that -m486 / -mtune 486 option is removed fixed the problem for
me."  Updated Makefile to add PORTREVISION so that updates will be
seen by ports-tools, implemented arch suggestions for fixes, removing
most mention of architecture specific instructions.  Those will likely
be in make.conf, anyway, and if so will be passed along due to
inclusion.

>How-To-Repeat:
	Compile on amd64 (others as well, likely)
>Fix:
diff -ruN games/crafty/Makefile games/crafty/Makefile.orig
--- games/crafty/Makefile	Tue Sep 11 12:59:05 2007
+++ games/crafty/Makefile	Sat Sep 15 14:37:47 2007
@@ -7,6 +7,7 @@
 
 PORTNAME=	crafty
 PORTVERSION=	20.14
+PORTREVISION=	1
 CATEGORIES=	games
 MASTER_SITES=	ftp://ftp.cis.uab.edu/pub/hyatt/pgn/:data \
 		ftp://ftp.cis.uab.edu/pub/hyatt/documentation/:doc \
@@ -54,14 +55,6 @@
 
 .if ${ARCH} == "i386"
 OPT+=		-DINLINE32
-# XXX Someone with ASM knowledge would have to fix the Sparc.S
-.elif ${ARCH} == "sparc64"
-OPT+=		-DINLINE32
-CFLAGS+=	'$(CFLAGS) -D_REENTRANT -O3 -Wall \
-		-fomit-frame-pointer -funroll-all-loops \
-		-finline-functions -ffast-math' \
-.else
-OPT+=		-DFAST
 .endif
 
 MAKE_ENV+=	opt="${OPT}" target=${OPSYS} CXFLAGS="${CXXFLAGS}"
--- games/crafty/files/patch-Makefile.orig	Sun Sep  9 19:11:54 2007
+++ games/crafty/files/patch-Makefile	Sat Sep 15 14:39:45 2007
@@ -8,7 +8,7 @@
 -		CXFLAGS=$(CFLAGS) \
 -		LDFLAGS=$(LDFLAGS) \
 -		opt='$(opt) -DINLINE32' \
-+		CFLAGS+='-fomit-frame-pointer -mtune=i486 -O3 -Wall' \
++		CFLAGS+='-fomit-frame-pointer -Wall' \
 +		CXFLAGS+='$(CXXFLAGS)' \
 +		LDFLAGS='$(LDFLAGS) -lstdc++' \
 +		opt='$(opt)' \

----------------------------------------------------------------------
Free pop3 email with a spam filter.
http://www.bluebottle.com/tag/5

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: edwin 
State-Changed-When: Sun Sep 23 03:44:45 UTC 2007 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116379 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/116379: commit references a PR
Date: Sun, 23 Sep 2007 03:44:54 +0000 (UTC)

 edwin       2007-09-23 03:44:46 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/crafty         Makefile 
     games/crafty/files   patch-Makefile 
   Log:
   [Maintainer Update]: fix arch-related issues
   
           Received email stating "build fails on amd64 system with a
           message about unsupported instructions. [...] Modifying
           patch-Makefile so that -m486 / -mtune 486 option is removed
           fixed the problem for me." Updated Makefile to add PORTREVISION
           so that updates will be seen by ports-tools, implemented
           arch suggestions for fixes, removing most mention of
           architecture specific instructions. Those will likely be
           in make.conf, anyway, and if so will be passed along due
           to inclusion.
   
   PR:             ports/116379
   Submitted by:   shoemaker@bluebottle.com (Jonathan Shoemaker)
   
   Revision  Changes    Path
   1.35      +2 -9      ports/games/crafty/Makefile
   1.2       +1 -1      ports/games/crafty/files/patch-Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
