From root@rachie.is-a-geek.net  Sun Sep  9 19:14:20 2007
Return-Path: <root@rachie.is-a-geek.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F08A416A41A;
	Sun,  9 Sep 2007 19:14:20 +0000 (UTC)
	(envelope-from root@rachie.is-a-geek.net)
Received: from snoogles.rachie.is-a-geek.net (66-230-99-27-cdsl-rb1.nwc.acsalaska.net [66.230.99.27])
	by mx1.freebsd.org (Postfix) with ESMTP id B0B1913C428;
	Sun,  9 Sep 2007 19:14:20 +0000 (UTC)
	(envelope-from root@rachie.is-a-geek.net)
Received: by snoogles.rachie.is-a-geek.net (Postfix, from userid 0)
	id 895241CCD0; Sun,  9 Sep 2007 10:57:47 -0800 (AKDT)
Message-Id: <20070909185747.895241CCD0@snoogles.rachie.is-a-geek.net>
Date: Sun,  9 Sep 2007 10:57:47 -0800 (AKDT)
From: Mel <mel.xyzzy@rachie.is-a-geek.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: MAINTAINER	<gnome@FreeBSD.org>
Subject: [patch] Shoot yourself in the foot fix for firefox
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         116236
>Category:       ports
>Synopsis:       [patch] Shoot yourself in the foot fix for www/firefox
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 09 19:20:01 GMT 2007
>Closed-Date:    Thu Oct 02 22:41:09 UTC 2008
>Last-Modified:  Thu Oct 02 22:41:09 UTC 2008
>Originator:     Mel
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD snoogles.rachie.is-a-geek.net 6.2-STABLE FreeBSD 6.2-STABLE #0: Mon Mar 26 09:16:30 AKDT 2007 root@smoochies.rachie.is-a-geek.net:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
Ref: http://lists.freebsd.org/pipermail/freebsd-questions/2007-September/157558.html
As a side-note:
	Since Xorg 7.2, ports linking with libX11/libXpm pull in a horde of
	dependencies frequently for little functionality. Good example:
	php[45]-gd: xpm support is hardly used in the real world(tm).
	So people set WITHOUT_X11 in /etc/make.conf and forget about it.
	Also, flags set with portupgrade's -m option live throughout
	build of ports' dependencies.
>How-To-Repeat:
	Compile pango with WITHOUT_X11 somewhere defined. Then compile firefox.
>Fix:

Patch assumes WANT_GNOME verifies pango dependency but does not account for WITHOUT_X11 flag.

--- Makefile.orig	Sat Sep  8 02:46:36 2007
+++ Makefile	Sun Sep  9 10:40:41 2007
@@ -24,6 +24,9 @@
 MOZ_OPTIONS=	--program-transform-name='s/firefox/${MOZILLA}/'
 
 WANT_GNOME=	yes
+.if exists(${LOCALBASE}/libdata/pango.pc) && ! exists(${LOCALBASE}/libdata/pangox.pc)
+BROKEN=		This port requires pango built with X11 support. Recompile pango making sure WITHOUT_X11 is undefined.
+.endif
 ALL_TARGET=	default
 CONFIGURE_ENV=	LOCALBASE=${LOCALBASE}
 EXTRA_CFLAGS=	-O2

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Sep 9 22:13:39 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116236 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Thu Oct 2 22:38:02 UTC 2008 
State-Changed-Why:  
I do not agree with patch. We have too many ports depend on pango. Whomever 
have desktop and shouldn't be use WITHOUT_X11. It's kinda of common sense, 
unless you know what you are doing. 

Better solution is to make a request to its bugzilla to get its build more 
flexible to allow split. That way we can have pango and pango-nox11 or whatever 
what better name. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116236 
>Unformatted:
