From nobody@FreeBSD.org  Tue Sep  4 04:24:25 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C043516A41A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  4 Sep 2007 04:24:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B12A513C45B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  4 Sep 2007 04:24:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l844OPKx040104
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 4 Sep 2007 04:24:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l844OPK6040103;
	Tue, 4 Sep 2007 04:24:25 GMT
	(envelope-from nobody)
Message-Id: <200709040424.l844OPK6040103@www.freebsd.org>
Date: Tue, 4 Sep 2007 04:24:25 GMT
From: Tarragon Allen <tallen@realestate.com.au>
To: freebsd-gnats-submit@FreeBSD.org
Subject: snmp is missing PhysAddress
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         116069
>Category:       ports
>Synopsis:       net-mgmt/net-snmp: snmp is missing PhysAddress
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kuriyama
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 04 04:30:07 GMT 2007
>Closed-Date:    Sun Mar 30 08:11:30 UTC 2008
>Last-Modified:  Sun Mar 30 08:11:30 UTC 2008
>Originator:     Tarragon Allen
>Release:        6.2-RELEASE-p1
>Organization:
realestate.com.au
>Environment:
FreeBSD trea26.telstra.realestate.com.au 6.2-RELEASE-p1 FreeBSD 6.2-RELEASE-p1 #0: Fri Feb 23 16:13:11 EST 2007 joelc@rea30.realestate.com.au:/usr/src/sys/amd64/compile/SMP  amd64
>Description:
/usr/ports/net-mgmt/net-snmp 5.3.1_3 (and earlier) aren't returning the PhysAddress field when snmpwalked. It appears that an earlier patch was applied to fix this very problem with FreeBSD 3.x, 4.x and 5.x, but wasn't applied for 6.x.

http://www.freebsd.org/cgi/cvsweb.cgi/ports/net-mgmt/net-snmp/files/patch-interfaces.c?r1=1.4#rev1.4

I extended the check so that it covers FreeBSD 6.x as well and it now works as expected.
>How-To-Repeat:
Install net-snmp on a FreeBSD 6.2 system, and check the Physical Addresses with "snmpwalk -cpublic -v2c <hostname> Phys".
>Fix:

I made the following change to files/patch-interfaces.c:

@@ -55,7 +55,7 @@
 +            physaddrbuf = 0;
 +        }
 +        ifm = (struct if_msghdr *) rtm;
-+#if defined(freebsd3) || defined(freebsd4) || defined(freebsd5)
++#if defined(freebsd3) || defined(freebsd4) || defined(freebsd5) || defined(freebsd6)
 +        if (physaddrs != 0)
 +            physaddrs[naddrs] = (void *) (ifm + 1);
 +        naddrs++;
@@ -64,7 +64,7 @@
 +        cp += ifm->ifm_msglen;
 +        rtm = (struct rt_msghdr *) cp;
 +        while (ilen > 0 && rtm->rtm_type == RTM_NEWADDR) {
-+#if defined(freebsd3) || defined(freebsd4) || defined(freebsd5)
++#if defined(freebsd3) || defined(freebsd4) || defined(freebsd5) || defined(freebsd6)
 +            ilen -= rtm->rtm_msglen;
 +            cp += rtm->rtm_msglen;
 +#else


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports-bugs 
Responsible-Changed-By: remko 
Responsible-Changed-When: Tue Sep 4 04:38:05 UTC 2007 
Responsible-Changed-Why:  
reassign to ports team 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116069 
Responsible-Changed-From-To: freebsd-ports-bugs->kuriyama 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 8 14:00:31 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116069 

From: Jun Kuriyama <kuriyama@FreeBSD.org>
To: bug-followup@FreeBSD.org,tallen@realestate.com.au
Cc:  
Subject: Re: ports/116069: net-mgmt/net-snmp: snmp is missing PhysAddress
Date: Fri, 11 Jan 2008 22:06:26 +0900

 Hi,
 
 I checked your PR, but on my 6.2-RELEASE-p9 system, physaddress are
 returned as expected.
 
 And, in net-snmp source tree, we don't define freebsd6 (and 7, 8), so
 defined(freebsd6) check should be worked.
 
 
 -- 
 Jun Kuriyama <kuriyama@FreeBSD.org> // FreeBSD Project
State-Changed-From-To: open->closed 
State-Changed-By: kuriyama 
State-Changed-When: Sun Mar 30 08:11:18 UTC 2008 
State-Changed-Why:  
Feedback timeout. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116069 
>Unformatted:
