From nobody@FreeBSD.org  Mon Sep  3 17:44:14 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2255116A41A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  3 Sep 2007 17:44:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 130D913C459
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  3 Sep 2007 17:44:14 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l83HiD2N045343
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 3 Sep 2007 17:44:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l83HiDqd045342;
	Mon, 3 Sep 2007 17:44:13 GMT
	(envelope-from nobody)
Message-Id: <200709031744.l83HiDqd045342@www.freebsd.org>
Date: Mon, 3 Sep 2007 17:44:13 GMT
From: Dave Grochowski <malus.x@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Update: x11-themes/gtk-qt-engine to version 0.8
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: danny@ricin.com

>Number:         116058
>Category:       ports
>Synopsis:       Update: x11-themes/gtk-qt-engine to version 0.8
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 03 17:50:01 GMT 2007
>Closed-Date:    Mon Apr 28 11:38:09 UTC 2008
>Last-Modified:  Mon Apr 28 11:38:09 UTC 2008
>Originator:     Dave Grochowski
>Release:        FreeBSD 6.2
>Organization:
Lockheed Martin
>Environment:
FreeBSD berserker 6.2-STABLE FreeBSD 6.2-STABLE #25: Wed May 30 20:07:26 EDT 2007     root@berserker:/usr/obj/usr/src/sys/BERSERKER  i386
>Description:
Update gtk-qt-engine to version 0.8.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	gtk-qt-engine
#	gtk-qt-engine/Makefile
#	gtk-qt-engine/distinfo
#	gtk-qt-engine/pkg-descr
#	gtk-qt-engine/pkg-plist
#	gtk-qt-engine/files
#	gtk-qt-engine/files/patch-CMakeLists.txt
#
echo c - gtk-qt-engine
mkdir -p gtk-qt-engine > /dev/null 2>&1
echo x - gtk-qt-engine/Makefile
sed 's/^X//' >gtk-qt-engine/Makefile << 'END-of-gtk-qt-engine/Makefile'
X# New ports collection makefile for:    gtk-qt-engine
X# Date created:                         23 February 2004
X# Whom:                                 Danny Pansters <danny@ricin.com>
X#
X# $FreeBSD: ports/x11-themes/gtk-qt-engine/Makefile,v 1.26 2007/05/19 20:30:19 flz Exp $
X#
X
XPORTNAME=	gtk-qt-engine
XPORTVERSION=	0.8
XCATEGORIES=	x11-themes
XMASTER_SITES=	http://gtk-qt.ecs.soton.ac.uk/files/${PORTVERSION}/ \
X		http://freebsd.ricin.com/ports/distfiles/
X
XMAINTAINER=	danny@ricin.com
XCOMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
X
XBUILD_DEPENDS=	cmake:${PORTSDIR}/devel/cmake
X
XUSE_BZIP2=	yes
XUSE_GETTEXT=	yes
XUSE_GMAKE=	yes
XUSE_GNOME=	gtk20
XUSE_LDCONFIG=	yes
XUSE_QT_VER=	3
X
XCMAKE_ARGS=	-DCMAKE_INSTALL_PREFIX:PATH='${PREFIX}' \
X		-DCMAKE_C_COMPILER:STRING='${CC}' \
X		-DCMAKE_CXX_COMPILER:STRING=${CXX} \
X		-DCMAKE_C_FLAGS:STRING="${CFLAGS}" \
X		-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}"
X
XWRKSRC=		${WRKDIR}/${PORTNAME}
X
XOPTIONS=	LIBBONOBOUI "Install libbonoboui if missing" off
X
X.include <bsd.port.pre.mk>
X
X# Note: had to turn off libbonoboui (dependency) OPTION for technical reasons
X# So a "vanilla" package will have no libbonoboui support
X.if defined(WITH_LIBBONOBOUI)
XUSE_GNOME+=	libbonoboui
X.endif
X
Xpre-build:
X	@cd ${WRKSRC} && ${LOCALBASE}/bin/cmake ${CMAKE_ARGS} .
X
X.include <bsd.port.post.mk>
END-of-gtk-qt-engine/Makefile
echo x - gtk-qt-engine/distinfo
sed 's/^X//' >gtk-qt-engine/distinfo << 'END-of-gtk-qt-engine/distinfo'
XMD5 (gtk-qt-engine-0.8.tar.bz2) = 9fe75b7765b6a5b49901fcd6f4f4aa4b
XSHA256 (gtk-qt-engine-0.8.tar.bz2) = 6658bdbd3f2120d34f5c59b5bc3cfed5ef83a2aa8572d775483aa304396b0d45
XSIZE (gtk-qt-engine-0.8.tar.bz2) = 59472
END-of-gtk-qt-engine/distinfo
echo x - gtk-qt-engine/pkg-descr
sed 's/^X//' >gtk-qt-engine/pkg-descr << 'END-of-gtk-qt-engine/pkg-descr'
XGTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
Xso that they fit in more nicely with KDE. Includes a KDE
Xcontrol center module for GTK theme selection.
X
XWWW: http://gtk-qt.ecs.soton.ac.uk/index.php
X
XAuthor: David Sansome <me@davidsansome.com>
END-of-gtk-qt-engine/pkg-descr
echo x - gtk-qt-engine/pkg-plist
sed 's/^X//' >gtk-qt-engine/pkg-plist << 'END-of-gtk-qt-engine/pkg-plist'
Xlib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.so
Xlib/kde3/kcm_kcmgtk.la
Xlib/kde3/kcm_kcmgtk.so
Xshare/applications/kcmgtk.desktop
Xshare/locale/bg/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/de/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/es/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/fr/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/it/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/nn/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/ru/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/sv/LC_MESSAGES/gtkqtengine.mo
Xshare/locale/tr/LC_MESSAGES/gtkqtengine.mo
Xshare/themes/Qt/gtk-2.0/gtkrc
X@dirrm share/themes/Qt/gtk-2.0
X@dirrm share/themes/Qt
X@dirrm share/themes
X@dirrm share/applications
X@dirrm lib/kde3
X@dirrm lib/gtk-2.0/%%GTK2_VERSION%%/engines
X@dirrm lib/gtk-2.0/%%GTK2_VERSION%%
X@dirrm lib/gtk-2.0
END-of-gtk-qt-engine/pkg-plist
echo c - gtk-qt-engine/files
mkdir -p gtk-qt-engine/files > /dev/null 2>&1
echo x - gtk-qt-engine/files/patch-CMakeLists.txt
sed 's/^X//' >gtk-qt-engine/files/patch-CMakeLists.txt << 'END-of-gtk-qt-engine/files/patch-CMakeLists.txt'
X--- CMakeLists.txt.orig	Sun Sep  2 17:59:08 2007
X+++ CMakeLists.txt	Sun Sep  2 18:00:38 2007
X@@ -59,17 +59,17 @@
X 	${PKGCONFIG_EXECUTABLE}
X 	ARGS --variable=gtk_binary_version gtk+-2.0
X 	OUTPUT_VARIABLE GTK_VERSION)
X-SET(INSTALL_PATH_GTK_ENGINES "${GTK_LIB_DIR}/gtk-2.0/${GTK_VERSION}/engines" CACHE PATH "The directory in which to install the theme engine library (eg. /usr/lib/gtk-2.0/2.4.0/engines)")
X+SET(INSTALL_PATH_GTK_ENGINES "${CMAKE_INSTALL_PREFIX}/lib/gtk-2.0/${GTK_VERSION}/engines" CACHE PATH "The directory in which to install the theme engine library (eg. /usr/lib/gtk-2.0/2.4.0/engines)")
X MESSAGE(STATUS "Installing the GTK theme engine library to: ${INSTALL_PATH_GTK_ENGINES}")
X 
X EXEC_PROGRAM(
X 	${PKGCONFIG_EXECUTABLE}
X 	ARGS --variable=prefix gtk+-2.0
X 	OUTPUT_VARIABLE GTK_PREFIX)
X-SET(INSTALL_PATH_GTK_THEMES "${GTK_PREFIX}/share/themes" CACHE PATH "The directory in which to install the theme data (eg. /usr/share/themes)")
X+SET(INSTALL_PATH_GTK_THEMES "${CMAKE_INSTALL_PREFIX}/share/themes" CACHE PATH "The directory in which to install the theme data (eg. /usr/share/themes)")
X MESSAGE(STATUS "Installing the GTK theme engine data to: ${INSTALL_PATH_GTK_THEMES}")
X 
X-SET(INSTALL_PATH_KCONTROL_MODULES "${KDE3_LIB_DIR}" CACHE PATH "The directory in which to install KControl plugins (eg. /usr/lib)")
X+SET(INSTALL_PATH_KCONTROL_MODULES "${CMAKE_INSTALL_PREFIX}/lib" CACHE PATH "The directory in which to install KControl plugins (eg. /usr/lib)")
X MESSAGE(STATUS "Installing the KControl plugins to: ${INSTALL_PATH_KCONTROL_MODULES}")
X 
X MESSAGE(STATUS "Installing everything else to: ${CMAKE_INSTALL_PREFIX}")
END-of-gtk-qt-engine/files/patch-CMakeLists.txt
exit



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 3 17:50:16 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116058 

From: Danny Pansters <danny@ricin.com>
To: bug-followup@freebsd.org,
 malus.x@gmail.com
Cc:  
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Tue, 4 Sep 2007 02:16:57 +0200

 --Boundary-00=_6PK3G9LDhbo44LE
 Content-Type: text/plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Edwin or other: please use attached diff for commit. It's reasonably well 
 tested. I'll take any fallout (as usual)
 
 
 Hi Dave,
 
 Thanks for the PR. I wasn't aware of a gtk-qt-engine update yet. Also quite 
 new to cmake. Please note that generally for existing ports diffs are used, 
 and shars for new ports (though if you need to add a dir shar or tar are much 
 easier to use).
 
 I've used your PR but reworked/changed it for a few things:
 
 - having GTK_LIB_DIR etc also be passed as CMAKE_ARGS (based in LOCALBASE, I 
 reckon that for this that's better tha PREFIX but this may be debatable), 
 that way we don't need a patch or a files/ directory at all. Another 
 possiblity is to use REINPLACE_CMD (sed) for these things, pre-configure.
 
 - re-add lib dependency on kdecore. The kcm module build really requires 
 kdecore. And I think also for running.
 
 - I like the CMAKE_ARGS way of passing CXX and friends that you used, kept 
 that in, also used a CMAKE variable for the cmake path, which I expect a new 
 bsd.cmake.mk to so in the near future (as well as probably providing a 
 canned-in way to add common cmake args).
 
 - I noticed you using the pre-build target, while you probably wanted to 
 override the do-configure target. To do that you use do-configure and set 
 HAS_CONFIGURE=yes. Well, that's what I did at least :)
 
 I tested on tinderbuild/STABLE and also tested building with gcc42, and 
 limited runtime testing (that is: look at abiword's GUI)
 
 Thanks!
 
 Dan
 
 --Boundary-00=_6PK3G9LDhbo44LE
 Content-Type: text/x-diff;
   charset="us-ascii";
   name="x11-themes__gtk-qt-engine.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="x11-themes__gtk-qt-engine.diff"
 
 diff -ruN x11-themes/gtk-qt-engine.new/Makefile x11-themes/gtk-qt-engine/Makefile
 --- x11-themes/gtk-qt-engine.new/Makefile	2007-09-04 01:57:01.000000000 +0200
 +++ x11-themes/gtk-qt-engine/Makefile	2007-05-19 22:30:19.000000000 +0200
 @@ -6,46 +6,50 @@
  #
  
  PORTNAME=	gtk-qt-engine
 -PORTVERSION=	0.8
 -PORTREVISION=	# zero
 +PORTVERSION=	0.7
 +PORTREVISION=	6
  CATEGORIES=	x11-themes
  MASTER_SITES=	http://gtk-qt.ecs.soton.ac.uk/files/${PORTVERSION}/ \
  		http://freebsd.ricin.com/ports/distfiles/
  
  MAINTAINER=	danny@ricin.com
 -COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
 +COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
  
  LIB_DEPENDS=	kdecore:${PORTSDIR}/x11/kdelibs3
 -BUILD_DEPENDS=	cmake:${PORTSDIR}/devel/cmake
  
  USE_BZIP2=	yes
 -USE_GETTEXT=	yes
  USE_GMAKE=	yes
 +USE_AUTOTOOLS=	libtool:15
  USE_GNOME=	gtk20
 -USE_LDCONFIG=	yes
  USE_QT_VER=	3
 -HAS_CONFIGURE=	yes
 -
 -OPTIONS=	LIBBONOBOUI "Install libbonoboui if missing" off
  
  WRKSRC=		${WRKDIR}/${PORTNAME}
 -CMAKE=		${LOCALBASE}/bin/cmake
 -CMAKE_ARGS=	-DCMAKE_INSTALL_PREFIX:PATH="${PREFIX}"\
 -		-DCMAKE_C_COMPILER:STRING="${CC}" \
 -		-DCMAKE_CXX_COMPILER:STRING="${CXX}" \
 -		-DCMAKE_C_FLAGS:STRING="${CFLAGS}"\
 -		-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}"\
 -		-DGTK_LIB_DIR:PATH="${LOCALBASE}"\
 -		-DGTK_PREFIX:PATH="${LOCALBASE}"\
 -		-DKDE3_LIB_DIR:PATH="${LOCALBASE}"
 +
 +CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include
 +
 +OPTIONS=	LIBBONOBOUI "Install libbonoboui if missing" off
  
  .include <bsd.port.pre.mk>
  
 +# Note: had to turn off libbonoboui (dependency) OPTION for technical reasons
 +# So a "vanilla" package will have no libbonoboui support
  .if defined(WITH_LIBBONOBOUI)
  USE_GNOME+=	libbonoboui
  .endif
  
 -do-configure:
 -	cd ${WRKSRC} && ${CMAKE} ${CMAKE_ARGS} .
 +post-patch:
 +	@${REINPLACE_CMD} -e "s|GTK_LIBPREFIX)/gtk|PREFIX)/lib/gtk|" \
 +		${WRKSRC}/src/Makefile.in
 +	@${REINPLACE_CMD} -e "s|GTK_PREFIX)/share|PREFIX)/share|g" \
 +		${WRKSRC}/src/Makefile.in
 +	@${REINPLACE_CMD} -e "s|/usr/lib/menu|${WRKDIR}/menu|g" \
 +		${WRKSRC}/kcm_gtk/Makefile.in
 +	@${REINPLACE_CMD} -e \
 +		"s|/usr/share/applications|${PREFIX}/share/applications/kde|g" \
 +		${WRKSRC}/kcm_gtk/Makefile.in
 +
 +post-install:
 +	@${RM} -r ${WRKDIR}/menu
 +	@${RM} ${PREFIX}/share/applnk/Settings/LookNFeel/kcmgtk.desktop
  
  .include <bsd.port.post.mk>
 diff -ruN x11-themes/gtk-qt-engine.new/distinfo x11-themes/gtk-qt-engine/distinfo
 --- x11-themes/gtk-qt-engine.new/distinfo	2007-09-03 23:29:23.000000000 +0200
 +++ x11-themes/gtk-qt-engine/distinfo	2006-08-05 00:44:33.000000000 +0200
 @@ -1,3 +1,3 @@
 -MD5 (gtk-qt-engine-0.8.tar.bz2) = 9fe75b7765b6a5b49901fcd6f4f4aa4b
 -SHA256 (gtk-qt-engine-0.8.tar.bz2) = 6658bdbd3f2120d34f5c59b5bc3cfed5ef83a2aa8572d775483aa304396b0d45
 -SIZE (gtk-qt-engine-0.8.tar.bz2) = 59472
 +MD5 (gtk-qt-engine-0.7.tar.bz2) = 27ca211621f38c45b1c4c9e9ef1f84b0
 +SHA256 (gtk-qt-engine-0.7.tar.bz2) = cfaac46c409984afbcf46979f728515535725e8c83bdf70277f23dde068daaee
 +SIZE (gtk-qt-engine-0.7.tar.bz2) = 439794
 diff -ruN x11-themes/gtk-qt-engine.new/pkg-descr x11-themes/gtk-qt-engine/pkg-descr
 --- x11-themes/gtk-qt-engine.new/pkg-descr	2007-09-04 00:16:07.000000000 +0200
 +++ x11-themes/gtk-qt-engine/pkg-descr	2007-02-08 23:31:56.000000000 +0100
 @@ -1,4 +1,4 @@
 -GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
 +GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
  so that they fit in more nicely with KDE. Includes a KDE
  control center module for GTK theme selection.
  
 diff -ruN x11-themes/gtk-qt-engine.new/pkg-plist x11-themes/gtk-qt-engine/pkg-plist
 --- x11-themes/gtk-qt-engine.new/pkg-plist	2007-09-03 23:41:48.000000000 +0200
 +++ x11-themes/gtk-qt-engine/pkg-plist	2007-05-19 22:30:19.000000000 +0200
 @@ -1,22 +1,16 @@
 +lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.a
 +lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.la
  lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.so
 +lib/kde3/kcm_kcmgtk.a
  lib/kde3/kcm_kcmgtk.la
  lib/kde3/kcm_kcmgtk.so
 -share/applications/kcmgtk.desktop
 -share/locale/bg/LC_MESSAGES/gtkqtengine.mo
 +share/gtk-qt-engine/kde-index.theme
 +share/applications/kde/kcmgtk-xdg.desktop
  share/locale/de/LC_MESSAGES/gtkqtengine.mo
  share/locale/es/LC_MESSAGES/gtkqtengine.mo
  share/locale/fr/LC_MESSAGES/gtkqtengine.mo
 -share/locale/it/LC_MESSAGES/gtkqtengine.mo
  share/locale/nn/LC_MESSAGES/gtkqtengine.mo
 -share/locale/ru/LC_MESSAGES/gtkqtengine.mo
 -share/locale/sv/LC_MESSAGES/gtkqtengine.mo
 -share/locale/tr/LC_MESSAGES/gtkqtengine.mo
  share/themes/Qt/gtk-2.0/gtkrc
  @dirrm share/themes/Qt/gtk-2.0
  @dirrm share/themes/Qt
 -@dirrmtry share/themes
 -@dirrmtry share/applications
 -@dirrmtry lib/kde3
 -@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%/engines
 -@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%
 -@dirrmtry lib/gtk-2.0
 +@dirrm share/gtk-qt-engine
 
 --Boundary-00=_6PK3G9LDhbo44LE--

From: Danny Pansters <danny@ricin.com>
To: bug-followup@freebsd.org,
 malus.x@gmail.com
Cc:  
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Tue, 4 Sep 2007 02:37:58 +0200

 --Boundary-00=_mjK3GZlU6mXbqzd
 Content-Type: text/plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Arghh, reversed patch used. Sorry. Attached diff will probably work better :)
 
 Whoops!
 
 Dan
 
 --Boundary-00=_mjK3GZlU6mXbqzd
 Content-Type: text/x-diff;
   charset="us-ascii";
   name="x11-themes__gtk-qt-engine.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="x11-themes__gtk-qt-engine.diff"
 
 diff -ruN x11-themes/gtk-qt-engine/Makefile x11-themes/gtk-qt-engine.new/Makefile
 --- x11-themes/gtk-qt-engine/Makefile	2007-05-19 22:30:19.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/Makefile	2007-09-04 01:57:01.000000000 +0200
 @@ -6,50 +6,46 @@
  #
  
  PORTNAME=	gtk-qt-engine
 -PORTVERSION=	0.7
 -PORTREVISION=	6
 +PORTVERSION=	0.8
 +PORTREVISION=	# zero
  CATEGORIES=	x11-themes
  MASTER_SITES=	http://gtk-qt.ecs.soton.ac.uk/files/${PORTVERSION}/ \
  		http://freebsd.ricin.com/ports/distfiles/
  
  MAINTAINER=	danny@ricin.com
 -COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
 +COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
  
  LIB_DEPENDS=	kdecore:${PORTSDIR}/x11/kdelibs3
 +BUILD_DEPENDS=	cmake:${PORTSDIR}/devel/cmake
  
  USE_BZIP2=	yes
 +USE_GETTEXT=	yes
  USE_GMAKE=	yes
 -USE_AUTOTOOLS=	libtool:15
  USE_GNOME=	gtk20
 +USE_LDCONFIG=	yes
  USE_QT_VER=	3
 -
 -WRKSRC=		${WRKDIR}/${PORTNAME}
 -
 -CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include
 +HAS_CONFIGURE=	yes
  
  OPTIONS=	LIBBONOBOUI "Install libbonoboui if missing" off
  
 +WRKSRC=		${WRKDIR}/${PORTNAME}
 +CMAKE=		${LOCALBASE}/bin/cmake
 +CMAKE_ARGS=	-DCMAKE_INSTALL_PREFIX:PATH="${PREFIX}"\
 +		-DCMAKE_C_COMPILER:STRING="${CC}" \
 +		-DCMAKE_CXX_COMPILER:STRING="${CXX}" \
 +		-DCMAKE_C_FLAGS:STRING="${CFLAGS}"\
 +		-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}"\
 +		-DGTK_LIB_DIR:PATH="${LOCALBASE}"\
 +		-DGTK_PREFIX:PATH="${LOCALBASE}"\
 +		-DKDE3_LIB_DIR:PATH="${LOCALBASE}"
 +
  .include <bsd.port.pre.mk>
  
 -# Note: had to turn off libbonoboui (dependency) OPTION for technical reasons
 -# So a "vanilla" package will have no libbonoboui support
  .if defined(WITH_LIBBONOBOUI)
  USE_GNOME+=	libbonoboui
  .endif
  
 -post-patch:
 -	@${REINPLACE_CMD} -e "s|GTK_LIBPREFIX)/gtk|PREFIX)/lib/gtk|" \
 -		${WRKSRC}/src/Makefile.in
 -	@${REINPLACE_CMD} -e "s|GTK_PREFIX)/share|PREFIX)/share|g" \
 -		${WRKSRC}/src/Makefile.in
 -	@${REINPLACE_CMD} -e "s|/usr/lib/menu|${WRKDIR}/menu|g" \
 -		${WRKSRC}/kcm_gtk/Makefile.in
 -	@${REINPLACE_CMD} -e \
 -		"s|/usr/share/applications|${PREFIX}/share/applications/kde|g" \
 -		${WRKSRC}/kcm_gtk/Makefile.in
 -
 -post-install:
 -	@${RM} -r ${WRKDIR}/menu
 -	@${RM} ${PREFIX}/share/applnk/Settings/LookNFeel/kcmgtk.desktop
 +do-configure:
 +	cd ${WRKSRC} && ${CMAKE} ${CMAKE_ARGS} .
  
  .include <bsd.port.post.mk>
 diff -ruN x11-themes/gtk-qt-engine/distinfo x11-themes/gtk-qt-engine.new/distinfo
 --- x11-themes/gtk-qt-engine/distinfo	2006-08-05 00:44:33.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/distinfo	2007-09-03 23:29:23.000000000 +0200
 @@ -1,3 +1,3 @@
 -MD5 (gtk-qt-engine-0.7.tar.bz2) = 27ca211621f38c45b1c4c9e9ef1f84b0
 -SHA256 (gtk-qt-engine-0.7.tar.bz2) = cfaac46c409984afbcf46979f728515535725e8c83bdf70277f23dde068daaee
 -SIZE (gtk-qt-engine-0.7.tar.bz2) = 439794
 +MD5 (gtk-qt-engine-0.8.tar.bz2) = 9fe75b7765b6a5b49901fcd6f4f4aa4b
 +SHA256 (gtk-qt-engine-0.8.tar.bz2) = 6658bdbd3f2120d34f5c59b5bc3cfed5ef83a2aa8572d775483aa304396b0d45
 +SIZE (gtk-qt-engine-0.8.tar.bz2) = 59472
 diff -ruN x11-themes/gtk-qt-engine/pkg-descr x11-themes/gtk-qt-engine.new/pkg-descr
 --- x11-themes/gtk-qt-engine/pkg-descr	2007-02-08 23:31:56.000000000 +0100
 +++ x11-themes/gtk-qt-engine.new/pkg-descr	2007-09-04 00:16:07.000000000 +0200
 @@ -1,4 +1,4 @@
 -GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
 +GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
  so that they fit in more nicely with KDE. Includes a KDE
  control center module for GTK theme selection.
  
 diff -ruN x11-themes/gtk-qt-engine/pkg-plist x11-themes/gtk-qt-engine.new/pkg-plist
 --- x11-themes/gtk-qt-engine/pkg-plist	2007-05-19 22:30:19.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/pkg-plist	2007-09-03 23:41:48.000000000 +0200
 @@ -1,16 +1,22 @@
 -lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.a
 -lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.la
  lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.so
 -lib/kde3/kcm_kcmgtk.a
  lib/kde3/kcm_kcmgtk.la
  lib/kde3/kcm_kcmgtk.so
 -share/gtk-qt-engine/kde-index.theme
 -share/applications/kde/kcmgtk-xdg.desktop
 +share/applications/kcmgtk.desktop
 +share/locale/bg/LC_MESSAGES/gtkqtengine.mo
  share/locale/de/LC_MESSAGES/gtkqtengine.mo
  share/locale/es/LC_MESSAGES/gtkqtengine.mo
  share/locale/fr/LC_MESSAGES/gtkqtengine.mo
 +share/locale/it/LC_MESSAGES/gtkqtengine.mo
  share/locale/nn/LC_MESSAGES/gtkqtengine.mo
 +share/locale/ru/LC_MESSAGES/gtkqtengine.mo
 +share/locale/sv/LC_MESSAGES/gtkqtengine.mo
 +share/locale/tr/LC_MESSAGES/gtkqtengine.mo
  share/themes/Qt/gtk-2.0/gtkrc
  @dirrm share/themes/Qt/gtk-2.0
  @dirrm share/themes/Qt
 -@dirrm share/gtk-qt-engine
 +@dirrmtry share/themes
 +@dirrmtry share/applications
 +@dirrmtry lib/kde3
 +@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%/engines
 +@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%
 +@dirrmtry lib/gtk-2.0
 
 --Boundary-00=_mjK3GZlU6mXbqzd--

From: Dave Grochowski <malus.x@gmail.com>
To: Danny Pansters <danny@ricin.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Mon, 03 Sep 2007 22:18:22 -0400

 Hey,
 
 Danny Pansters wrote:
 > Edwin or other: please use attached diff for commit. It's reasonably well 
 > tested. I'll take any fallout (as usual)
 >
 >
 > Hi Dave,
 >
 > Thanks for the PR. I wasn't aware of a gtk-qt-engine update yet. Also quite 
 > new to cmake. Please note that generally for existing ports diffs are used, 
 > and shars for new ports (though if you need to add a dir shar or tar are much 
 > easier to use).
 >   
 
 Yeah, the thought crossed my mind, but for some reason I went with a 
 shar anyway. Sorry about that.
 
 > I've used your PR but reworked/changed it for a few things:
 >
 > - having GTK_LIB_DIR etc also be passed as CMAKE_ARGS (based in LOCALBASE, I 
 > reckon that for this that's better tha PREFIX but this may be debatable), 
 > that way we don't need a patch or a files/ directory at all. Another 
 > possiblity is to use REINPLACE_CMD (sed) for these things, pre-configure.
 >   
 
 Ok, that makes more sense.  However, there are some issues with that:
 
 1. GTK_LIB_DIR should be set to "${LOCALBASE}/lib".
 
 2. Similarly, KDE3_LIB_DIR should be set to "${LOCALBASE}/lib".
 
 3. You cannot pass in GTK_PREFIX, GTK_LIB_DIR, and KDE3_LIB_DIR like 
 that. The values for those are actually pulled from pkg-config. Any 
 parameters passed in will be overwritten anyway when the calls to 
 pkg-config are made.
 
 Does it make more sense to pass in the values for those or just use 
 pkg-config to figure them out? The former will require a little more 
 work to achieve, either with some sed magic or a patch.
 
 > - re-add lib dependency on kdecore. The kcm module build really requires 
 > kdecore. And I think also for running.
 >   
 
 Whoops, that was an accident.
 
 > - I like the CMAKE_ARGS way of passing CXX and friends that you used, kept 
 > that in, also used a CMAKE variable for the cmake path, which I expect a new 
 > bsd.cmake.mk to so in the near future (as well as probably providing a 
 > canned-in way to add common cmake args).
 >   
 
 I was going to suggest making it:
 
 CMAKE?=          ${LOCALBASE}/bin/cmake
 
 However, I suppose the Makefile will be edited anyway after the 
 introduction of bsd.cmake.mk, so the point is irrelevant.
 
 > - I noticed you using the pre-build target, while you probably wanted to 
 > override the do-configure target. To do that you use do-configure and set 
 > HAS_CONFIGURE=yes. Well, that's what I did at least :)
 >   
 
 Ok, makes more sense.
 
 > I tested on tinderbuild/STABLE and also tested building with gcc42, and 
 > limited runtime testing (that is: look at abiword's GUI)
 >
 > Thanks!
 >
 > Dan
 >   
 
 Well, your update to the port works fine for me as well.
 
 Sincerely,
 Dave Grochowski

From: Danny Pansters <danny@ricin.com>
To: Dave Grochowski <malus.x@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Wed, 5 Sep 2007 01:24:57 +0200

 --Boundary-00=_Jle3GqCXklqw7ev
 Content-Type: text/plain;
   charset="iso-8859-1"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 <snip>
 > 1. GTK_LIB_DIR should be set to "${LOCALBASE}/lib".
 >
 > 2. Similarly, KDE3_LIB_DIR should be set to "${LOCALBASE}/lib".
 >
 > 3. You cannot pass in GTK_PREFIX, GTK_LIB_DIR, and KDE3_LIB_DIR like
 > that. The values for those are actually pulled from pkg-config. Any
 > parameters passed in will be overwritten anyway when the calls to
 > pkg-config are made.
 
 Ooow, ok. Yes you're right. Hehe.
 
 > Does it make more sense to pass in the values for those or just use
 > pkg-config to figure them out? The former will require a little more
 > work to achieve, either with some sed magic or a patch.
 
 I don't know much about pkg-config (gnome stuff ;-), but I think that 
 considering that the package will only work if installed in the right place, 
 this is the kind of package where it's better to not pretend. It *must* be in 
 the gtk theme dir, it *must* be in the kcm dir. PREFIX is useful for packages 
 that are pretty much self hosted, here it's probably better to not use it at 
 all. If a user would want a large body of software (kde,gnome) working 
 together installed in a non standard place they would/should change LOCALBASE 
 or maybe DESTDIR.
 
 Besides, since pkg-config seems to do the right thing, I don't see a reason 
 not to just use what it comes up with unless it breaks something. They 
 probably thought harder about it than I did.
 
 > > - re-add lib dependency on kdecore. The kcm module build really requires
 > > kdecore. And I think also for running.
 >
 > Whoops, that was an accident.
 
 Wonder why I never used USE_KDEBASE_VER there, well, let's do it now!
 
 > > - I like the CMAKE_ARGS way of passing CXX and friends that you used,
 > > kept that in, also used a CMAKE variable for the cmake path, which I
 > > expect a new bsd.cmake.mk to so in the near future (as well as probably
 > > providing a canned-in way to add common cmake args).
 >
 > I was going to suggest making it:
 >
 > CMAKE?=          ${LOCALBASE}/bin/cmake
 
 Yes, that's better.
 
 > However, I suppose the Makefile will be edited anyway after the
 > introduction of bsd.cmake.mk, so the point is irrelevant.
 
 Well, I'm not saying there will be one, rather that I think eventually there 
 will be one (with kde4 and all).
 
 > > - I noticed you using the pre-build target, while you probably wanted to
 > > override the do-configure target. To do that you use do-configure and set
 > > HAS_CONFIGURE=yes. Well, that's what I did at least :)
 >
 > Ok, makes more sense.
 >
 > > I tested on tinderbuild/STABLE and also tested building with gcc42, and
 > > limited runtime testing (that is: look at abiword's GUI)
 > >
 > > Thanks!
 > >
 > > Dan
 >
 > Well, your update to the port works fine for me as well.
 >
 > Sincerely,
 > Dave Grochowski
 
 Attached is a reworked and simplified version (e.g. rely on pkg-config since 
 it seems to be doing its job alright) of the port, now also using 
 USE_KDEBASE_VER as should.
 
 Thanks,
 
 Dan
 
 --Boundary-00=_Jle3GqCXklqw7ev
 Content-Type: text/x-diff;
   charset="iso-8859-1";
   name="x11-themes__gtk-qt-engine.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="x11-themes__gtk-qt-engine.diff"
 
 diff -ruN x11-themes/gtk-qt-engine/Makefile x11-themes/gtk-qt-engine.new/Makefile
 --- x11-themes/gtk-qt-engine/Makefile	2007-05-19 22:30:19.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/Makefile	2007-09-05 00:53:41.000000000 +0200
 @@ -6,50 +6,41 @@
  #
  
  PORTNAME=	gtk-qt-engine
 -PORTVERSION=	0.7
 -PORTREVISION=	6
 +PORTVERSION=	0.8
 +PORTREVISION=	# zero
  CATEGORIES=	x11-themes
  MASTER_SITES=	http://gtk-qt.ecs.soton.ac.uk/files/${PORTVERSION}/ \
  		http://freebsd.ricin.com/ports/distfiles/
  
  MAINTAINER=	danny@ricin.com
 -COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
 +COMMENT=	GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
  
 -LIB_DEPENDS=	kdecore:${PORTSDIR}/x11/kdelibs3
 +BUILD_DEPENDS=	cmake:${PORTSDIR}/devel/cmake
  
  USE_BZIP2=	yes
 +USE_GETTEXT=	yes
  USE_GMAKE=	yes
 -USE_AUTOTOOLS=	libtool:15
  USE_GNOME=	gtk20
  USE_QT_VER=	3
 -
 -WRKSRC=		${WRKDIR}/${PORTNAME}
 -
 -CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include
 +USE_KDEBASE_VER=3
 +HAS_CONFIGURE=	yes
  
  OPTIONS=	LIBBONOBOUI "Install libbonoboui if missing" off
  
 +WRKSRC=		${WRKDIR}/${PORTNAME}
 +CMAKE?=		${LOCALBASE}/bin/cmake
 +CMAKE_ARGS=	-DCMAKE_C_COMPILER:STRING="${CC}"\
 +		-DCMAKE_CXX_COMPILER:STRING="${CXX}"\
 +		-DCMAKE_C_FLAGS:STRING="${CFLAGS}"\
 +		-DCMAKE_CXX_FLAGS:STRING="${CXXFLAGS}"
 +
  .include <bsd.port.pre.mk>
  
 -# Note: had to turn off libbonoboui (dependency) OPTION for technical reasons
 -# So a "vanilla" package will have no libbonoboui support
  .if defined(WITH_LIBBONOBOUI)
  USE_GNOME+=	libbonoboui
  .endif
  
 -post-patch:
 -	@${REINPLACE_CMD} -e "s|GTK_LIBPREFIX)/gtk|PREFIX)/lib/gtk|" \
 -		${WRKSRC}/src/Makefile.in
 -	@${REINPLACE_CMD} -e "s|GTK_PREFIX)/share|PREFIX)/share|g" \
 -		${WRKSRC}/src/Makefile.in
 -	@${REINPLACE_CMD} -e "s|/usr/lib/menu|${WRKDIR}/menu|g" \
 -		${WRKSRC}/kcm_gtk/Makefile.in
 -	@${REINPLACE_CMD} -e \
 -		"s|/usr/share/applications|${PREFIX}/share/applications/kde|g" \
 -		${WRKSRC}/kcm_gtk/Makefile.in
 -
 -post-install:
 -	@${RM} -r ${WRKDIR}/menu
 -	@${RM} ${PREFIX}/share/applnk/Settings/LookNFeel/kcmgtk.desktop
 +do-configure:
 +	cd ${WRKSRC} && ${CMAKE} ${CMAKE_ARGS} .
  
  .include <bsd.port.post.mk>
 diff -ruN x11-themes/gtk-qt-engine/distinfo x11-themes/gtk-qt-engine.new/distinfo
 --- x11-themes/gtk-qt-engine/distinfo	2006-08-05 00:44:33.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/distinfo	2007-09-03 23:29:23.000000000 +0200
 @@ -1,3 +1,3 @@
 -MD5 (gtk-qt-engine-0.7.tar.bz2) = 27ca211621f38c45b1c4c9e9ef1f84b0
 -SHA256 (gtk-qt-engine-0.7.tar.bz2) = cfaac46c409984afbcf46979f728515535725e8c83bdf70277f23dde068daaee
 -SIZE (gtk-qt-engine-0.7.tar.bz2) = 439794
 +MD5 (gtk-qt-engine-0.8.tar.bz2) = 9fe75b7765b6a5b49901fcd6f4f4aa4b
 +SHA256 (gtk-qt-engine-0.8.tar.bz2) = 6658bdbd3f2120d34f5c59b5bc3cfed5ef83a2aa8572d775483aa304396b0d45
 +SIZE (gtk-qt-engine-0.8.tar.bz2) = 59472
 diff -ruN x11-themes/gtk-qt-engine/pkg-descr x11-themes/gtk-qt-engine.new/pkg-descr
 --- x11-themes/gtk-qt-engine/pkg-descr	2007-02-08 23:31:56.000000000 +0100
 +++ x11-themes/gtk-qt-engine.new/pkg-descr	2007-09-04 00:16:07.000000000 +0200
 @@ -1,4 +1,4 @@
 -GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
 +GTK-QT Theme Engine allows GTK2 apps to use QT/KDE themes
  so that they fit in more nicely with KDE. Includes a KDE
  control center module for GTK theme selection.
  
 diff -ruN x11-themes/gtk-qt-engine/pkg-plist x11-themes/gtk-qt-engine.new/pkg-plist
 --- x11-themes/gtk-qt-engine/pkg-plist	2007-05-19 22:30:19.000000000 +0200
 +++ x11-themes/gtk-qt-engine.new/pkg-plist	2007-09-03 23:41:48.000000000 +0200
 @@ -1,16 +1,22 @@
 -lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.a
 -lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.la
  lib/gtk-2.0/%%GTK2_VERSION%%/engines/libqtengine.so
 -lib/kde3/kcm_kcmgtk.a
  lib/kde3/kcm_kcmgtk.la
  lib/kde3/kcm_kcmgtk.so
 -share/gtk-qt-engine/kde-index.theme
 -share/applications/kde/kcmgtk-xdg.desktop
 +share/applications/kcmgtk.desktop
 +share/locale/bg/LC_MESSAGES/gtkqtengine.mo
  share/locale/de/LC_MESSAGES/gtkqtengine.mo
  share/locale/es/LC_MESSAGES/gtkqtengine.mo
  share/locale/fr/LC_MESSAGES/gtkqtengine.mo
 +share/locale/it/LC_MESSAGES/gtkqtengine.mo
  share/locale/nn/LC_MESSAGES/gtkqtengine.mo
 +share/locale/ru/LC_MESSAGES/gtkqtengine.mo
 +share/locale/sv/LC_MESSAGES/gtkqtengine.mo
 +share/locale/tr/LC_MESSAGES/gtkqtengine.mo
  share/themes/Qt/gtk-2.0/gtkrc
  @dirrm share/themes/Qt/gtk-2.0
  @dirrm share/themes/Qt
 -@dirrm share/gtk-qt-engine
 +@dirrmtry share/themes
 +@dirrmtry share/applications
 +@dirrmtry lib/kde3
 +@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%/engines
 +@dirrmtry lib/gtk-2.0/%%GTK2_VERSION%%
 +@dirrmtry lib/gtk-2.0
 
 --Boundary-00=_Jle3GqCXklqw7ev--

From: Dave Grochowski <malus.x@gmail.com>
To: Danny Pansters <danny@ricin.com>
Cc: bug-followup@freebsd.org
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Tue, 04 Sep 2007 20:25:35 -0400

 Hey,
 
 Danny Pansters wrote:
 > <snip>
 >   
 >> 1. GTK_LIB_DIR should be set to "${LOCALBASE}/lib".
 >>
 >> 2. Similarly, KDE3_LIB_DIR should be set to "${LOCALBASE}/lib".
 >>
 >> 3. You cannot pass in GTK_PREFIX, GTK_LIB_DIR, and KDE3_LIB_DIR like
 >> that. The values for those are actually pulled from pkg-config. Any
 >> parameters passed in will be overwritten anyway when the calls to
 >> pkg-config are made.
 >>     
 >
 > Ooow, ok. Yes you're right. Hehe.
 >
 >   
 >> Does it make more sense to pass in the values for those or just use
 >> pkg-config to figure them out? The former will require a little more
 >> work to achieve, either with some sed magic or a patch.
 >>     
 >
 > I don't know much about pkg-config (gnome stuff ;-), but I think that 
 > considering that the package will only work if installed in the right place, 
 > this is the kind of package where it's better to not pretend. It *must* be in 
 > the gtk theme dir, it *must* be in the kcm dir. PREFIX is useful for packages 
 > that are pretty much self hosted, here it's probably better to not use it at 
 > all. If a user would want a large body of software (kde,gnome) working 
 > together installed in a non standard place they would/should change LOCALBASE 
 > or maybe DESTDIR.
 >
 > Besides, since pkg-config seems to do the right thing, I don't see a reason 
 > not to just use what it comes up with unless it breaks something. They 
 > probably thought harder about it than I did.
 >
 >   
 >>> - re-add lib dependency on kdecore. The kcm module build really requires
 >>> kdecore. And I think also for running.
 >>>       
 >> Whoops, that was an accident.
 >>     
 >
 > Wonder why I never used USE_KDEBASE_VER there, well, let's do it now!
 >
 >   
 >>> - I like the CMAKE_ARGS way of passing CXX and friends that you used,
 >>> kept that in, also used a CMAKE variable for the cmake path, which I
 >>> expect a new bsd.cmake.mk to so in the near future (as well as probably
 >>> providing a canned-in way to add common cmake args).
 >>>       
 >> I was going to suggest making it:
 >>
 >> CMAKE?=          ${LOCALBASE}/bin/cmake
 >>     
 >
 > Yes, that's better.
 >
 >   
 >> However, I suppose the Makefile will be edited anyway after the
 >> introduction of bsd.cmake.mk, so the point is irrelevant.
 >>     
 >
 > Well, I'm not saying there will be one, rather that I think eventually there 
 > will be one (with kde4 and all).
 >
 >   
 >>> - I noticed you using the pre-build target, while you probably wanted to
 >>> override the do-configure target. To do that you use do-configure and set
 >>> HAS_CONFIGURE=yes. Well, that's what I did at least :)
 >>>       
 >> Ok, makes more sense.
 >>
 >>     
 >>> I tested on tinderbuild/STABLE and also tested building with gcc42, and
 >>> limited runtime testing (that is: look at abiword's GUI)
 >>>
 >>> Thanks!
 >>>
 >>> Dan
 >>>       
 >> Well, your update to the port works fine for me as well.
 >>
 >> Sincerely,
 >> Dave Grochowski
 >>     
 >
 > Attached is a reworked and simplified version (e.g. rely on pkg-config since 
 > it seems to be doing its job alright) of the port, now also using 
 > USE_KDEBASE_VER as should.
 >
 > Thanks,
 >
 > Dan
 >   
 The patch looks good! I think you should still pass in 
 ${CMAKE_INSTALL_PREFIX}, since that is not automagically determined from 
 pkg-config (I think it is determined when cmake is compiled and 
 installed). However, it might be pointless, since I think it only 
 determines the install locations for the internationalization stuff. Thanks!
 
 Sincerely,
 Dave Grochowski

From: Andriy Gapon <avg@icyb.net.ua>
To: bug-followup@FreeBSD.org, malus.x@gmail.com
Cc:  
Subject: Re: ports/116058: Update: x11-themes/gtk-qt-engine to version 0.8
Date: Fri, 28 Dec 2007 16:22:46 +0200

 I used the latest patch in the PR to try the new version and I got a
 problem: it seems that I can not select "Use another font". That is, I
 can select the option in radio control, but it doesn't hold - if I press
 Apply/OK and close configuration dialog, then open it again then "Use my
 KDE fonts ..." is selected again.
 
 Also, fonts in GTK/GNOME applications look bigger than the same fonts in
 KDE ones, approximately as if they were larger by 1 point. Or maybe
 different DPI value is in effect for them (actual DPI is 86x86 for my
 LCD monitor).
 
 Just in case, I haven't (explicitly) changed any related settings in KDE
 or elsewhere, just patched the port, performed upgrade and restarted KDE.
 
 -- 
 Andriy Gapon
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Mon Apr 28 11:38:08 UTC 2008 
State-Changed-Why:  
can close, is committed few weeks ago. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116058 
>Unformatted:
