From vova@fbsd.ru  Mon Sep  3 07:19:10 2007
Return-Path: <vova@fbsd.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0691816A420
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 Sep 2007 07:19:10 +0000 (UTC)
	(envelope-from vova@fbsd.ru)
Received: from vbook.fbsd.ru (swsoft-mipt-nat.sw.ru [195.214.233.10])
	by mx1.freebsd.org (Postfix) with ESMTP id B4DDE13C46A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  3 Sep 2007 07:19:09 +0000 (UTC)
	(envelope-from vova@fbsd.ru)
Received: from localhost.fbsd.ru ([127.0.0.1] helo=vbook.fbsd.ru)
	by vbook.fbsd.ru with esmtp (Exim 4.67 (FreeBSD))
	(envelope-from <vova@fbsd.ru>)
	id 1IS5r4-0000TE-5y
	for FreeBSD-gnats-submit@freebsd.org; Mon, 03 Sep 2007 10:56:14 +0400
Message-Id: <1188802574.1791@vbook.fbsd.ru>
Date: Mon, 3 Sep 2007 10:56:14 +0400
From: "Vladimir Grebenschikov" <vova@fbsd.ru>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: net/tsclient have disabled panel applet
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify: ports@thepentagon.org

>Number:         116042
>Category:       ports
>Synopsis:       net/tsclient have disabled panel applet
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lme
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 03 07:20:00 GMT 2007
>Closed-Date:    Sat Dec 29 18:05:37 UTC 2007
>Last-Modified:  Sat Dec 29 18:10:00 UTC 2007
>Originator:     Vladimir Grebenschikov
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
SWsoft 
>Environment:


System: FreeBSD 7.0-CURRENT #36: Thu Aug 30 20:30:00 MSD 2007
    root@vbook.fbsd.ru:/usr/obj/usr/src/sys/VBOOK

Freesh ports tree



>Description:


net/tsclient does not install gnome panel appet. It was due to bug in building it - 
no define HAVE_GNOME while build.

This is fixed by that patch.


>How-To-Repeat:





>Fix:


Index: Makefile
===================================================================
RCS file: /usr/ncvs/ports/net/tsclient/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile	19 May 2007 20:19:08 -0000	1.26
+++ Makefile	27 Jun 2007 21:34:56 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	tsclient
 PORTVERSION=	0.148
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	net gnome
 MASTER_SITES=	http://www.gnomepro.com/tsclient/
 
Index: pkg-plist
===================================================================
RCS file: /usr/ncvs/ports/net/tsclient/pkg-plist,v
retrieving revision 1.11
diff -u -r1.11 pkg-plist
--- pkg-plist	31 Oct 2006 13:27:39 -0000	1.11
+++ pkg-plist	27 Jun 2007 21:32:31 -0000
@@ -1,4 +1,5 @@
 bin/tsclient
+libexec/tsclient-applet
 share/gnome/application-registry/tsclient.applications
 share/gnome/applications/tsclient.desktop
 share/gnome/mime-info/tsclient.keys
Index: files/patch-Makefile.in
===================================================================
RCS file: /usr/ncvs/ports/net/tsclient/files/patch-Makefile.in,v
retrieving revision 1.3
diff -u -r1.3 patch-Makefile.in
--- files/patch-Makefile.in	31 Oct 2006 13:27:39 -0000	1.3
+++ files/patch-Makefile.in	27 Jun 2007 21:10:18 -0000
@@ -1,14 +1,5 @@
 --- Makefile.in.bak	Sun Oct  8 03:03:52 2006
 +++ Makefile.in	Sun Oct  8 03:04:10 2006
-@@ -145,7 +145,7 @@
- sysconfdir = @sysconfdir@
- target_alias = @target_alias@
- 
--SUBDIRS = src applet po
-+SUBDIRS = src po
- 
- appicondir = $(datadir)/pixmaps
- appicon_DATA = tsclient.png
 @@ -161,7 +161,7 @@
  mime_DATA = tsclient.mime tsclient.keys
  
Index: files/patch-configure
===================================================================
RCS file: files/patch-configure
diff -N files/patch-configure
--- files/patch-configure	31 Oct 2006 13:27:40 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,27 +0,0 @@
---- configure.	Fri Oct 13 03:55:18 2006
-+++ configure	Fri Oct 13 03:55:40 2006
-@@ -4198,7 +4198,6 @@
- 
- 
- pkg_modules="libgnomeui-2.0"
--pkg_modules="libpanelapplet-2.0"
- 
-   succeeded=no
- 
-@@ -5614,7 +5613,7 @@
- fi
- 
- 
--                                        ac_config_files="$ac_config_files Makefile src/Makefile applet/Makefile po/Makefile.in"
-+                                        ac_config_files="$ac_config_files Makefile src/Makefile po/Makefile.in"
- cat >confcache <<\_ACEOF
- # This file is a shell script that caches the results of configure
- # tests run on this system so they can be shared between configure
-@@ -6188,7 +6187,6 @@
-   # Handling of arguments.
-   "Makefile" ) CONFIG_FILES="$CONFIG_FILES Makefile" ;;
-   "src/Makefile" ) CONFIG_FILES="$CONFIG_FILES src/Makefile" ;;
--  "applet/Makefile" ) CONFIG_FILES="$CONFIG_FILES applet/Makefile" ;;
-   "po/Makefile.in" ) CONFIG_FILES="$CONFIG_FILES po/Makefile.in" ;;
-   "default-1" ) CONFIG_COMMANDS="$CONFIG_COMMANDS default-1" ;;
-   "depfiles" ) CONFIG_COMMANDS="$CONFIG_COMMANDS depfiles" ;;
Index: files/patch-define-gnome
===================================================================
RCS file: files/patch-define-gnome
diff -N files/patch-define-gnome
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-define-gnome	27 Jun 2007 21:30:26 -0000
@@ -0,0 +1,11 @@
+--- configure.orig	2007-06-28 01:27:14.000000000 +0400
++++ configure	2007-06-28 01:27:31.000000000 +0400
+@@ -5689,7 +5689,7 @@
+ }'
+ fi
+ 
+-DEFS=-DHAVE_CONFIG_H
++DEFS="-DHAVE_CONFIG_H -DHAVE_GNOME"
+ 
+ ac_libobjs=
+ ac_ltlibobjs=


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 3 07:20:10 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116042 

From: "Tim Welch" <twelch@thepentagon.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/116042: net/tsclient have disabled panel applet
Date: Mon, 10 Sep 2007 06:18:05 -0500

 ------=_Part_8112_4839741.1189423085413
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Mon, 3 Sep 2007 07:20:06 UT, Edwin Groothuis <edwin@freebsd.org> wrote:
 >
 > Maintainer of net/tsclient,
 >
 > Please note that PR ports/116042 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/116042
 >
 > --
 > Edwin Groothuis
 > edwin@FreeBSD.org
 >
 
 
 No objections on my end.
 
 ------=_Part_8112_4839741.1189423085413
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 On Mon, 3 Sep 2007 07:20:06 UT, <b class="gmail_sendername">Edwin Groothuis</b> &lt;<a href="mailto:edwin@freebsd.org">edwin@freebsd.org</a>&gt; wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 Maintainer of net/tsclient,<br><br>Please note that PR ports/116042 has just been submitted.<br><br>If it contains a patch for an upgrade, an enhancement or a bug fix<br>you agree on, reply to this email stating that you approve the patch
 <br>and a committer will take care of it.<br><br>The full text of the PR can be found at:<br>&nbsp;&nbsp;&nbsp;&nbsp;<a href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/116042">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/116042</a>
 <br><br>--<br>Edwin Groothuis<br><a href="mailto:edwin@FreeBSD.org">edwin@FreeBSD.org</a><br></blockquote></div><br><br>No objections on my end.<br><br>
 
 ------=_Part_8112_4839741.1189423085413--
Responsible-Changed-From-To: freebsd-ports-bugs->lme 
Responsible-Changed-By: lme 
Responsible-Changed-When: Sun Oct 14 09:13:29 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116042 
State-Changed-From-To: feedback->closed 
State-Changed-By: lme 
State-Changed-When: Sat Dec 29 18:05:36 UTC 2007 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116042 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/116042: commit references a PR
Date: Sat, 29 Dec 2007 18:05:30 +0000 (UTC)

 lme         2007-12-29 18:05:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/tsclient         Makefile pkg-plist 
   Log:
   - Enable support for GNOME panel applet
   - Fix pkg-plist
   - Bump PORTREVISION
   
   PR:             ports/116042
   Submitted by:   Vladimir Grebenschikov <vova (AT) fbsd.ru>
   Approved by:    miwi (mentor)
   
   Revision  Changes    Path
   1.29      +3 -5      ports/net/tsclient/Makefile
   1.14      +36 -35    ports/net/tsclient/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
