From root@mail.adam.gs  Thu Aug 23 02:09:21 2007
Return-Path: <root@mail.adam.gs>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B3D8D16A420
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Aug 2007 02:09:21 +0000 (UTC)
	(envelope-from root@mail.adam.gs)
Received: from mail.adam.gs (mail.adam.gs [76.9.2.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 983B313C48E
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 23 Aug 2007 02:09:21 +0000 (UTC)
	(envelope-from root@mail.adam.gs)
Received: by mail.adam.gs (Postfix, from userid 0)
	id A41D1F35214; Wed, 22 Aug 2007 21:57:45 -0400 (EDT)
Message-Id: <20070823015745.A41D1F35214@mail.adam.gs>
Date: Wed, 22 Aug 2007 21:57:45 -0400 (EDT)
From: Adam Jacob Muller <adam@adam.gs>
Reply-To: Adam Jacob Muller <adam@adam.gs>
To: FreeBSD-gnats-submit@freebsd.org
Cc: adam@adam.gs
Subject: fix to misc/zaptel rc.d script to specify modules to load
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         115739
>Category:       ports
>Synopsis:       fix to misc/zaptel rc.d script to specify modules to load
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sobomax
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 23 02:10:06 GMT 2007
>Closed-Date:    Fri Aug 15 18:49:25 UTC 2008
>Last-Modified:  Fri Aug 15 18:50:01 UTC 2008
>Originator:     Adam Jacob Muller
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD apple.adam.gs 6.2-STABLE FreeBSD 6.2-STABLE #3: Sat Apr 21 00:45:02 EDT 2007 root@apple.adam.gs:/usr/obj/usr/src/sys/ISPRIME1750SMP i386


	
>Description:
	the misc/zaptel port specifies a fixed list of modules to load, this should be configurable by /etc/rc.conf.
	Patch attached fixes this.
>How-To-Repeat:
	N/A really but try to get rc.d/zaptel.sh to only load zaptel.ko, ztdummy.ko
>Fix:
	Cavet: I'm not really sure this is the correct way to do it, but it looks right, seems consistant with other ports rc.d scripts, and it works.


--- zaptel.in.orig      Wed Aug 22 21:52:56 2007
+++ zaptel.in   Wed Aug 22 21:52:31 2007
@@ -18,8 +18,8 @@
 
 kmod_dir=%%PREFIX%%/lib/zaptel
 
-zaptel_kmod_load="zaptel.ko qozap.ko tau32pci.ko wcfxo.ko wcfxs.ko wct1xxp.ko wct4xxp.ko wcte11xp.ko"
-zaptel_kmod_unload="wcte11xp.ko wct4xxp.ko wct1xxp.ko wcfxs.ko wcfxo.ko tau32pci.ko qozap.ko zaptel.ko"
+: ${zaptel_kmod_load="zaptel.ko qozap.ko tau32pci.ko wcfxo.ko wcfxs.ko wct1xxp.ko wct4xxp.ko wcte11xp.ko"}
+: ${zaptel_kmod_unload="wcte11xp.ko wct4xxp.ko wct1xxp.ko wcfxs.ko wcfxo.ko tau32pci.ko qozap.ko zaptel.ko"}
 name="zaptel"
 rcvar=${name}_enable
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sobomax 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Aug 23 02:10:11 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115739 
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Fri Aug 15 18:49:11 UTC 2008 
State-Changed-Why:  
The change commited, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115739 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/115739: commit references a PR
Date: Fri, 15 Aug 2008 18:49:10 +0000 (UTC)

 sobomax     2008-08-15 18:48:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     misc/zaptel          Makefile 
     misc/zaptel/files    zaptel.in 
   Log:
   Allow list of modules to be loaded at startup to be configured via
   zaptel_kmod_load rc.conf variable.
   
   PR:             ports/115739
   Submitted by:   Adam Jacob Muller <adam@adam.gs>
   
   Revision  Changes    Path
   1.36      +1 -1      ports/misc/zaptel/Makefile
   1.5       +15 -8     ports/misc/zaptel/files/zaptel.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
