From gene@bbq.nttmcl.com  Wed Aug 15 18:49:49 2007
Return-Path: <gene@bbq.nttmcl.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D6E7E16A417
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Aug 2007 18:49:49 +0000 (UTC)
	(envelope-from gene@bbq.nttmcl.com)
Received: from bbq.nttmcl.com (bbq.nttmcl.com [IPv6:2001:418:200:0:250:8dff:fee3:718c])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E2BB13C46A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Aug 2007 18:49:49 +0000 (UTC)
	(envelope-from gene@bbq.nttmcl.com)
Received: from bbq.nttmcl.com (localhost [127.0.0.1])
	by bbq.nttmcl.com (8.14.1/8.13.8) with ESMTP id l7FInk0Q044406
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Aug 2007 11:49:46 -0700 (PDT)
	(envelope-from gene@bbq.nttmcl.com)
Received: (from gene@localhost)
	by bbq.nttmcl.com (8.14.1/8.13.8/Submit) id l7FInkRF044405;
	Wed, 15 Aug 2007 11:49:46 -0700 (PDT)
	(envelope-from gene)
Message-Id: <200708151849.l7FInkRF044405@bbq.nttmcl.com>
Date: Wed, 15 Aug 2007 11:49:46 -0700 (PDT)
From: "Eugene M. Kim" <gene@nttmcl.com>
Reply-To: "Eugene M. Kim" <gene@nttmcl.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: devel/aunit and devel/florist-gpl break "make index"
X-Send-Pr-Version: 3.113
X-GNATS-Notify: john_m_cooper@yahoo.com

>Number:         115559
>Category:       ports
>Synopsis:       devel/aunit and devel/florist-gpl break "make index"
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    edwin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 15 18:50:06 GMT 2007
>Closed-Date:    Sun Sep 09 00:11:25 GMT 2007
>Last-Modified:  Wed Oct 24 02:40:01 UTC 2007
>Originator:     Eugene M. Kim
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
NTT Multimedia Communications Laboratories, Inc.
>Environment:
System: FreeBSD bbq.nttmcl.com 6.2-STABLE FreeBSD 6.2-STABLE #4: Tue May 15 18:24:31 PDT 2007 gene@bbq.nttmcl.com:/home/FreeBSD/build/RELENG_6/obj/home/FreeBSD/build/RELENG_6/src/sys/BBQ i386
>Description:
The Makefiles for devel/aunit and devel/florist-gpl try to run
${ECHO_MSG} ${IGNORE} explicitly after setting ${IGNORE}.  Because the
command is not part of any target, this results in a Makefile parse
error.
>How-To-Repeat:
Run "make index" from /usr/ports.
>Fix:
Remove the "${ECHO_MSG} ${IGNORE}" line; since bsd.ports.mk prints out
${IGNORE} when it is set, the ${ECHO_MSG} command is not needed anyways.
>Release-Note:
>Audit-Trail:

State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Aug 15 18:50:14 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115559 
Responsible-Changed-From-To: freebsd-ports-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Sep 8 13:52:42 UTC 2007 
Responsible-Changed-Why:  
I can't reproduce this issue, can you confirm it is still happening? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115559 
State-Changed-From-To: feedback->closed 
State-Changed-By: edwin 
State-Changed-When: Sun Sep 9 00:11:09 UTC 2007 
State-Changed-Why:  
Caused by EMACS_PORT=emacs22 in your make.conf. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115559 

From: "Eugene M. Kim" <gene@nttmcl.com>
To: bug-followup@freebsd.org, edwin@freebsd.org
Cc:  
Subject: Re: ports/115559: devel/aunit and devel/florist-gpl break "make index"
Date: Mon, 10 Sep 2007 12:02:09 -0700

 Hello Edwin,
 
 The thing is, I don't have EMACS_PORTS set in /etc/make.conf at all...
 
 After some more probing and testing, I think I found another cause of 
 the problem: Both Makefiles try and use ${DISTDIR} and ${DISTFILE} 
 before it is set.  Splitting the <bsd.ports.mk> include into separate 
 pre/post includes solves (or to be correct, works around) the problem.
 
 The original cause (spurious, orphaned ${ECHO_MSG} statement) needs to 
 be fixed nevertheless.  Similar processing code found in other ports 
 (java/diablo-jdk15 for example) does not have one.
 
 Thank you,
 Eugene

From: bf <bf2006a@yahoo.com>
To: edwin@FreeBSD.org, "Eugene M. Kim" <gene@nttmcl.com>,
  bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/115559: devel/aunit and devel/florist-gpl break "make index"
Date: Tue, 23 Oct 2007 19:30:10 -0700 (PDT)

 I can confirm that these two ports also break make
 index on my machine (6.2-stable i386 -- and I'm
 getting tired of patching them when I need to build
 the index!)
 
 In addition to the problem mentioned in the PR, the
 default fetch target is not modified, so time and
 bandwidth can be wasted by attempting to fetch the
 distfiles as part of the fetch or checksum stages.
 
 As Eugene noted, the ports also attempt to use
 variables before they have been defined.  The problem
 goes beyond  the lack of an inclusion of
 bsd.port.pre.mk (although that is needed: as far as I
 can tell the variable DISTFILE (no final S!) is
 defined neither in bsd.port.mk nor in the port
 Makefiles.  So the Makefiles as they are now will not
 work properly -- all this leads me to believe that
 they were never fully tested when submitted or
 committed. Here are two patches to fix the problems,
 in which I tried to stay faithful to the maintainer's
 original intentions:
 
 --- Makefile.orig	Fri Jan 12 20:18:29 2007
 +++ Makefile	Tue Oct 23 11:01:10 2007
 @@ -19,18 +19,24 @@
  
  USE_GMAKE=	yes
  
 +.include <bsd.port.pre.mk>
 +
  # Check for GNAT sources.
 -.if !exists(${DISTDIR}/${DISTFILE}) &&
 !defined(PACKAGE_BUILDING)
 -ECHO_MSG=	${PRINTF}
 -IGNORE=Because of licensing and registration
 restrictions, you must fetch\n \
 -	the source distribution manually.  Please access\n \
 -	http://libre.adacore.com/\ with a web browser,
 register\n \
 -	(It's free!) and log in.  Download the source
 files:\n\n \
 -	\t${DISTFILE}\n\n \
 -	and place them in ${DISTDIR}\n
 -	${ECHO_MSG} ${IGNORE}
 +.if !defined(PACKAGE_BUILDING) &&
 !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX})
 +do-fetch:
 +	@${ECHO_CMD} "Because of licensing and registration
 restrictions, you must fetch"
 +	@${ECHO_CMD} "the source distribution manually. 
 Please access"
 +	@${ECHO_CMD} "http://libre.adacore.com/ with a web
 browser, register"
 +	@${ECHO_CMD} "(It's free!) and log in.  Download the
 source files:"
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} "${DISTFILES}"
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} "and place them in ${DISTDIR}."
  .endif
  
 +FETCH_REGET=	0
  WRKSRC=		${WRKDIR}/aunit-${PORTVERSION}-src
  
  pre-build:
 @@ -45,4 +51,4 @@
  test:
  	@${CD} ${WRKSRC} && ${GMAKE} test
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 
 
 
 ****************************************************
 
 
 
 
 
 --- Makefile.orig	Fri Jan  5 03:44:44 2007
 +++ Makefile	Tue Oct 23 10:54:46 2007
 @@ -21,18 +21,24 @@
  CONFIGURE_ENV=	CFLAGS="${CFLAGS}" \
  		LIBS="${PTHREAD_LIBS}"
  
 +.include <bsd.port.pre.mk>
 +
  # Check for GNAT sources.
 -.if !exists(${DISTDIR}/${DISTFILE}) &&
 !defined(PACKAGE_BUILDING)
 -ECHO_MSG=	${PRINTF}
 -IGNORE=Because of licensing and registration
 restrictions, you must fetch\n \
 -	the source distribution manually.  Please access\n \
 -	http://libre.adacore.com/\ with a web browser,
 register\n \
 -	(It's free!) and log in.  Download the source
 files:\n\n \
 -	\t${DISTFILE}\n\n \
 -	and place them in ${DISTDIR}\n
 -	${ECHO_MSG} ${IGNORE}
 +.if !defined(PACKAGE_BUILDING) &&
 !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX})
 +do-fetch:
 +	@${ECHO_CMD} "Because of licensing and registration
 restrictions, you must fetch"
 +	@${ECHO_CMD} "the source distribution manually. 
 Please access"
 +	@${ECHO_CMD} "http://libre.adacore.com/ with a web
 browser, register"
 +	@${ECHO_CMD} "(It's free!) and log in.  Download the
 source files:"
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} "${DISTFILES}"
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} ""
 +	@${ECHO_CMD} "and place them in ${DISTDIR}."
  .endif
  
 +FETCH_REGET=	0
  WRKSRC=		${WRKDIR}/florist-${PORTVERSION}-src
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 
 
 **************************************************
 
 Please fix these problems!
 
 Thanks,
 
             bf
 
 __________________________________________________
 Do You Yahoo!?
 Tired of spam?  Yahoo! Mail has the best spam protection around 
 http://mail.yahoo.com 
>Unformatted:
