From rebum@mail.vx.sk  Tue Jul 31 10:21:56 2007
Return-Path: <rebum@mail.vx.sk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 499C816A417
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Jul 2007 10:21:56 +0000 (UTC)
	(envelope-from rebum@mail.vx.sk)
Received: from mail.vx.sk (neo.vx.sk [88.198.35.14])
	by mx1.freebsd.org (Postfix) with ESMTP id B347113C48E
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Jul 2007 10:21:55 +0000 (UTC)
	(envelope-from rebum@mail.vx.sk)
Received: from localhost (localhost [127.0.0.1])
	by mail.vx.sk (Postfix) with ESMTP id C12C0443A7
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 31 Jul 2007 12:21:54 +0200 (CEST)
Received: from mail.vx.sk ([127.0.0.1])
	by localhost (mail.vx.sk [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id xXj8+6bqCTrP for <FreeBSD-gnats-submit@freebsd.org>;
	Tue, 31 Jul 2007 12:21:52 +0200 (CEST)
Received: by mail.vx.sk (Postfix, from userid 1001)
	id 129DC443B5; Tue, 31 Jul 2007 12:21:52 +0200 (CEST)
Message-Id: <20070731102152.129DC443B5@mail.vx.sk>
Date: Tue, 31 Jul 2007 12:21:52 +0200 (CEST)
From: Martin Matuska <mm@FreeBSD.org>
Reply-To:
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [DEPS] graphics/libungif reduce X dependencies
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         115077
>Category:       ports
>Synopsis:       graphics/libungif: reduce X dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 31 10:30:07 GMT 2007
>Closed-Date:    Sun Aug 19 11:06:33 CEST 2007
>Last-Modified:  Sun Aug 26 16:00:05 GMT 2007
>Originator:     Martin Matuska
>Release:        FreeBSD 6.2-STABLE i386 amd64
>Organization:
>Environment:
System: FreeBSD 6.2-STABLE i386 amd64
>Description:
This port requires only USE_XORG= xt
(tested with tinderbox)

>How-To-Repeat:
>Fix:
Index: ports/graphics/libungif/Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/libungif/Makefile,v
retrieving revision 1.39
diff -u -r1.39 Makefile
--- ports/graphics/libungif/Makefile	19 May 2007 20:09:54 -0000	1.39
+++ ports/graphics/libungif/Makefile	31 Jul 2007 10:15:04 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	libungif
 PORTVERSION=	4.1.4
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	graphics
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -27,7 +27,7 @@
 CONFIGURE_ARGS+=	--with-x=no
 NOX11SUFFIX=	-nox11
 .else
-USE_XLIB=	yes
+USE_XORG=	xt
 PLIST_SUB+=	X11=''
 .endif
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Jul 31 10:30:14 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115077 
State-Changed-From-To: open->feedback 
State-Changed-By: dinoex 
State-Changed-When: Wed Aug 15 11:54:25 CEST 2007 
State-Changed-Why:  
1. ldd suggests this line: 
USE_XLIB=	sm ice x11 xau xdmcp 

2. the dependency list is not really changed 
make all-depends-list 
has still the same output, so a bump seem not be necessary. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=115077 

From: Martin Matuska <mm@FreeBSD.org>
To: bug-followup@FreeBSD.org,  mm@FreeBSD.org
Cc:  
Subject: Re: ports/115077: graphics/libungif: reduce X dependencies
Date: Thu, 16 Aug 2007 12:58:02 +0200

 1. not USE_XLIB= .... but USE_XORG= ....
 that makes a huge difference, you get the same dependency list if
 USE_XLIB is still there (value of USE_XLIB is not considered)
 PORTREVISION bump is necessary
 (I was already taught by pav and kris to always include it when
 switching USE_XLIB->USE_XORG)
 
 2. USE_XORG= xt is not really necessary (it includes sm and x11, but we
 do not need libXt),
 but we do not need to state all of the libs, too:
 
 a) if you do a ldd on libX11 you get libXau and libXdmcp as deps (x11
 includes xau + xdmcp)
 b) if you do a ldd on libSM you get libICE as a dep (sm includes ice)
 
 that means I correct myself to:
 USE_XORG=sm x11
 
 Here are some tb logs for USE_XORG=sm x11:
 http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/libungif-4.1.4_4.log
 http://i386.vx.sk/logs/6.2-FreeBSD-i386/libungif-4.1.4_4.log
 http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/libungif-4.1.4_4.log
 http://i386.vx.sk/logs/5.5-FreeBSD-i386/libungif-4.1.4_4.log
 
 Thanks.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/115077: commit references a PR
Date: Sat, 18 Aug 2007 21:10:48 +0000 (UTC)

 dinoex      2007-08-18 21:10:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/libungif    Makefile 
   Log:
   - list detailed dependencies
   PR:             115077
   Submitted by:   mm
   
   Revision  Changes    Path
   1.40      +2 -2      ports/graphics/libungif/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Sun Aug 19 11:05:26 CEST 2007 
State-Changed-Why:  

I checked whcih libs are linked in directly: 

cd /usr/ports/current/libungif && make configure 

wcd 

grep LIBS Makefile 
LIBS =  
X_EXTRA_LIBS =  
X_LIBS =  -L/usr/local/lib 
X_PRE_LIBS =  -lSM -lICE 

committed with small changes, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115077 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/115077: commit references a PR
Date: Sun, 26 Aug 2007 15:51:20 +0000 (UTC)

 mm          2007-08-26 15:51:14 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/libungif    Makefile 
   Log:
   - Replace USE_XLIB with USE_XORG=sm x11
   - Bump PORTREVISION
   
   PR:             ports/115077
   Approved by:    dinoex (maintainer, private e-mail)
   
   Revision  Changes    Path
   1.41      +2 -2      ports/graphics/libungif/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
