From nobody@FreeBSD.org  Sun Jul 29 21:57:29 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 97D6D16A418
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Jul 2007 21:57:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 87CD613C474
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Jul 2007 21:57:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l6TLvTgW016403
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 29 Jul 2007 21:57:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l6TLvTrn016381;
	Sun, 29 Jul 2007 21:57:29 GMT
	(envelope-from nobody)
Message-Id: <200707292157.l6TLvTrn016381@www.freebsd.org>
Date: Sun, 29 Jul 2007 21:57:29 GMT
From: "Herbert J. Skuhra" <h.skuhra@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] audio/gtkpod: add missing dependencies for vorbis & flac
X-Send-Pr-Version: www-3.0

>Number:         115021
>Category:       ports
>Synopsis:       [PATCH] audio/gtkpod: add missing dependencies for vorbis & flac
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    danfe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 29 22:00:05 GMT 2007
>Closed-Date:    Wed Aug 15 13:04:38 GMT 2007
>Last-Modified:  Wed Aug 15 13:04:38 GMT 2007
>Originator:     Herbert J. Skuhra
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
FreeBSD oslo.ath.cx 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat Jul 14 10:15:17 CEST 2007     herbert@oslo.ath.cx:/usr/obj/usr/src/sys/PC1  i386
>Description:
The port audio/gtkpod is build with ogg and flac support when libvorbis and libFLAC is detected during configure. There is no LIB_DEPENDS for both. 
>How-To-Repeat:

>Fix:
The attached patch* adds two knobs (VORBIS & FLAC) and the required dependencies.

* http://norway.ath.cx/freebsd/gtkpod_20070729.diff



Patch attached with submission follows:

--- Makefile.bak	2007-07-29 23:40:10.000000000 +0200
+++ Makefile	2007-07-29 23:43:14.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	gtkpod
 PORTVERSION=	0.99.10
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -25,7 +26,9 @@
 GNU_CONFIGURE=	yes
 INSTALLS_ICONS=	yes
 
-OPTIONS=	MPEG4IP	"Enable AAC and H.264 support with MPEG4IP" off
+OPTIONS=	MPEG4IP	"Enable AAC and H.264 support with MPEG4IP" off \
+		VORBIS "Enable OGG support" off \
+		FLAC "Enable FLAC support" off
 
 .include <bsd.port.pre.mk>
 
@@ -33,10 +36,26 @@
 WITH_MPEG4IP=	YES
 .endif
 
+.if exists(${LOCALBASE}/lib/libvorbis.so)
+WITH_VORBIS=	YES
+.endif
+
+.if exists(${LOCALBASE}/lib/libFLAC.so)
+WITH_FLAC=	YES
+.endif
+
 .if defined(WITH_MPEG4IP)
 LIB_DEPENDS+=	mp4v2.0:${PORTSDIR}/multimedia/mpeg4ip-libmp4v2
 .endif
 
+.if defined(WITH_VORBIS)
+LIB_DEPENDS+=	vorbis.4:${PORTSDIR}/audio/libvorbis
+.endif
+
+.if defined(WITH_FLAC)
+LIB_DEPENDS+=	FLAC.7:${PORTSDIR}/audio/flac
+.endif
+
 CONFIGURE_ENV+=	CPPFLAGS="-I${LOCALBASE}/include"
 CONFIGURE_ENV+=	LDFLAGS="-L${LOCALBASE}/lib"
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->danfe 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jul 29 22:00:16 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115021 
State-Changed-From-To: open->closed 
State-Changed-By: danfe 
State-Changed-When: Wed Aug 15 13:04:17 UTC 2007 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115021 
>Unformatted:
