From nobody@FreeBSD.org  Sat Jul 21 10:41:33 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4ADA016A419
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jul 2007 10:41:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (unknown [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BB4F13C48E
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jul 2007 10:41:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l6LAfWCq051178
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jul 2007 10:41:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l6LAfWe2051177;
	Sat, 21 Jul 2007 10:41:32 GMT
	(envelope-from nobody)
Message-Id: <200707211041.l6LAfWe2051177@www.freebsd.org>
Date: Sat, 21 Jul 2007 10:41:32 GMT
From: Olivier Smedts <olivier@gid0.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] bad dependencies in audio/tuxguitar
X-Send-Pr-Version: www-3.0

>Number:         114792
>Category:       ports
>Synopsis:       [patch] bad dependencies in audio/tuxguitar
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    hq
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 21 10:50:01 GMT 2007
>Closed-Date:    Sat Jul 28 00:33:33 GMT 2007
>Last-Modified:  Sat Jul 28 00:40:01 GMT 2007
>Originator:     Olivier Smedts
>Release:        6.2-STABLE
>Organization:
gid0.org
>Environment:
FreeBSD z.gid0.org 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat Jul 14 22:13:35 CEST 2007     root@z.gid0.org:/work/obj/work/src/sys/XPC  i386

>Description:
audio/tuxguitar not only BUILD_DEPENDS on x11-toolkits/swt and devel/itext, it RUN_DEPENDS on these too.
>How-To-Repeat:
# cd /usr/ports/audio/tuxguitar/
# make install clean
# pkg_delete swt-3.2.2_1
% tuxguitar
Exception in thread "main" java.lang.NoClassDefFoundError: org/eclipse/swt/widgets/Layout
# pkg_delete itext-2.0.4,1
% tuxguitar
Exception in thread "main" java.lang.NoClassDefFoundError: com/lowagie/text/BadElementException

>Fix:
I tested, it needs swt and itext in both BUILD and RUN.

--- Makefile.old        Sat Jul 21 12:34:46 2007
+++ Makefile    Sat Jul 21 12:38:10 2007
@@ -19,6 +19,9 @@
 BUILD_DEPENDS= ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
 		${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext
 
+RUN_DEPENDS=   ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
+		${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext
+
 WRKSRC=		${WRKDIR}/TuxGuitar-0.9.1-src
 
 USE_JAVA=	yes


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Jul 21 10:50:10 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114792 

From: Pietro Cerutti <gahr@gahr.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114792: [patch] bad dependencies in audio/tuxguitar
Date: Mon, 23 Jul 2007 01:07:45 +0200

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig2CBF51125FC6FE789458CE3B
 Content-Type: multipart/mixed;
  boundary="------------040905040708030607010807"
 
 This is a multi-part message in MIME format.
 --------------040905040708030607010807
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 Edwin Groothuis wrote:
 > Maintainer of audio/tuxguitar,
 >=20
 > Please note that PR ports/114792 has just been submitted.
 >=20
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 
 Correct.
 devel/itext and x11-toolkits/swt should be listed as RUN_DEPEND too
 >=20
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/114792
 >=20
 
 
 --=20
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
 
 
 
 --------------040905040708030607010807
 Content-Type: application/pgp-signature;
  name="signature.asc"
 Content-Transfer-Encoding: base64
 Content-Disposition: inline;
  filename="signature.asc"
 
 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEuNC43IChG
 cmVlQlNEKQoKaUQ4REJRRkdvK0xrd01KcW1KVng5NDRSQ29HWEFLRFBKd3ZKNkE4VGdLOWJ6
 TEJzRCttVGFnWGl3Z0NlTFRCRwo2RXVrb1A5RjBhdndiN3E4a3ZCVGVGdz0KPXhWMjkKLS0t
 LS1FTkQgUEdQIFNJR05BVFVSRS0tLS0tCgo=
 --------------040905040708030607010807--
 
 --------------enig2CBF51125FC6FE789458CE3B
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.7 (FreeBSD)
 
 iD8DBQFGo+NHwMJqmJVx944RCiUBAJ9LphFiAO52onNC+jFlZKS+hJni1ACgiBAE
 46u5VxjcEj3ZKAMOzgnY4xw=
 =oXLv
 -----END PGP SIGNATURE-----
 
 --------------enig2CBF51125FC6FE789458CE3B--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Jul 23 09:45:40 UTC 2007 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114792 

From: Pietro Cerutti <gahr@gahr.ch>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114792: [patch] bad dependencies in audio/tuxguitar
Date: Wed, 25 Jul 2007 13:53:42 +0200

 Please submit the following patch:
 
 --- Makefile.orig       Wed Jul 25 13:49:47 2007
 +++ Makefile    Wed Jul 25 13:50:20 2007
 @@ -7,7 +7,7 @@
 
  PORTNAME=      tuxguitar
  PORTVERSION=   0.9.1
 -PORTREVISION=  1
 +PORTREVISION=  2
  CATEGORIES=    audio java
  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE_EXTENDED}
  MASTER_SITE_SUBDIR=${PORTNAME}
 @@ -17,6 +17,9 @@
  COMMENT=       A Multitrack tablature editor and player
 
  BUILD_DEPENDS= ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
 +               ${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext
 +
 +RUN_DEPENDS=   ${JAVALIBDIR}/swt.jar:${PORTSDIR}/x11-toolkits/swt \
                 ${JAVALIBDIR}/itext.jar:${PORTSDIR}/devel/itext
 
  WRKSRC=                ${WRKDIR}/TuxGuitar-0.9.1-src
 
 Thank you.
 -- 
 Pietro Cerutti
 
 PGP Public Key:
 http://gahr.ch/pgp
Responsible-Changed-From-To: freebsd-ports-bugs->hq 
Responsible-Changed-By: hq 
Responsible-Changed-When: Fri Jul 27 23:56:22 UTC 2007 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114792 
State-Changed-From-To: open->closed 
State-Changed-By: hq 
State-Changed-When: Sat Jul 28 00:32:42 UTC 2007 
State-Changed-Why:  
Patch commited. Thanks for your contribution. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114792 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114792: commit references a PR
Date: Sat, 28 Jul 2007 00:32:40 +0000 (UTC)

 hq          2007-07-28 00:32:35 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/tuxguitar      Makefile 
   Log:
   Add missing x11-toolkits/swt and devel/itext to RUN_DEPENDS
   
   PR:             114792
   Submitted by:   Olivier Smedts <olivier@gid0.org>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.4       +4 -1      ports/audio/tuxguitar/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
