From tabthorpe@goodking.goodking.ca  Tue Jul 10 23:57:43 2007
Return-Path: <tabthorpe@goodking.goodking.ca>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 436B816A46D;
	Tue, 10 Jul 2007 23:57:43 +0000 (UTC)
	(envelope-from tabthorpe@goodking.goodking.ca)
Received: from tbaytel.net (front2-j.tbaytel.net [216.211.26.169])
	by mx1.freebsd.org (Postfix) with ESMTP id CF83213C458;
	Tue, 10 Jul 2007 23:57:42 +0000 (UTC)
	(envelope-from tabthorpe@goodking.goodking.ca)
Received: from stjames.stthomasanglican.org ([216.26.202.251] verified)
  by front2.tbaytel.net (CommuniGate Pro SMTP 5.0.13)
  with ESMTPS id 83265173; Tue, 10 Jul 2007 19:57:41 -0400
Received: from goodking.goodking.ca (goodking-stjames-tun.goodking.ca [172.31.17.10])
	by stjames.stthomasanglican.org (8.14.1/8.14.1) with ESMTP id l6ANvT9N006892
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL);
	Tue, 10 Jul 2007 19:57:30 -0400 (EDT)
	(envelope-from tabthorpe@goodking.goodking.ca)
Received: from goodking.goodking.ca (localhost [127.0.0.1])
	by goodking.goodking.ca (8.14.1/8.14.1) with ESMTP id l6ANu517060670
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 10 Jul 2007 19:56:06 -0400 (EDT)
	(envelope-from tabthorpe@goodking.goodking.ca)
Received: (from root@localhost)
	by goodking.goodking.ca (8.14.1/8.14.1/Submit) id l6ANtQe7060640;
	Tue, 10 Jul 2007 19:55:26 -0400 (EDT)
	(envelope-from tabthorpe)
Message-Id: <200707102355.l6ANtQe7060640@goodking.goodking.ca>
Date: Tue, 10 Jul 2007 19:55:26 -0400 (EDT)
From: Thomas Abthorpe <thomas@goodking.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc: alexander@wittig.name, miwi@freebsd.org, thomas@goodking.ca
Subject: [PATCH] mail/squirrelmail-change_ldappass-plugin: take maintainership
X-Send-Pr-Version: 3.113
X-GNATS-Notify: alexander@wittig.name

>Number:         114488
>Category:       ports
>Synopsis:       [PATCH] mail/squirrelmail-change_ldappass-plugin: take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sat
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 11 00:00:13 GMT 2007
>Closed-Date:    Fri Jul 20 09:36:21 GMT 2007
>Last-Modified:  Fri Jul 20 09:40:02 GMT 2007
>Originator:     Thomas Abthorpe
>Release:        FreeBSD 6.2-RELEASE-p5 i386
>Organization:
GoodKing.Ca
>Environment:
System: FreeBSD goodking.goodking.ca 6.2-RELEASE-p5 FreeBSD 6.2-RELEASE-p5 #0: Sun Jun 10 14:58:15 EDT 2007
>Description:
- Take maintainership, prearranged with current maintainer
- update Makefile for better readibility
- bump PORTREVISION for plist change
- reformat pkg-descr

Port maintainer (alexander@wittig.name) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- squirrelmail-change_ldappass-plugin-2.1_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/squirrelmail-change_ldappass-plugin/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile	23 Jan 2007 19:17:43 -0000	1.4
+++ Makefile	10 Jul 2007 23:53:33 -0000
@@ -4,44 +4,49 @@
 #
 # $FreeBSD: ports/mail/squirrelmail-change_ldappass-plugin/Makefile,v 1.4 2007/01/23 19:17:43 miwi Exp $
 
-PORTNAME=	squirrelmail
+PORTNAME=	change_ldappass
 PORTVERSION=	2.1
+PORTREVISION=	1
 CATEGORIES=	mail www
 MASTER_SITES=	http://www.squirrelmail.org/plugins/
-PKGNAMESUFFIX=	-${SQUIRREL_PLUGIN_NAME}-plugin
-DISTNAME=	${SQUIRREL_PLUGIN_NAME}-${PORTVERSION}-1.4.0
+PKGNAMEPREFIX=	squirrelmail-
+PKGNAMESUFFIX=	-plugin
+DISTNAME=	${PORTNAME}-${PORTVERSION}-1.4.0
 DIST_SUBDIR=	squirrelmail
 
-MAINTAINER=	alexander@wittig.name
+MAINTAINER=	thomas@goodking.ca
 COMMENT=	Allows users to change their passwords stored in LDAP Tree
 
 RUN_DEPENDS=	${SQUIRRELDIR}/index.php:${PORTSDIR}/mail/squirrelmail
 
-SQUIRREL_PLUGIN_NAME=	change_ldappass
+SQUIRREL_PLUGIN_NAME=	${PORTNAME}
 
 .ifdef SQUIRRELDIR
 PLIST_SUB+=	SQUIRRELDIR=${SQUIRRELDIR}
 SUB_LIST+=	"SQUIRRELDIR=${SQUIRRELDIR}"
 .else
-.	ifndef WITHOUT_WWWDIR
+.ifndef WITHOUT_WWWDIR
 SQUIRRELDIR=	${PREFIX}/www/squirrelmail
 PLIST_SUB+=	SQUIRRELDIR=www/squirrelmail
 SUB_LIST+=	"SQUIRRELDIR=www/squirrelmail"
-.	else
+.else
 SQUIRRELDIR=	${PREFIX}/squirrelmail
 PLIST_SUB+=	SQUIRRELDIR=squirrelmail
 SUB_LIST+=	"SQUIRRELDIR=squirrelmail"
-.	endif
 .endif
+.endif
+PLIST_SUB+=	SQUIRREL_PLUGIN_NAME=${SQUIRREL_PLUGIN_NAME}
 
 SUB_FILES=	pkg-message
 
-NO_BUILD=	yes
-NO_WRKSUBDIR=	yes
-USE_PERL5_BUILD=yes
-USE_PHP=	ldap
-WANT_PHP_WEB=	yes
-USE_GETTEXT=	yes
+NO_BUILD=		yes
+NO_WRKSUBDIR=		yes
+USE_PERL5_BUILD=	yes
+USE_PHP=		ldap
+WANT_PHP_WEB=		yes
+USE_GETTEXT=		yes
+
+.include <bsd.port.pre.mk>
 
 pre-everything::
 	@${ECHO} ""
@@ -58,6 +63,7 @@
 
 do-install:
 	${CP} -rp ${WRKSRC}/${SQUIRREL_PLUGIN_NAME} ${SQUIRRELDIR}/plugins
+	${CHOWN} -R ${WWWOWN}:${WWWGRP} ${SQUIRRELDIR}/plugins/${SQUIRREL_PLUGIN_NAME}
 
 post-install:
 .ifndef WITHOUT_ACTIVATE
@@ -72,4 +78,4 @@
 	@${ECHO} ""
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Index: pkg-descr
===================================================================
RCS file: /home/ncvs/ports/mail/squirrelmail-change_ldappass-plugin/pkg-descr,v
retrieving revision 1.1
diff -u -r1.1 pkg-descr
--- pkg-descr	21 Nov 2005 15:03:20 -0000	1.1
+++ pkg-descr	10 Jul 2007 23:53:33 -0000
@@ -1,7 +1,5 @@
-SquirrelMail (mail/suirrelmail) Plug-In to allow users to change their user
-passwords stored in an LDAP directory from within SquirrelMail.
+SquirrelMail (mail/suirrelmail) Plug-In to allow users to change
+their user passwords stored in an LDAP directory from within
+SquirrelMail.
 
 WWW: http://www.squirrelmail.org
-
-- Alexander Wittig
-alexander@wittig.name
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/mail/squirrelmail-change_ldappass-plugin/pkg-plist,v
retrieving revision 1.3
diff -u -r1.3 pkg-plist
--- pkg-plist	31 Oct 2006 13:28:34 -0000	1.3
+++ pkg-plist	10 Jul 2007 23:53:33 -0000
@@ -1,4 +1,4 @@
-@unexec if [ -f %D/%%SQUIRRELDIR%%/config/config.php ]; then %D/%%SQUIRRELDIR%%/config/conf.pl --remove-plugin change_ldappass; fi
+@unexec if [ -f %D/%%SQUIRRELDIR%%/config/config.php ]; then %D/%%SQUIRRELDIR%%/config/conf.pl --remove-plugin %%SQUIRREL_PLUGIN_NAME%%; fi
 %%SQUIRRELDIR%%/plugins/change_ldappass/locale/fr_FR/LC_MESSAGES/change_ldappass.mo
 %%SQUIRRELDIR%%/plugins/change_ldappass/locale/fr_FR/LC_MESSAGES/change_ldappass.po
 %%SQUIRRELDIR%%/plugins/change_ldappass/locale/pl_PL/LC_MESSAGES/change_ldappass.mo
@@ -57,4 +57,4 @@
 @dirrm %%SQUIRRELDIR%%/plugins/change_ldappass/locale/sv_SE
 @dirrm %%SQUIRRELDIR%%/plugins/change_ldappass/locale
 @dirrm %%SQUIRRELDIR%%/plugins/change_ldappass/
-@exec if [ -f %D/%%SQUIRRELDIR%%/config/config.php ]; then %D/%%SQUIRRELDIR%%/config/conf.pl --install-plugin change_ldappass; fi
+@exec if [ -f %D/%%SQUIRRELDIR%%/config/config.php ]; then %D/%%SQUIRRELDIR%%/config/conf.pl --install-plugin %%SQUIRREL_PLUGIN_NAME%%; fi
--- squirrelmail-change_ldappass-plugin-2.1_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jul 11 00:00:21 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114488 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Wed Jul 11 00:09:41 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114488 

From: Alexander Wittig <alexander@wittig.name>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114488: [PATCH] mail/squirrelmail-change_ldappass-plugin:
 take maintainership
Date: Tue, 10 Jul 2007 20:48:29 -0400

 Hi all
 
 Please commit this, I approve.
 
 Alex
 
 
 
 Am 10.07.2007 20:00 Uhr schrieb Edwin Groothuis:
 > Maintainer of mail/squirrelmail-change_ldappass-plugin,
 >
 > Please note that PR ports/114488 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/114488
 >
 >   
 
Responsible-Changed-From-To: miwi->sat 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Fri Jul 13 14:35:35 UTC 2007 
Responsible-Changed-Why:  
Mr.Ports handle these prs for review and committ! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114488 
State-Changed-From-To: open->closed 
State-Changed-By: sat 
State-Changed-When: Fri Jul 20 09:35:40 UTC 2007 
State-Changed-Why:  
Committed with minor tweaks, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114480 
State-Changed-From-To: open->closed 
State-Changed-By: sat 
State-Changed-When: Fri Jul 20 09:35:40 UTC 2007 
State-Changed-Why:  
Committed with minor tweaks, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114482 
State-Changed-From-To: feedback->closed 
State-Changed-By: sat 
State-Changed-When: Fri Jul 20 09:35:40 UTC 2007 
State-Changed-Why:  
Committed with minor tweaks, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114488 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114488: commit references a PR
Date: Fri, 20 Jul 2007 09:35:21 +0000 (UTC)

 sat         2007-07-20 09:35:14 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/squirrelmail-change_ldappass-plugin Makefile pkg-descr 
                                              pkg-plist 
   Log:
   - Pass maintainership to submitter
   - Rework Makefile for easier readability
   - Reformat pkg-descr
   - Bump portrevision (file owner/group changed)
   
   PR:             ports/114488
   Submitted by:   Thomas Abthorpe <thomas@goodking.ca>
   Approved by:    Alexander Wittig <alexander@wittig.name> (maintainer)
   
   Revision  Changes    Path
   1.5       +23 -17    ports/mail/squirrelmail-change_ldappass-plugin/Makefile
   1.2       +3 -5      ports/mail/squirrelmail-change_ldappass-plugin/pkg-descr
   1.4       +3 -3      ports/mail/squirrelmail-change_ldappass-plugin/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
