From lofi@freebsd.org  Fri Jul  6 19:22:58 2007
Return-Path: <lofi@freebsd.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CA0D216A46B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jul 2007 19:22:58 +0000 (UTC)
	(envelope-from lofi@freebsd.org)
Received: from mail-in-07.arcor-online.net (mail-in-07.arcor-online.net [151.189.21.47])
	by mx1.freebsd.org (Postfix) with ESMTP id 410AD13C487
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jul 2007 19:22:58 +0000 (UTC)
	(envelope-from lofi@freebsd.org)
Received: from mail-in-04-z2.arcor-online.net (mail-in-04-z2.arcor-online.net [151.189.8.16])
	by mail-in-07.arcor-online.net (Postfix) with ESMTP id B74B524B3F5;
	Fri,  6 Jul 2007 18:59:48 +0200 (CEST)
Received: from mail-in-04.arcor-online.net (mail-in-04.arcor-online.net [151.189.21.44])
	by mail-in-04-z2.arcor-online.net (Postfix) with ESMTP id A8F1CABAEE;
	Fri,  6 Jul 2007 18:59:48 +0200 (CEST)
Received: from lofi.dyndns.org (dslb-084-061-166-223.pools.arcor-ip.net [84.61.166.223])
	by mail-in-04.arcor-online.net (Postfix) with ESMTP id EA00C1BF397;
	Fri,  6 Jul 2007 18:59:47 +0200 (CEST)
Received: from kiste.my.domain (root@kiste.my.domain [192.168.8.12])
	by lofi.dyndns.org (8.13.8/8.13.3) with ESMTP id l66GxkHb006902
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 6 Jul 2007 18:59:46 +0200 (CEST)
	(envelope-from lofi@freebsd.org)
Received: from kiste.my.domain (lofi@localhost [127.0.0.1])
	by kiste.my.domain (8.13.6/8.13.4) with ESMTP id l66Gxk0T083176;
	Fri, 6 Jul 2007 18:59:46 +0200 (CEST)
	(envelope-from lofi@kiste.my.domain)
Received: (from lofi@localhost)
	by kiste.my.domain (8.13.6/8.13.4/Submit) id l66Gxj1n083175;
	Fri, 6 Jul 2007 18:59:45 +0200 (CEST)
	(envelope-from lofi)
Message-Id: <200707061659.l66Gxj1n083175@kiste.my.domain>
Date: Fri, 6 Jul 2007 18:59:45 +0200 (CEST)
From: Michael Nottebrock <lofi@freebsd.org>
Reply-To: Michael Nottebrock <lofi@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: markus@freebsd.org
Subject: Fix crash on JPEG metadata exceptions in Gwenview
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         114367
>Category:       ports
>Synopsis:       Fix crash on JPEG metadata exceptions in graphics/Gwenview
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    markus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 06 19:30:04 GMT 2007
>Closed-Date:    Wed Aug 08 15:33:49 GMT 2007
>Last-Modified:  Wed Aug  8 15:40:01 GMT 2007
>Originator:     Michael Nottebrock
>Release:        FreeBSD 5.5-RELEASE-p11 i386
>Organization:
>Environment:
System: FreeBSD kiste 5.5-RELEASE-p11 FreeBSD 5.5-RELEASE-p11 #4: Wed May 2 13:59:49 CEST 2007 root@kiste:/usr/obj/usr/src/sys/KISTE-SMP i386


	
>Description:
	Gwenview 1.4.1 as distributed contains a bug that can cause
	crashes when invalid JPEG metadata is encountered.
>How-To-Repeat:
	http://bugs.kde.org/show_bug.cgi?id=138467
>Fix:

	The attached patch fixes the problem (Obtained from: KDE SVN).

--- gwenview.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/graphics/gwenview/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- Makefile	19 May 2007 20:09:29 -0000	1.23
+++ Makefile	6 Jul 2007 16:55:55 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	gwenview
 PORTVERSION=	1.4.1
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	graphics kde
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
Index: files/patch-src-imageutils-jpegcontent.cpp
===================================================================
RCS file: files/patch-src-imageutils-jpegcontent.cpp
diff -N files/patch-src-imageutils-jpegcontent.cpp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-src-imageutils-jpegcontent.cpp	6 Jul 2007 16:55:55 -0000
@@ -0,0 +1,15 @@
+--- src/imageutils/jpegcontent.cpp.orig	Fri Jul  6 18:37:46 2007
++++ src/imageutils/jpegcontent.cpp	Fri Jul  6 18:38:24 2007
+@@ -255,11 +255,11 @@
+ 	Exiv2::Image::AutoPtr image;
+ 	try {
+ 		image = Exiv2::ImageFactory::open((unsigned char*)data.data(), data.size());
++	image->readMetadata();
+ 	} catch (Exiv2::Error&) {
+ 		kdError() << "Could not load image with Exiv2\n";
+ 		return false;
+ 	}
+-	image->readMetadata();
+ 
+ 	d->mExifData = image->exifData();
+ 	d->mComment = QString::fromUtf8( image->comment().c_str() );
--- gwenview.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->markus 
Responsible-Changed-By: lofi 
Responsible-Changed-When: Fri Jul 6 19:35:07 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114367 
State-Changed-From-To: open->closed 
State-Changed-By: lofi 
State-Changed-When: Wed Aug 8 15:33:33 UTC 2007 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114367 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114367: commit references a PR
Date: Wed,  8 Aug 2007 15:33:17 +0000 (UTC)

 lofi        2007-08-08 15:33:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/gwenview    Makefile 
   Added files:
     graphics/gwenview/files patch-src-imageutils-jpegcontent.cpp 
   Log:
   Don't crash on invalid JPEG metadata.
   
   PR: ports/114367
   Approved by: maintainer timeout (4 weeks)
   
   Revision  Changes    Path
   1.25      +1 -1      ports/graphics/gwenview/Makefile
   1.1       +15 -0     ports/graphics/gwenview/files/patch-src-imageutils-jpegcontent.cpp (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
