From hmo@sep.oldach.net  Fri Jul  6 13:22:48 2007
Return-Path: <hmo@sep.oldach.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E60AF16A421
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jul 2007 13:22:48 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250])
	by mx1.freebsd.org (Postfix) with ESMTP id 19F3213C484
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  6 Jul 2007 13:22:46 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (hmo.in-dsl.de [217.197.85.210])
	by rigel.oldach.net (8.14.1/8.14.1/hmo30jul04) with ESMTP id l66CvgHe078844
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 6 Jul 2007 14:57:45 +0200 (CEST)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (localhost [127.0.0.1])
	by sep.oldach.net (8.14.1/8.14.1/hmo26jun05) with ESMTP id l66CvdEW050042
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 6 Jul 2007 14:57:40 +0200 (CEST)
	(envelope-from hmo@sep.oldach.net)
Received: (from hmo@localhost)
	by sep.oldach.net (8.14.1/8.14.1/Submit/hmo26jun05) id l66Cvckl050041;
	Fri, 6 Jul 2007 14:57:38 +0200 (CEST)
	(envelope-from hmo)
Message-Id: <200707061257.l66Cvckl050041@sep.oldach.net>
Date: Fri, 6 Jul 2007 14:57:38 +0200 (CEST)
From: Helge Oldach <ports-www-lynx-jul07@oldach.net>
Reply-To: Helge Oldach <ports-www-lynx-jul07@oldach.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] ports/www/lynx WITHOUT_NLS correction
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jharris@widomaker.com

>Number:         114356
>Category:       ports
>Synopsis:       [patch] ports/www/lynx WITHOUT_NLS correction
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 06 13:30:03 GMT 2007
>Closed-Date:    Thu Jul 26 17:09:48 GMT 2007
>Last-Modified:  Thu Jul 26 17:10:01 GMT 2007
>Originator:     Helge Oldach
>Release:        FreeBSD 6.2-898 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.2-898 FreeBSD 6.2-898 #0: Wed Jul 4 17:23:23 CEST 2007 toor@localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

ports/www/lynx can be compiled with or without NLS, using the
WITHOUT_NLS knob. However, libiconv is unconditionally compiled in,
although it is just superfluous unless NLS is requested. Indeed lynx
runs just fine without libiconv, and actually isn't even linked against
libiconv.

The rather simple patch below fixes the issue.

>How-To-Repeat:

>Fix:

--- Makefile.ctm	Thu Jul  5 17:19:20 2007
+++ Makefile	Fri Jul  6 14:18:09 2007
@@ -19,18 +19,18 @@
 CONFLICTS?=	lynx-ssl* lynx-current*
 
 USE_BZIP2=	yes
-USE_ICONV=	yes
 WRKSRC=		${WRKDIR}/${PORTNAME}2-8-6
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=--with-screen=ncurses --with-zlib --libdir="${L_LIB}" \
 		--enable-nsl-fork --enable-persistent-cookies \
-		--with-curses-dir=/usr --with-libiconv-prefix="${LOCALBASE}"
+		--with-curses-dir=/usr
 
 .if defined(WITHOUT_NLS)
 CONFIGURE_ARGS+=--disable-nls
 .else
+USE_ICONV=	yes
 USE_GETTEXT=	yes
-CONFIGURE_ARGS+=--enable-nls
+CONFIGURE_ARGS+=--enable-nls --with-libiconv-prefix="${LOCALBASE}"
 .endif
 
 .if defined(NO_INET6) || defined(WITHOUT_IPV6)
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 6 13:30:14 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114356 
State-Changed-From-To: feedback->closed 
State-Changed-By: rafan 
State-Changed-When: Thu Jul 26 17:09:46 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114356 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114356: commit references a PR
Date: Thu, 26 Jul 2007 17:09:48 +0000 (UTC)

 rafan       2007-07-26 17:09:41 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/lynx             Makefile 
   Log:
   - Since iconv is used only for i18n stuff, put it under !defined(WITHOUT_NLS)
     section.
   
   PR:             ports/114356
   Submitted by:   Helge Oldach <ports-www-lynx-jul07 at oldach.net>
   Approved by:    maintainer timeout (20 days)
   
   Revision  Changes    Path
   1.125     +3 -3      ports/www/lynx/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
