From nobody@FreeBSD.org  Fri Jun 29 12:45:44 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DAE3216A400
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Jun 2007 12:45:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 8A46813C46C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Jun 2007 12:45:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5TCjird038640
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 29 Jun 2007 12:45:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l5TCjicG038639;
	Fri, 29 Jun 2007 12:45:44 GMT
	(envelope-from nobody)
Message-Id: <200706291245.l5TCjicG038639@www.freebsd.org>
Date: Fri, 29 Jun 2007 12:45:44 GMT
From: Shane Bell <decept0@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [UPDATE] deskutils/basket: update to 1.0.2
X-Send-Pr-Version: www-3.0

>Number:         114126
>Category:       ports
>Synopsis:       [UPDATE] deskutils/basket: update to 1.0.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 29 12:50:12 GMT 2007
>Closed-Date:    Sun Apr 06 23:04:10 UTC 2008
>Last-Modified:  Sun Apr  6 23:10:00 UTC 2008
>Originator:     Shane Bell
>Release:        
>Organization:
>Environment:
>Description:
- Update to 1.0.2

I've disabled building encryption support by default, in the last few versions I've found it very unstable and unreliable (Read: Absolutely broken) and have lost some important data in the process and when it comes to encryption users need to be able to trust on it working correctly. 

I've made encryption support a hidden option (with a warning) and added pinentry-qt as a runtime dependency (No passphrase dialog box without it).
Of course its up to the maintainer to choose whether or not to go along with this, disable support for it outright, or leave things as they are.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN /usr/ports/deskutils/basket/Makefile basket/Makefile
--- /usr/ports/deskutils/basket/Makefile	Sun May 20 14:41:08 2007
+++ basket/Makefile	Sat Jun 30 00:22:02 2007
@@ -5,18 +5,15 @@
 # $FreeBSD: ports/deskutils/basket/Makefile,v 1.25 2007/05/19 20:01:23 flz Exp $
 
 PORTNAME=		basket
-PORTVERSION=		1.0.1
-PORTREVISION=		1
+PORTVERSION=		1.0.2
 CATEGORIES=		deskutils kde
 MASTER_SITES=		http://basket.kde.org/downloads/
 
 MAINTAINER=		markus@FreeBSD.org
 COMMENT=		Desktop organization tool
 
-LIB_DEPENDS+=		gpgme.17:${PORTSDIR}/security/gpgme \
-			gpg-error.0:${PORTSDIR}/security/libgpg-error
-
 USE_KDELIBS_VER=	3
+USE_GETTEXT=		yes	
 USE_GMAKE=		yes
 USE_AUTOTOOLS=		libtool:15
 
@@ -28,6 +25,16 @@
 .else
 PLIST_SUB=	KONTACT="@comment "
 CONFIGURE_ENV+=	DO_NOT_COMPILE="kontact_plugin"
+.endif
+
+# WARNING: Encryption support is unreliable as this time
+# and dataloss may occur. USE AT YOUR OWN RISK.
+.if defined(WITH_GNUPG)
+RUN_DEPENDS+=		pinentry-qt:${PORTSDIR}/security/pinentry-qt
+LIB_DEPENDS+=		gpgme.17:${PORTSDIR}/security/gpgme \
+			gpg-error.0:${PORTSDIR}/security/libgpg-error
+.else
+CONFIGURE_ARGS=--with-encryption=no
 .endif
 
 post-patch:
diff -ruN /usr/ports/deskutils/basket/distinfo basket/distinfo
--- /usr/ports/deskutils/basket/distinfo	Tue Mar 20 14:53:55 2007
+++ basket/distinfo	Fri Jun 15 14:41:30 2007
@@ -1,3 +1,3 @@
-MD5 (basket-1.0.1.tar.gz) = 387ee0249185a2a6d6e9a3a3a358d9d2
-SHA256 (basket-1.0.1.tar.gz) = dbc2342c3a7a1e771f3a85a38016a0a41ccf57a0f3f22e836e8f5c19e11b73eb
-SIZE (basket-1.0.1.tar.gz) = 6041339
+MD5 (basket-1.0.2.tar.gz) = d71c62a56de9cc32ba2633e63e99071f
+SHA256 (basket-1.0.2.tar.gz) = 8c5715f700724b274d162074b601947136d8b71caa36bc3fa36a7b95836b997e
+SIZE (basket-1.0.2.tar.gz) = 6046068
diff -ruN /usr/ports/deskutils/basket/pkg-plist basket/pkg-plist
--- /usr/ports/deskutils/basket/pkg-plist	Sun May 20 14:41:08 2007
+++ basket/pkg-plist	Fri Jun 29 21:08:54 2007
@@ -143,8 +143,6 @@
 %%KONTACT%%share/services/kontact/basket.desktop
 %%KONTACT%%share/services/kontact/basket_v4.desktop
 %%KONTACT%%@dirrmtry share/services/kontact
-@dirrmtry share/locale/pl_PL/LC_MESSAGES
-@dirrmtry share/locale/pl_PL
 @dirrm share/doc/HTML/en/basket
 @dirrmtry share/config/magic
 @dirrmtry share/config


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->markus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jun 29 12:50:20 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114126 
State-Changed-From-To: open->closed 
State-Changed-By: markus 
State-Changed-When: Sun Apr 6 23:01:13 UTC 2008 
State-Changed-Why:  
I have committed a different version using OPTIONS, marking the feature as 
experimental. Data loss didn't occur here during extensive tests with the  
latest version, although the current implementation severly lacks usability. 
Thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=114126 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/114126: commit references a PR
Date: Sun,  6 Apr 2008 23:00:40 +0000 (UTC)

 markus      2008-04-06 23:00:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     deskutils/basket     Makefile distinfo 
   Log:
   - Update to version 1.0.2 [1][2][3]
   - Make GPG support optional and mark it as experimental (default: off) as the
     current implementation is not very usable (inspired by [1])
   - Make OPTIONS handling more readable [2]
   
   PR:             ports/114126 [1]
                   ports/120678 [2]
                   ports/121044 [3]
   Submitted by:   Shane Bell <decept0@gmail.com> [1]
                   Pawel Pekala <c0rn@o2.pl> [2]
                   Yarodin <yarodin@gmail.com> [3]
   
   Revision  Changes    Path
   1.26      +13 -7     ports/deskutils/basket/Makefile
   1.15      +3 -3      ports/deskutils/basket/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
