From umq@ueo.co.jp  Wed Jun 13 11:36:15 2007
Return-Path: <umq@ueo.co.jp>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C66E716A469
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Jun 2007 11:36:15 +0000 (UTC)
	(envelope-from umq@ueo.co.jp)
Received: from msa3-25.plala.or.jp (msa3.plala.or.jp [58.93.251.203])
	by mx1.freebsd.org (Postfix) with ESMTP id 587BE13C4B8
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Jun 2007 11:36:15 +0000 (UTC)
	(envelope-from umq@ueo.co.jp)
Received: from eupheme.kaumoge.org ([121.112.76.77]) by msa3-25.plala.or.jp
          with ESMTP
          id <20070613113614.REIR25212.msa3-25.plala.or.jp@eupheme.kaumoge.org>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Wed, 13 Jun 2007 20:36:14 +0900
Received: from calliope.kaumoge.org (calliope.kaumoge.org [192.168.24.120])
	by eupheme.kaumoge.org (8.12.11/8.12.11/20030713) with ESMTP id l5DBaaDp019425
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Jun 2007 20:36:36 +0900 (JST)
	(envelope-from umq@ueo.co.jp)
Message-Id: <86k5u884sx.wl%umq@ueo.co.jp>
Date: Wed, 13 Jun 2007 20:36:14 +0900
From: Hirohisa Yamaguchi <umq@ueo.co.jp>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [maintainer] mail/dkim-milter prefer shared link to static
X-Send-Pr-Version: 3.113

>Number:         113653
>Category:       ports
>Synopsis:       [maintainer] mail/dkim-milter prefer shared link to static
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 13 11:40:04 GMT 2007
>Closed-Date:    Thu Jun 14 16:47:59 GMT 2007
>Last-Modified:  Thu Jun 14 16:50:05 GMT 2007
>Originator:     Hirohisa Yamaguchi
>Release:        FreeBSD 7.0-CURRENT amd64
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: FreeBSD calliope.****.org 7.0-CURRENT FreeBSD 7.0-CURRENT #8: Mon May 28 02:37:30 JST 2007 root@calliope.****.org:/usr/obj/usr/src/sys/CALLIOPE64 amd64

>Description:
	ache@ has pointed that building milters static by default is
	not preferrable.

>How-To-Repeat:
	# cd ports/mail/dkim-milter
	# make build -DSENDMAIL_MILTER_IN_BASE
	# ldd work/$(make -V DISTNAME)/obj.$(uname -s).$(uname -r).$(uname -m)/dk-filter/dk-filter
	ldd: work/dk-milter-0.6.0/obj.FreeBSD.7.0-CURRENT.amd64/dk-filter/dk-filter: not a dynamic executable
>Fix:

	The patch follows

diff -p -u ports.org/mail/dkim-milter/Makefile ports/mail/dkim-milter/Makefile
--- ports.org/mail/dkim-milter/Makefile	Sat May 26 07:11:33 2007
+++ ports/mail/dkim-milter/Makefile	Wed Jun 13 19:32:28 2007
@@ -14,6 +14,7 @@
 
 PORTNAME=	dkim-milter
 PORTVERSION=	1.0.0
+PORTREVISION=	1
 CATEGORIES=	mail
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -43,7 +44,7 @@ BUILD_DEPENDS+=	${LOCALBASE}/lib/libmilt
 .endif
 .endif
 
-.if defined(WITH_SENDMAIL_STATIC_MILTER) || !defined(SENDMAIL_WITH_SHARED_MILTER)
+.if defined(WITH_SENDMAIL_STATIC_MILTER) && !defined(SENDMAIL_WITH_SHARED_MILTER)
 SITE+=		-e '\|-static|s|%%STATIC%%||g'
 .else
 SITE+=		-e '\|-static|s|%%STATIC%%|dnl |g'
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: ache 
State-Changed-When: Thu Jun 14 16:47:40 UTC 2007 
State-Changed-Why:  
Committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113653 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/113653: commit references a PR
Date: Thu, 14 Jun 2007 16:45:36 +0000 (UTC)

 ache        2007-06-14 16:45:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/dkim-milter     Makefile 
   Log:
   Don't build it static by default
   
   PR:             113653
   Submitted by:   Hirohisa Yamaguchi <umq@ueo.co.jp> (maintainer)
   
   Revision  Changes    Path
   1.24      +2 -1      ports/mail/dkim-milter/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
