From nobody@FreeBSD.org  Sun Jun 10 10:13:03 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D28D216A469
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2007 10:13:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id AA5C113C45A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2007 10:13:03 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5AAD3sP044409
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 10 Jun 2007 10:13:03 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l5AAD3Pc044408;
	Sun, 10 Jun 2007 10:13:03 GMT
	(envelope-from nobody)
Message-Id: <200706101013.l5AAD3Pc044408@www.freebsd.org>
Date: Sun, 10 Jun 2007 10:13:03 GMT
From: Ighighi<ighighi@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]: Some errors in www/lynx-* with devel/ncurses installed
X-Send-Pr-Version: www-3.0

>Number:         113515
>Category:       ports
>Synopsis:       [PATCH]: Some errors in www/lynx-* with devel/ncurses installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 10 10:20:00 GMT 2007
>Closed-Date:    Sun Jun 17 08:34:42 GMT 2007
>Last-Modified:  Sun Jun 17 08:40:05 GMT 2007
>Originator:     Ighighi
>Release:        6.2-STABLE
>Organization:
>Environment:
FreeBSD orion 6.2-STABLE FreeBSD 6.2-STABLE #4: Sat Jun  2 05:22:26 VET 2007     root@orion:/usr/obj/usr/src/sys/CUSTOM  i386
>Description:
www/lynx-ssl fails to compile with devel/ncurses installed.
The respective port versions as of this time of writing are:
lynx-ssl-2.8.6_5,1
ncurses-5.6_1

The error message is as follows:
+++++ BEGIN ERROR MESSAGE

cc  -D_BSD_TYPES -D__BSD_VISIBLE -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -DHAVE_CONFIG_H   -DLOCALEDIR=\"/usr/local/share/locale\"  -I.  -I..  -Ichrtrans  -I./chrtrans  -I..  -I../src  -I../WWW/Library/Implementation    -O -pipe -I/usr/local/include -c ./LYStrings.c
./LYStrings.c: In function `expand_tiname':
./LYStrings.c:953: error: `strnames' undeclared (first use in this function)
./LYStrings.c:953: error: (Each undeclared identifier is reported only once
./LYStrings.c:953: error: for each function it appears in.)
./LYStrings.c:954: error: `strfnames' undeclared (first use in this function)
./LYStrings.c:955: error: `cur_term' undeclared (first use in this function)
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6/src.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl/work/lynx2-8-6.
*** Error code 1

Stop in /usr/ports/www/lynx-ssl.

+++++ END ERROR MESSAGE

A little inspection revealed to me that the configure mechanism in lynx is
accessing the /usr/local/include/ncurses/* files installed by devel/ncurses
as a side-effect of "-I/usr/local/include", as shown by a diff on the output
of "make configure" when devel/ncurses is available and unavailable, resp.

124c124
< checking for ncurses header in include-path... ncurses/ncurses.h
---
> checking for ncurses header in include-path... curses.h

It is worth noting that www/lynx-current builds perfectly, maybe because their
configure mechanism was corrected.

In my opinion there should be a knob in www/lynx* to allow optional linkage with
devel/ncurses, at least for www/lynx-current since the latter always tries to
use the version in ports first, unlike www/lynx and www/lynx-ssl, thus making
devel/ncurses a dependency.
>How-To-Repeat:

>Fix:
The attached patch deletes the following line in /usr/ports/www/lynx-ssl/work/lynx2-8-6/config.hin

#undef HAVE_NCURSES_NCURSES_H  /* defined if we include <ncurses/ncurses.h> */


Patch attached with submission follows:

--- config.hin.orig	Mon Oct  2 15:56:53 2006
+++ config.hin	Sun Jun 10 05:18:11 2007
@@ -102,7 +102,6 @@
 #undef HAVE_NCURSESW_NCURSES_H	/* defined if we include <ncursesw/ncurses.h> */
 #undef HAVE_NCURSESW_TERM_H	/* have <ncursesw/term.h> */
 #undef HAVE_NCURSES_H		/* defined if we include <ncurses.h> */
-#undef HAVE_NCURSES_NCURSES_H	/* defined if we include <ncurses/ncurses.h> */
 #undef HAVE_NCURSES_TERM_H	/* have <ncurses/term.h> */
 #undef HAVE_NEWPAD
 #undef HAVE_NEWTERM


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->rafan 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Jun 10 10:20:08 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113515 
State-Changed-From-To: open->closed 
State-Changed-By: rafan 
State-Changed-When: Sun Jun 17 08:34:41 UTC 2007 
State-Changed-Why:  
Committed with another approach. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113515 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/113515: commit references a PR
Date: Sun, 17 Jun 2007 08:34:33 +0000 (UTC)

 rafan       2007-06-17 08:34:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/lynx             Makefile 
   Log:
   - Force lynx to pick up ncurses from base. This fixes build when
     1) devel/ncurses is installed, and 2) use OpenSSL from ports.
     In that case, lynx picks up ncurses/ncurses.h which is from ports
     and somehow it does not include term.h
   
   PR:           ports/113515
   Reported by:  Ighighi <ighighi at gmail.com>
   Approved by:  Jason Harris <jharris at widomaker.com> (maintainer)
   
   Revision  Changes    Path
   1.120     +1 -1      ports/www/lynx/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
