From sarumaru@sachiko.yamayuri.org  Sat May 26 16:42:59 2007
Return-Path: <sarumaru@sachiko.yamayuri.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 57F0C16A469
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 May 2007 16:42:59 +0000 (UTC)
	(envelope-from sarumaru@sachiko.yamayuri.org)
Received: from sachiko.yamayuri.org (yumi.yamayuri.org [218.45.22.23])
	by mx1.freebsd.org (Postfix) with ESMTP id 83FBE13C45E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 26 May 2007 16:42:58 +0000 (UTC)
	(envelope-from sarumaru@sachiko.yamayuri.org)
Received: from sachiko.yamayuri.org (localhost [127.0.0.1])
	by sachiko.yamayuri.org (8.14.1/8.14.1) with ESMTP id l4QGOD9a065378
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 May 2007 01:24:13 +0900 (JST)
	(envelope-from sarumaru@sachiko.yamayuri.org)
Received: (from sarumaru@localhost)
	by sachiko.yamayuri.org (8.14.1/8.14.1/Submit) id l4QGOBKU065377;
	Sun, 27 May 2007 01:24:11 +0900 (JST)
	(envelope-from sarumaru)
Message-Id: <200705261624.l4QGOBKU065377@sachiko.yamayuri.org>
Date: Sun, 27 May 2007 01:24:11 +0900 (JST)
From: Yoshihiko Sarumaru <sarumaru@sachiko.yamayuri.org>
Reply-To: Yoshihiko Sarumaru <sarumaru@sachiko.yamayuri.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: update port: x11/xdm: SSH_AUTH_SOCK would not set under using with pam_ssh
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         113031
>Category:       ports
>Synopsis:       update port: x11/xdm: SSH_AUTH_SOCK would not set under using with pam_ssh
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 26 16:50:02 GMT 2007
>Closed-Date:    Thu Jun 07 20:17:52 GMT 2007
>Last-Modified:  Thu Jun 07 20:17:52 GMT 2007
>Originator:     Yoshihiko Sarumaru
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD sachiko.yamayuri.org 6.2-STABLE FreeBSD 6.2-STABLE #1: Wed May 2 00:53:20 JST 2007 sarumaru@sachiko.yamayuri.org:/usr/obj/usr/src/sys/VGN-TX92S i386


	
>Description:
	I have been used xorg 6.9 on my FreeBSD box.
	Until I upgraded it to 7.2, after pam_ssh authentication, SSH_AUTH_SOCK 
	environmental variable was inhelited to all the application executed by
	~/.xsession (typically xterm).
	But from xorg 7.2, SSH_AUTH_SOCK will not be set even though ssh-agent
	is launched by xdm via PAM subsystem.

	You can access more detail at:
	https://bugs.freedesktop.org/show_bug.cgi?id=11020

>How-To-Repeat:
	enable pam_ssh for xdm, then restaert xdm and login with SSH passphrase.
>Fix:
	This patch was provided by an xorg developer (see above Bugzilla URL)
	and already committed to the main line.

--- session.c	Fri Feb  2 10:00:51 2007
+++ session.c	Fri May 25 23:06:58 2007
@@ -627,6 +627,8 @@
 	    return (0);
 	}
 #endif   /* QNX4 doesn't support multi-groups, no initgroups() */
+#endif /* !HAS_SETUSERCONTEXT */
+
 #ifdef USE_PAM
 	if (pamh) {
 	    long i;
@@ -647,6 +649,8 @@
 
 	}
 #endif
+
+#ifndef HAS_SETUSERCONTEXT
 	if (setuid(verify->uid) < 0) {
 	    LogError ("setuid %d (user \"%s\") failed, errno=%d\n",
 		     verify->uid, name, errno);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat May 26 16:50:08 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113031 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/113031: commit references a PR
Date: Thu,  7 Jun 2007 19:49:09 +0000 (UTC)

 lesi        2007-06-07 19:48:59 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/xdm              Makefile 
   Added files:
     x11/xdm/files        patch-session.c 
   Log:
   - Restore inheriting environment from login.conf by restoring patch
     from x11/xorg-clients [1]
   - Restore inheriting SSH_AUTH_SOCK after pam_ssh authentication
     (https://bugs.freedesktop.org/show_bug.cgi?id=11020) [2]
   
   PR:             ports/112932 [1], ports/113031 [2]
   Obtained from:  X.org git [2]
   
   Revision  Changes    Path
   1.2       +1 -1      ports/x11/xdm/Makefile
   1.1       +43 -0     ports/x11/xdm/files/patch-session.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: lesi 
State-Changed-When: Thu Jun 7 20:17:33 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=113031 
>Unformatted:
