From nobody@FreeBSD.org  Wed May  2 20:01:00 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A07E816A403
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 May 2007 20:01:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 9143313C44B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 May 2007 20:01:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l42K10G5011380
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 May 2007 20:01:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l42JtxhZ010608;
	Wed, 2 May 2007 19:55:59 GMT
	(envelope-from nobody)
Message-Id: <200705021955.l42JtxhZ010608@www.freebsd.org>
Date: Wed, 2 May 2007 19:55:59 GMT
From: Antero Hytnen<anzah1@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] games/widelands doesn't compile with gcc 3.4.6
X-Send-Pr-Version: www-3.0

>Number:         112369
>Category:       ports
>Synopsis:       [PATCH] games/widelands doesn't compile with gcc 3.4.6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 02 20:10:03 GMT 2007
>Closed-Date:    Fri Jun 22 11:32:00 GMT 2007
>Last-Modified:  Fri Jun 22 11:32:00 GMT 2007
>Originator:     Antero Hytnen
>Release:        6.2-RELEASE
>Organization:
>Environment:
FreeBSD sylvesteri.local 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Sat Jan 27 02:56:19 EET 2007     root@sylvesteri.local:/usr/obj/usr/src/sys/SYLVESTERI  i386
>Description:
games/widelands is not compatible with gcc 3.4.6 and doesn't compile with it. 
>How-To-Repeat:
Compile games/widelands
>Fix:
Force using gcc 3.3

Patch attached with submission follows:

--- Makefile.orig	Wed May  2 22:35:59 2007
+++ Makefile	Wed May  2 00:50:57 2007
@@ -23,6 +23,7 @@
 USE_PYTHON_BUILD=	2.4+
 USE_GETTEXT=	yes
 USE_SDL=	mixer image net ttf
+USE_GCC=	3.3
 
 SCONS_ARGS=	CXXFLAGS="${CXXFLAGS}" LINKFLAGS="${LDFLAGS}" \
 		CPPPATH=${LOCALBASE}/include LIBPATH=${LOCALBASE}/lib \

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed May 2 20:10:11 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112369 

From: Bartosz Fabianowski <freebsd@chillt.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/112369: [PATCH] games/widelands doesn't compile with gcc
 3.4.6
Date: Wed, 02 May 2007 23:47:43 +0200

 It compiles with gcc 3.4.6 for me. The problem must be somewhere else. 
 Please provide more information about the error your get.

From: "=?ISO-8859-1?Q?Antero_Hyt=F6nen?=" <anzah1@gmail.com>
To: bug-followup@FreeBSD.org, anzah1@gmail.com
Cc:  
Subject: Re: ports/112369: [PATCH] games/widelands doesn't compile with gcc 3.4.6
Date: Sat, 5 May 2007 14:56:39 +0300

 I disabled some options that I had enabled in make.conf (ccache and
 some compiler settings). I still get following errors when I try to
 compile widelands with the default Makefile(I'm not sure which of
 these are non fatal errors, so I'll paste some extra):
 
  In file included from src/editor_game_base.h:28,
                  from src/interactive_base.h:23,
                  from src/editor/editorinteractive.h:32,
                  from src/editor/ui_menus/editor_event_menu.cc:24:
 src/building.h: In member function `const std::string&
 Building::descname() const':
 src/building.h:163: warning: `descname' is deprecated (declared at
 src/building.h:59)
 src/building.h: In member function `const char* Building::get_descname() const':
 src/building.h:164: warning: `descname' is deprecated (declared at
 src/building.h:59)
 src/editor/ui_menus/editor_event_menu.cc: In member function `void
 Editor_Event_Menu::update()':
 src/editor/ui_menus/editor_event_menu.cc:222: error: invalid use of
 undefined type `struct Event'
 src/event_referencer.h:23: error: forward declaration of `struct Event'
 src/editor/ui_menus/editor_event_menu.cc:223: error: invalid use of
 undefined type `struct Event'
 src/event_referencer.h:23: error: forward declaration of `struct Event'
 src/editor/ui_menus/editor_event_menu.cc: In member function `void
 Editor_Event_Menu::clicked_del_event()':
 src/editor/ui_menus/editor_event_menu.cc:266: error: expected
 initializer before '&' token
 src/editor/ui_menus/editor_event_menu.cc:268: error:
 `event_referencers' was not declared in this scope
 src/editor/ui_menus/editor_event_menu.cc:269: error: invalid use of
 undefined type `const struct Event'
 src/event_referencer.h:23: error: forward declaration of `const struct Event'
 src/editor/ui_menus/editor_event_menu.cc:275: error: `struct
 Event::EventReferencerMap' has not been declared
 src/editor/ui_menus/editor_event_menu.cc:275: error: `const_iterator'
 was not declared in this scope
 src/editor/ui_menus/editor_event_menu.cc:275: error: expected `;'
 before "event_referencers_end"
 src/editor/ui_menus/editor_event_menu.cc:278: error: `struct
 Event::EventReferencerMap' has not been declared
 src/editor/ui_menus/editor_event_menu.cc:278: error: expected `;' before "it"
 src/editor/ui_menus/editor_event_menu.cc:280: error: `it' was not
 declared in this scope
 src/editor/ui_menus/editor_event_menu.cc:280: error:
 `event_referencers_end' was not declared in this scope
 src/editor/ui_menus/editor_event_menu.cc: In member function `void
 Editor_Event_Menu::clicked_edit_event()':
 src/editor/ui_menus/editor_event_menu.cc:295: error: invalid use of
 undefined type `struct Event'
 src/event_referencer.h:23: error: forward declaration of `struct Event'
 scons: *** [build/native-release/editor/ui_menus/editor_event_menu.o] Error 1
 scons: building terminated because of errors.
 *** Error code 2
 
 Stop in /usr/ports/games/widelands.
 ** Command failed [exit code 1]: /usr/bin/script -qa
 /tmp/portupgrade.49954.0 env UPGRADE_TOOL=portupgrade
 UPGRADE_PORT=widelands-b10 UPGRADE_PORT_VER=b10 make
 ** Fix the problem and try again.
 ** Listing the failed packages (*:skipped / !:failed)
         ! games/widelands (widelands-b10)       (bad C++ code)
 --->  Packages processed: 0 done, 0 ignored, 0 skipped and 1 failed
 
 
 Though if I use GCC 3.3, I still can't actually launch the game, it
 just dies with following error:
 
 /usr/libexec/ld-elf.so.1: Undefined symbol
 "_ZNSs20_S_empty_rep_storageE" referenced from COPY relocation in
 widelands

From: Bartosz Fabianowski <freebsd@chillt.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/112369: [PATCH] games/widelands doesn't compile with gcc
 3.4.6
Date: Sun, 06 May 2007 16:36:19 +0200

 It seems to me that the build is picking up an event.h somewhere in your 
 system include path instead of the one in 
 /usr/ports/games/widelands/work/widelands/src. If you have an up to date 
 locate database, please post the output of the following command:
 
 locate /event.h
 
 Should your locate not be up to date, you can use find instead:
 
 find / -name event.h
Responsible-Changed-From-To: freebsd-ports-bugs->mm 
Responsible-Changed-By: mm 
Responsible-Changed-When: Thu Jun 14 06:47:02 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112369 

From: Bartosz Fabianowski <freebsd@chillt.de>
To: bug-followup@FreeBSD.org,  anzah1@gmail.com
Cc:  
Subject: Re: ports/112369: [PATCH] games/widelands doesn't compile with gcc
 3.4.6
Date: Fri, 15 Jun 2007 19:48:40 +0100

 Please do not commit anything based on this pr. The proper fix can be 
 found in ports/113243, which has been stuck for a while, waiting for 
 vanilla to commit the patches.

From: "=?ISO-8859-1?Q?Antero_Hyt=F6nen?=" <anzah1@gmail.com>
To: bug-followup@FreeBSD.org, anzah1@gmail.com
Cc:  
Subject: Re: ports/112369: [PATCH] games/widelands doesn't compile with gcc 3.4.6
Date: Mon, 18 Jun 2007 22:51:04 +0300

 Damn spam filters.
 
 I found the event.h which was used for the build:
 
 /usr/local/include/event.h
 
 It's installed by libevent. Everything compiled fine when I
 deinstalled it. Luckily I don't need anything that installs it as a
 dependency.
State-Changed-From-To: feedback->closed 
State-Changed-By: mm 
State-Changed-When: Fri Jun 22 11:30:09 UTC 2007 
State-Changed-Why:  
Superseded by ports/113243 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112369 
>Unformatted:
