From mad@madpilot.net  Tue May  1 18:23:05 2007
Return-Path: <mad@madpilot.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B530B16A402
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 May 2007 18:23:05 +0000 (UTC)
	(envelope-from mad@madpilot.net)
Received: from smtpi2.ngi.it (smtpi2.ngi.it [88.149.128.21])
	by mx1.freebsd.org (Postfix) with ESMTP id E41F913C487
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 May 2007 18:23:02 +0000 (UTC)
	(envelope-from mad@madpilot.net)
Received: from madpilot.net (81-174-34-189.f5.ngi.it [81.174.34.189])
	by smtpi2.ngi.it (8.13.8/8.13.8) with SMTP id l41IN0AY025694
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 1 May 2007 20:23:01 +0200
Received: (qmail 52354 invoked from network); 1 May 2007 18:23:00 -0000
Received: from wedge.madpilot.net (192.168.13.11)
  by madpilot.net with SMTP; 1 May 2007 18:23:00 -0000
Received: from wedge.madpilot.net (localhost.madpilot.net [127.0.0.1])
	by wedge.madpilot.net (8.14.1/8.14.1) with ESMTP id l41IMUGd003961;
	Tue, 1 May 2007 20:22:30 +0200 (CEST)
	(envelope-from mad@wedge.madpilot.net)
Received: (from mad@localhost)
	by wedge.madpilot.net (8.14.1/8.14.1/Submit) id l41IMUv1003960;
	Tue, 1 May 2007 20:22:30 +0200 (CEST)
	(envelope-from mad)
Message-Id: <200705011822.l41IMUv1003960@wedge.madpilot.net>
Date: Tue, 1 May 2007 20:22:30 +0200 (CEST)
From: Guido Falsi <mad@madpilot.net>
Reply-To: Guido Falsi <mad@madpilot.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Paul Beard <paulbeard@gmail.com>
Subject: [maintainer-update] fix build when readline-5.2 is installed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         112321
>Category:       ports
>Synopsis:       [maintainer-update] comms/obexapp - fix build when readline-5.2 is installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 01 18:30:04 GMT 2007
>Closed-Date:    Fri May 25 11:07:59 GMT 2007
>Last-Modified:  Fri May 25 11:07:59 GMT 2007
>Originator:     Guido Falsi
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD wedge.madpilot.net 6.2-STABLE FreeBSD 6.2-STABLE #33: Fri Apr 20 18:08:23 CEST 2007 root@wedge.madpilot.net:/usr/obj/usr/src/sys/WEDGE i386

>Description:

Port fails to build when the readline 5.2 port is installed due to a conflict in include files. Following patch fixes that.

Reported By: Paul Beard

>How-To-Repeat:
>Fix:

diff -ruN obexapp.old/files/patch-Makefile obexapp/files/patch-Makefile
--- obexapp.old/files/patch-Makefile	Tue May  1 14:11:04 2007
+++ obexapp/files/patch-Makefile	Tue May  1 14:12:20 2007
@@ -1,5 +1,5 @@
 --- Makefile.orig	Mon Apr 23 20:29:18 2007
-+++ Makefile	Wed Apr 25 20:41:52 2007
++++ Makefile	Tue May  1 14:11:37 2007
 @@ -1,8 +1,10 @@
  # $Id: Makefile,v 1.11 2007/04/23 18:29:18 max Exp $
  # $FreeBSD$
@@ -12,4 +12,13 @@
 +MANDIR=		${PREFIX}/man/man
  PROG=		obexapp
  MAN1=		obexapp.1
+ 
+@@ -13,7 +15,7 @@
+ 
+ DEBUG_FLAGS=	-g
+ 
+-CFLAGS+=	-I/usr/local/include \
++CFLAGS+=	-idirafter /usr/local/include \
+ 		-I/usr/local/include/openobex \
+ 		-fno-strict-aliasing
  
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mm  
Responsible-Changed-By: mm 
Responsible-Changed-When: Thu May 3 11:16:43 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112321 

From: Martin Matuska <mm@FreeBSD.org>
To: bug-followup@FreeBSD.org,  mad@madpilot.net
Cc:  
Subject: Re: ports/112321: [maintainer-update] comms/obexapp - fix build when
 readline-5.2 is installed
Date: Thu, 03 May 2007 14:42:08 +0200

 This is a multi-part message in MIME format.
 --------------080805020309070000070503
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 Hello, I have found out that your port was not LOCALBASE compliant and
 the NO_INSTALL_MANPAGES knob was missing.
 With the CFLAGS you are adding, the replacement part in Makefile is not
 required anymore. I have added a NO_WERROR option to MAKE_ENV so that
 obexapp builds on FreeBSD 5.5.
 
 Updated patch is attached. If you agree, I will commit it.
 
 I have checked the updated patch on tinderbox.
 
 Logs:
 http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log
 http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log
 http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log
 http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log
 http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log
 http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log
 
 
 --------------080805020309070000070503
 Content-Type: text/plain;
  name="obexapp-1.4.6_1.diff"
 Content-Transfer-Encoding: base64
 Content-Disposition: inline;
  filename="obexapp-1.4.6_1.diff"
 
 SW5kZXg6IHBvcnRzL2NvbW1zL29iZXhhcHAvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
 ZmlsZTogL2hvbWUvcGN2cy9wb3J0cy9jb21tcy9vYmV4YXBwL01ha2VmaWxlLHYKcmV0cmll
 dmluZyByZXZpc2lvbiAxLjE0CmRpZmYgLXUgLXIxLjE0IE1ha2VmaWxlCi0tLSBwb3J0cy9j
 b21tcy9vYmV4YXBwL01ha2VmaWxlCTI2IEFwciAyMDA3IDE5OjQzOjU5IC0wMDAwCTEuMTQK
 KysrIHBvcnRzL2NvbW1zL29iZXhhcHAvTWFrZWZpbGUJMyBNYXkgMjAwNyAxMjozMzo0MiAt
 MDAwMApAQCAtNyw2ICs3LDcgQEAKIAogUE9SVE5BTUU9CW9iZXhhcHAKIFBPUlRWRVJTSU9O
 PQkxLjQuNgorUE9SVFJFVklTSU9OPQkxCiBDQVRFR09SSUVTPQljb21tcyBuZXQKIE1BU1RF
 Ul9TSVRFUz0JaHR0cDovL3d3dy5nZW9jaXRpZXMuY29tL21fZXZtZW5raW4vCiAKQEAgLTE4
 LDE0ICsxOSwyMSBAQAogV1JLU1JDPQkJJHtXUktESVJ9LyR7UE9SVE5BTUV9CiAKIFVTRV9J
 Q09OVj0JeWVzCitQTElTVF9GSUxFUz0JYmluL29iZXhhcHAKKworLmlmICFkZWZpbmVkKE5P
 X0lOU1RBTExfTUFOUEFHRVMpCiBNQU4xPQkJb2JleGFwcC4xCiBNQU5DT01QUkVTU0VEPQl5
 ZXMKLVBMSVNUX0ZJTEVTPQliaW4vb2JleGFwcAorLmVsc2UKK01BS0VfRU5WKz0JTk9fTUFO
 PXllcworLmVuZGlmCisKK01BS0VfRU5WKz0JTk9fV0VSUk9SPXllcwogCiAuaW5jbHVkZSA8
 YnNkLnBvcnQucHJlLm1rPgogCiAuaWYgJHtPU1ZFUlNJT059IDwgNTAyMTAxCi1JR05PUkU9
 CQlOZWVkcyA1LnggZnJvbSAyMCBKYW4gMjAwNCBvciBsYXRlciAoc2RwZCkKK0lHTk9SRT0J
 CW5lZWRzIDUueCBmcm9tIDIwIEphbiAyMDA0IG9yIGxhdGVyIChzZHBkKQogLmVuZGlmCiAK
 IC5pZiAke09TVkVSU0lPTn0gPCA1MDIxMjEKQEAgLTMzLDggKzQxLDQgQEAKIE9OTFlfRk9S
 X0FSQ0hTPQlpMzg2CiAuZW5kaWYKIAotcG9zdC1wYXRjaDoKLQlAJHtGSU5EfSAke1dSS1NS
 Q30gLW5hbWUgXCouYyB8ICR7WEFSR1N9IFwKLQkJJHtSRUlOUExBQ0VfQ01EfSAtZSAnc3w8
 c2RwLmg+fDwvdXNyL2luY2x1ZGUvc2RwLmg+fCcKLQogLmluY2x1ZGUgPGJzZC5wb3J0LnBv
 c3QubWs+CkluZGV4OiBwb3J0cy9jb21tcy9vYmV4YXBwL2ZpbGVzL3BhdGNoLU1ha2VmaWxl
 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL3BjdnMvcG9ydHMvY29tbXMvb2JleGFw
 cC9maWxlcy9wYXRjaC1NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44CmRpZmYg
 LXUgLXIxLjggcGF0Y2gtTWFrZWZpbGUKLS0tIHBvcnRzL2NvbW1zL29iZXhhcHAvZmlsZXMv
 cGF0Y2gtTWFrZWZpbGUJMjYgQXByIDIwMDcgMTk6NDM6NTkgLTAwMDAJMS44CisrKyBwb3J0
 cy9jb21tcy9vYmV4YXBwL2ZpbGVzL3BhdGNoLU1ha2VmaWxlCTMgTWF5IDIwMDcgMTI6MzM6
 NDIgLTAwMDAKQEAgLTEsMTUgKzEsMjcgQEAKIC0tLSBNYWtlZmlsZS5vcmlnCU1vbiBBcHIg
 MjMgMjA6Mjk6MTggMjAwNwotKysrIE1ha2VmaWxlCVdlZCBBcHIgMjUgMjA6NDE6NTIgMjAw
 NwotQEAgLTEsOCArMSwxMCBAQAotICMgJElkOiBNYWtlZmlsZSx2IDEuMTEgMjAwNy8wNC8y
 MyAxODoyOToxOCBtYXggRXhwICQKLSAjICRGcmVlQlNEJAorKysrIE1ha2VmaWxlCVRodSBN
 YXkgIDMgMTM6NDg6MTkgMjAwNworQEAgLTMsNCArMyw3IEBACiAgCiAtQklORElSPQkJL3Vz
 ci9sb2NhbC9iaW4KIC1NQU5ESVI9CQkvdXNyL2xvY2FsL21hbi9tYW4KICtQUkVGSVg/PQkv
 dXNyL2xvY2FsCisrTE9DQUxCQVNFPz0JL3Vzci9sb2NhbAogKwogK0JJTkRJUj0JCSR7UFJF
 RklYfS9iaW4KICtNQU5ESVI9CQkke1BSRUZJWH0vbWFuL21hbgogIFBST0c9CQlvYmV4YXBw
 Ci0gTUFOMT0JCW9iZXhhcHAuMQorQEAgLTE1LDQgKzE4LDQgQEAKICAKKy1DRkxBR1MrPQkt
 SS91c3IvbG9jYWwvaW5jbHVkZSBcCistCQktSS91c3IvbG9jYWwvaW5jbHVkZS9vcGVub2Jl
 eCBcCisrQ0ZMQUdTKz0JLWlkaXJhZnRlciAke0xPQ0FMQkFTRX0vaW5jbHVkZSBcCisrCQkt
 SSR7TE9DQUxCQVNFfS9pbmNsdWRlL29wZW5vYmV4IFwKKyAJCS1mbm8tc3RyaWN0LWFsaWFz
 aW5nCitAQCAtMjAsMyArMjMsMyBAQAorIERQQUREPQkJJHtMSUJCTFVFVE9PVEh9ICR7TElC
 U0RQfSAke0xJQkJTRFhNTH0gJHtMSUJSRUFETElORX0KKy1MREFERD0JCS1ML3Vzci9saWIg
 LUwvdXNyL2xvY2FsL2xpYiBcCisrTERBREQ9CQktTC91c3IvbGliIC1MJHtMT0NBTEJBU0V9
 L2xpYiBcCisgCQktbGJsdWV0b290aCAtbHNkcCAtbG9wZW5vYmV4IC1sYnNkeG1sIC1scmVh
 ZGxpbmUgLWxpY29udgorQEAgLTI0LDIgKzI3IEBACisgLmluY2x1ZGUgPGJzZC5wcm9nLm1r
 PgorLQo=
 --------------080805020309070000070503--
State-Changed-From-To: open->feedback  
State-Changed-By: mm 
State-Changed-When: Thu May 3 13:11:09 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112321 

From: Guido Falsi <mad@madpilot.net>
To: Martin Matuska <mm@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/112321: [maintainer-update] comms/obexapp - fix build
	when readline-5.2 is installed
Date: Thu, 3 May 2007 20:50:15 +0200

 On Thu, May 03, 2007 at 02:42:08PM +0200, Martin Matuska wrote:
 > Hello, I have found out that your port was not LOCALBASE compliant and
 > the NO_INSTALL_MANPAGES knob was missing.
 > With the CFLAGS you are adding, the replacement part in Makefile is not
 > required anymore. I have added a NO_WERROR option to MAKE_ENV so that
 > obexapp builds on FreeBSD 5.5.
 > 
 > Updated patch is attached. If you agree, I will commit it.
 > 
 > I have checked the updated patch on tinderbox.
 > 
 > Logs:
 > http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log
 > http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log
 > http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log
 > http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log
 > http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log
 > http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log
 > 
 
 Very good work, thank you for your help!
 
 I looke at the patch and tried it and it's ok for me. The logs you
 provide are even better proof for that.
 
 Ok to commit. And thank you again!
 
 -- 
 Guido Falsi <mad@madpilot.net>
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Sat May 12 10:16:45 UTC 2007 
State-Changed-Why:  
Maintainer approved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112321 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/112321: commit references a PR
Date: Fri, 25 May 2007 10:50:53 +0000 (UTC)

 mm          2007-05-25 10:50:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     comms/obexapp        Makefile 
     comms/obexapp/files  patch-Makefile 
   Log:
   - counterpatch proposed by mm@ (maintainer approved)
   - fixed build on i386 if devel/readline installed
   - fixed build on FreeBSD 5.5
   - added NO_INSTALL_MANPAGES knob
   
   PR:             ports/112321
   Approved by:    garga (mentor)
   
   Revision  Changes    Path
   1.15      +10 -6     ports/comms/obexapp/Makefile
   1.9       +17 -5     ports/comms/obexapp/files/patch-Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: mm 
State-Changed-When: Fri May 25 11:00:50 UTC 2007 
State-Changed-Why:  
Commited with modifications, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=112321 
>Unformatted:
