From nobody@FreeBSD.org  Tue Apr 10 22:38:01 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3BEF816A403
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2007 22:38:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 2F2B113C45D
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2007 22:38:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l3AMc0vk084061
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 10 Apr 2007 22:38:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l3AMWxwS069260;
	Tue, 10 Apr 2007 22:32:59 GMT
	(envelope-from nobody)
Message-Id: <200704102232.l3AMWxwS069260@www.freebsd.org>
Date: Tue, 10 Apr 2007 22:32:59 GMT
From: "Brian A. Seklecki"<bseklecki@collaborativefusion.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: syslog-ng2 default configuration file path
X-Send-Pr-Version: www-3.0

>Number:         111462
>Category:       ports
>Synopsis:       syslog-ng2 default configuration file path
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    linimon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 10 22:40:01 GMT 2007
>Closed-Date:    Sat Jul 28 22:28:30 GMT 2007
>Last-Modified:  Sat Jul 28 22:30:02 GMT 2007
>Originator:     Brian A. Seklecki
>Release:        FreeBSD bdb0 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3
>Organization:
Collaborative Fusion, Inc.
>Environment:
FreeBSD bdb0 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p
>Description:
Among many other things, syslog-ng changed the default configuration file path determination method between 2.0.0 and 2.0.3.  This was missed by the port maintainer (an easy mistake if you set $syslog_ng_flags="-f /alt/file.conf"

seklecki@ravage:/tmp$ diff -u syslog-ng-2.0.0/syslog-ng.spec.bb \
syslog-ng-2.0.2/syslog-ng.spec.bb | grep -i conf


-./configure --prefix=/ --mandir=/usr/share/man --infodir=/usr/share/info \
-  --sysconfdir=/etc

+./configure --prefix=%{prefix} --mandir=%{_mandir} --infodir=%{prefix}/share/info \
+  --sysconfdir=/etc/syslog-ng

-------------------------------

>How-To-Repeat:
Portupgrade to 2.0.2
>Fix:

Regardless of when/why this changed and who is responsible, here are the corrective actions that need to be taken to resolve the problem:

-) pkg-plist needs to reflect %%PREFIX%%/etc/syslog-ng.conf instead of etc/syslog-ng/syslog-ng.conf

-) pkg-message needs to mention that configuration file path has changed

-) ${required_files}= in ports/sysutils/syslog-ng2/files/syslog-ng.sh.in needs to reflect %%PREFIX%%/etc/syslog-ng.conf instead of %%PREFIX%%/etc/syslog-ng/syslog-ng.conf
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Apr 10 22:54:39 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111462 

From: Ivan Lago <ivan.lago@ifom-ieo-campus.it>
To: bug-followup@FreeBSD.org,
 bseklecki@collaborativefusion.com
Cc:  
Subject: Re: ports/111462: syslog-ng2 default configuration file path
Date: Wed, 11 Apr 2007 09:41:44 +0200

 Got it; i'll produce a standard patch ASAP 

From: ivan.lago@ifom-ieo-campus.it
To: FreeBSD-gnats-submit@freebsd.org
Cc:  
Subject: re:ports/111462: syslog-ng2 default configuration file path
Date: Fri, 20 Apr 2007 14:07:05 +0000 (UTC)

 >Submitter-Id:	current-users
 >Originator:	Ivan Lago
 >Organization:	European Institute of Oncology
 >Confidential:	no
 >Synopsis:	re:ports/111462: syslog-ng2 default configuration file path
 >Severity:	 serious
 >Priority:	 medium 
 >Category:	ports
 >Class:		maintainer-update 
 >Release:	FreeBSD 6.2-RELEASE-p3 amd64
 >Environment:
 System: FreeBSD sodio.ifom-ieo-campus.it 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3 #5: Fri Mar 16 15:21:33 CET 2007 root@sodio.ifom-ieo-campus.it:/usr/obj/usr/src/sys/SODIO amd64
 
 
 >Description:
 Among many other things, syslog-ng changed the default configuration file path
 determination method between 2.0.0 and 2.0.3. This was missed by the port maintainer (an
 easy mistake if you set $syslog_ng_flags="-f /alt/file.conf"
 
 seklecki@ravage:/tmp$ diff -u syslog-ng-2.0.0/syslog-ng.spec.bb \
 syslog-ng-2.0.2/syslog-ng.spec.bb | grep -i conf
 
 
 -./configure --prefix=/ --mandir=/usr/share/man --infodir=/usr/share/info \
 - --sysconfdir=/etc
 
 +./configure --prefix=%{prefix} --mandir=%{_mandir} --infodir=%{prefix}/share/info \
 + --sysconfdir=/etc/syslog-ng
 >How-To-Repeat:
 portupgrade to 2.0.2
 >Fix:
 
 	
 
 --- syslog-ng2.patch begins here ---
 diff -ruN /usr/ports/sysutils/syslog-ng2/files/pkg-message.in syslog-ng2/files/pkg-message.in
 --- /usr/ports/sysutils/syslog-ng2/files/pkg-message.in	Thu Mar 22 17:30:16 2007
 +++ syslog-ng2/files/pkg-message.in	Mon Apr 16 16:46:51 2007
 @@ -2,8 +2,12 @@
  syslog-ng is now installed!  To replace FreeBSD's standard syslogd
  (/usr/sbin/syslogd), complete these steps:
  
 -1. Create a configuration file named %%PREFIX%%/etc/syslog-ng/syslog-ng.conf
 -   (a sample named syslog-ng.conf.sample has been included)
 +1. Create a configuration file named %%PREFIX%%/etc/syslog-ng.conf
 +   (a sample named syslog-ng.conf.sample has been included in 
 +   %%PREFIX%%/etc/syslog-ng). Note that this is a change in 2.0.2
 +   version, previous ones put the config file in 
 +   %%PREFIX%%/etc/syslog-ng/syslog-ng.conf, so if this is an update
 +   move that file in the right place
  
  2. Configure syslog-ng to start automatically by adding the following
     to /etc/rc.conf:
 diff -ruN /usr/ports/sysutils/syslog-ng2/files/syslog-ng.sh.in syslog-ng2/files/syslog-ng.sh.in
 --- /usr/ports/sysutils/syslog-ng2/files/syslog-ng.sh.in	Thu Mar 22 17:30:16 2007
 +++ syslog-ng2/files/syslog-ng.sh.in	Mon Apr 16 16:16:11 2007
 @@ -24,7 +24,7 @@
  rcvar=`set_rcvar`
  
  command=%%PREFIX%%/sbin/syslog-ng
 -required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf
 +required_files=%%PREFIX%%/etc/syslog-ng.conf
  extra_commands=reload
  
  if checkyesno syslog_ng_purgeklog; then
 --- syslog-ng2.patch ends here ---
 
 

From: "Brian A. Seklecki" <bseklecki@collaborativefusion.com>
To: Ivan Lago <ivan.lago@ifom-ieo-campus.it>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/111462: syslog-ng2 default configuration file path
Date: Thu, 10 May 2007 10:30:30 -0400

 The patch looks great; has my thumbs up for a commit.
 
 ~BAS
 
 On Wed, 2007-04-11 at 09:41 +0200, Ivan Lago wrote:
 > Got it; i'll produce a standard patch ASAP 
 > 
 > 
 > 
 > 
 > 
 > 
 -- 
 Brian A. Seklecki <bseklecki@collaborativefusion.com>
 Collaborative Fusion, Inc.
 
 
 
 
 IMPORTANT: This message contains confidential information and is intended only for the individual named. If the reader of this message is not an intended recipient (or the individual responsible for the delivery of this message to an intended recipient), please be advised that any re-use, dissemination, distribution or copying of this message is prohibited.  Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.
 
 
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu May 10 15:46:03 UTC 2007 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111462 
Responsible-Changed-From-To: freebsd-ports-bugs->tmclaugh 
Responsible-Changed-By: tmclaugh 
Responsible-Changed-When: Sun Jun 24 08:20:46 UTC 2007 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111462 
Responsible-Changed-From-To: tmclaugh->linimon 
Responsible-Changed-By: tmclaugh 
Responsible-Changed-When: Sun Jun 24 08:28:39 UTC 2007 
Responsible-Changed-Why:  
Over to linimon per request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111462 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Sat Jul 28 22:20:11 UTC 2007 
State-Changed-Why:  
Committed the maintainer's patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=111462 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/111462: commit references a PR
Date: Sat, 28 Jul 2007 22:28:15 +0000 (UTC)

 pav         2007-07-28 22:28:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/syslog-ng2  Makefile 
     sysutils/syslog-ng2/files pkg-message.in syslog-ng.sh.in 
   Log:
   - Correct the location of a configuration file
   
   PR:             ports/111462
   Reported by:    Brian A. Seklecki <bseklecki@collaborativefusion.com>
   Submitted by:   Ivan Lago <ivan.lago@ifom-ieo-campus.it> (maintainer)
   
   Revision  Changes    Path
   1.6       +1 -0      ports/sysutils/syslog-ng2/Makefile
   1.2       +6 -2      ports/sysutils/syslog-ng2/files/pkg-message.in
   1.4       +2 -2      ports/sysutils/syslog-ng2/files/syslog-ng.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
