From norn@norn.ca.eu.org Sat Apr 10 22:49:36 1999
Return-Path: <norn@norn.ca.eu.org>
Received: from norn.ca.eu.org (cr965240-b.abtsfd1.bc.wave.home.com [24.113.19.137])
	by hub.freebsd.org (Postfix) with ESMTP id 9A50B153FC
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 10 Apr 1999 22:49:27 -0700 (PDT)
	(envelope-from norn@norn.ca.eu.org)
Received: by norn.ca.eu.org (Postfix, from userid 1000)
	id E42A1161E; Sat, 10 Apr 1999 22:47:13 -0700 (PDT)
Message-Id: <19990411054713.E42A1161E@norn.ca.eu.org>
Date: Sat, 10 Apr 1999 22:47:13 -0700 (PDT)
From: cpiazza@home.net
Sender: norn@norn.ca.eu.org
Reply-To: cpiazza@home.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: New port: cmp3 
X-Send-Pr-Version: 3.2

>Number:         11076
>Category:       ports
>Synopsis:       New port: cmp3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 10 22:50:01 PDT 1999
>Closed-Date:    Tue Apr 13 16:27:28 PDT 1999
>Last-Modified:  Tue Apr 13 16:27:51 PDT 1999
>Originator:     Chris Piazza
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
n/a 
>Environment:

4.0-CURRENT post-egcs.

>Description:

A(nother) frontend to mpg123.  Uses ncurses.
Portlint: 1 warning.
CFLAGS/PREFIX: respected

>How-To-Repeat:

>Fix:
	
# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	cmp3
#	cmp3/Makefile
#	cmp3/files
#	cmp3/files/md5
#	cmp3/pkg
#	cmp3/pkg/COMMENT
#	cmp3/pkg/DESCR
#	cmp3/pkg/PLIST
#	cmp3/patches
#	cmp3/patches/patch-aa
#	cmp3/patches/patch-ab
#	cmp3/patches/patch-ac
#
echo c - cmp3
mkdir -p cmp3 > /dev/null 2>&1
echo x - cmp3/Makefile
sed 's/^X//' >cmp3/Makefile << 'END-of-cmp3/Makefile'
X# New ports collection makefile for:   cmp3
X# Version required:    2.0pre3
X# Date created:        10 April 1999
X# Whom:                Chris Piazza <cpiazza@home.net>
X#
X# $Id$
X#
X
XDISTNAME=	cmp3-2.0pre3
XPKGNAME=	cmp3-2.0p3
XCATEGORIES=	audio
XMASTER_SITES=	http://nkk104.rh.psu.edu/cmp3/
X
XMAINTAINER=	cpiazza@home.net
X
XRUN_DEPENDS= 	mpg123:${PORTSDIR}/audio/mpg123
X
XUSE_GMAKE=	YES
X
XWRKSRC=	${WRKDIR}/cmp3
X
Xdo-install:
X	${INSTALL_PROGRAM} ${WRKSRC}/cmp3 ${PREFIX}/bin
X	${INSTALL_PROGRAM} ${WRKSRC}/rnmp3 ${PREFIX}/bin
X	${MKDIR} ${PREFIX}/share/cmp3
X	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/cmp3
X
Xpost-install:
X	@${ECHO_MSG} "*****NOTE*****"
X	@${ECHO_MSG} "Please read ${PREFIX}/share/cmp3/README before \
X		      using cmp3"
X	@${ECHO_MSG} "*****NOTE*****" 
X
X.include <bsd.port.mk>
END-of-cmp3/Makefile
echo c - cmp3/files
mkdir -p cmp3/files > /dev/null 2>&1
echo x - cmp3/files/md5
sed 's/^X//' >cmp3/files/md5 << 'END-of-cmp3/files/md5'
XMD5 (cmp3-2.0pre3.tar.gz) = 5f2014ded170a67577ce8323312ce451
END-of-cmp3/files/md5
echo c - cmp3/pkg
mkdir -p cmp3/pkg > /dev/null 2>&1
echo x - cmp3/pkg/COMMENT
sed 's/^X//' >cmp3/pkg/COMMENT << 'END-of-cmp3/pkg/COMMENT'
XAn ncurses based frontend to mpg123.
END-of-cmp3/pkg/COMMENT
echo x - cmp3/pkg/DESCR
sed 's/^X//' >cmp3/pkg/DESCR << 'END-of-cmp3/pkg/DESCR'
XA simple yet featureful ncurses frontend to mpg123.
XIncludes playlist support, volume control and tools to help
Xwith file management.
X
XHomepage:
Xhttp://nkk104.rh.psu.edu/cmp3/
XAuthor:
XNeville Kadwa <pandama@psu.edu>
X
X-Chris Piazza
Xcpiazza@home.net
END-of-cmp3/pkg/DESCR
echo x - cmp3/pkg/PLIST
sed 's/^X//' >cmp3/pkg/PLIST << 'END-of-cmp3/pkg/PLIST'
Xbin/cmp3
Xbin/rnmp3
Xshare/cmp3/README
X@dirrm share/cmp3
END-of-cmp3/pkg/PLIST
echo c - cmp3/patches
mkdir -p cmp3/patches > /dev/null 2>&1
echo x - cmp3/patches/patch-aa
sed 's/^X//' >cmp3/patches/patch-aa << 'END-of-cmp3/patches/patch-aa'
X--- Makefile.orig	Sat Apr 10 12:40:57 1999
X+++ Makefile	Sat Apr 10 22:21:27 1999
X@@ -30,8 +30,9 @@
X # stands. Change the code to do something else you want it to do...
X #PARAMS +=-DMY_CD
X LIBS= -lncurses
X-CFLAGS= -Wall -O2 -g
X-CC= gcc
X+CFLAGS?= -O2
X+CFLAGS+= -Wall -g
X+CC?= gcc
X OBJS= llist.o cmp3fileio.o cmp3manager.o cmp3curses.o cmp3llist.o \
X       cmp3main.o cmp3listfiles.o cmp3playlist.o
X 
X@@ -43,7 +44,6 @@
X endif
X 
X all: rnmp3 cmp3
X-	@echo -e "\n\nCmp3 is ready! Please read the README before proceeding.\n"
X 
X clean: 
X 	rm -f *.o *~ DEADJOE core cmp3 rnmp3
END-of-cmp3/patches/patch-aa
echo x - cmp3/patches/patch-ab
sed 's/^X//' >cmp3/patches/patch-ab << 'END-of-cmp3/patches/patch-ab'
X--- cmp3.h.orig	Sat Apr 10 21:49:16 1999
X+++ cmp3.h	Sat Apr 10 21:54:51 1999
X@@ -1,7 +1,7 @@
X #ifndef _CMP3_H
X #define _CMP3_H
X 
X-#include<curses.h>
X+#include<ncurses.h>
X 
X #ifndef NCURSES_VERSION
X   #error "This program requires ncurses to function"
X@@ -15,7 +15,7 @@
X #include<sys/wait.h>
X #include<sys/ioctl.h>
X #include<sys/stat.h>
X-#include<sys/soundcard.h>
X+#include<machine/soundcard.h>
X #include<fcntl.h>
X #include<stdio.h>
X #include<stdlib.h>
END-of-cmp3/patches/patch-ab
echo x - cmp3/patches/patch-ac
sed 's/^X//' >cmp3/patches/patch-ac << 'END-of-cmp3/patches/patch-ac'
X--- cmp3manager.c.orig	Sat Apr 10 21:49:37 1999
X+++ cmp3manager.c	Sat Apr 10 21:50:06 1999
X@@ -37,7 +37,7 @@
X void manageit()
X {
X 
X-    setpgrp();
X+    setpgid(0,0);
X     shmptr = (shmdata_t*) shmat(shmid,NULL,0);
X     if (shmptr < 0) {
X         perror("can't attach shared memory");
END-of-cmp3/patches/patch-ac
exit


-Chris

>Release-Note:
>Audit-Trail:

From: Michael Haro <mharo@area51.fremont.ca.us>
To: cpiazza@home.net, freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: ports/11076: New port: cmp3
Date: Sat, 10 Apr 1999 23:44:01 -0700

 After a quick runthrough this is what I find...
 
 diff -u -urN -x CVS cmp3/Makefile cmp3.new/Makefile
 --- cmp3/Makefile	Sat Apr 10 23:38:02 1999
 +++ cmp3.new/Makefile	Sat Apr 10 23:39:42 1999
 @@ -15,20 +15,19 @@
  
  RUN_DEPENDS= 	mpg123:${PORTSDIR}/audio/mpg123
  
 -USE_GMAKE=	YES
 +USE_GMAKE=	yes
  
  WRKSRC=	${WRKDIR}/cmp3
  
  do-install:
  	${INSTALL_PROGRAM} ${WRKSRC}/cmp3 ${PREFIX}/bin
  	${INSTALL_PROGRAM} ${WRKSRC}/rnmp3 ${PREFIX}/bin
 -	${MKDIR} ${PREFIX}/share/cmp3
 -	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/cmp3
 +.if !defined(NOPORTDOCS)
 +	${MKDIR} ${PREFIX}/share/doc/cmp3
 +	${INSTALL_DATA} ${WRKSRC}/README ${PREFIX}/share/doc/cmp3
 +.endif
  
  post-install:
 -	@${ECHO_MSG} "*****NOTE*****"
 -	@${ECHO_MSG} "Please read ${PREFIX}/share/cmp3/README before \
 -		      using cmp3"
 -	@${ECHO_MSG} "*****NOTE*****" 
 +	@${CAT} ${PKGDIR}/MESSAGE
  
  .include <bsd.port.mk>
 diff -u -urN -x CVS cmp3/patches/patch-aa cmp3.new/patches/patch-aa
 --- cmp3/patches/patch-aa	Sat Apr 10 23:38:03 1999
 +++ cmp3.new/patches/patch-aa	Sat Apr 10 23:28:00 1999
 @@ -1,5 +1,23 @@
  --- Makefile.orig	Sat Apr 10 12:40:57 1999
 -+++ Makefile	Sat Apr 10 22:21:27 1999
 ++++ Makefile	Sat Apr 10 23:26:31 1999
 +@@ -1,7 +1,7 @@
 + #
 + #  Set these variables
 + #
 +-INIT_DIR="/mp3"
 ++INIT_DIR="$(PREFIX)/share/mp3"
 + MPG123_LOC="mpg123"
 + #INSTALL_DIR=/usr/local/bin
 + INSTALL_DIR=$(HOME)/bin
 +@@ -11,7 +11,7 @@
 + #
 + 
 + ## An ass repository is a nice thing to have. See README
 +-ASSREPOSITORY="$(HOME)/.cmp3ass"
 ++#ASSREPOSITORY="$(HOME)/.cmp3ass"
 + 
 + ## Define this for bufferring or add other parameters to mpg123
 + #EXEC_PARAMS=-DEXEC_PARAMS="\"-b\",\"320\""
  @@ -30,8 +30,9 @@
   # stands. Change the code to do something else you want it to do...
   #PARAMS +=-DMY_CD
 @@ -7,7 +25,7 @@
  -CFLAGS= -Wall -O2 -g
  -CC= gcc
  +CFLAGS?= -O2
 -+CFLAGS+= -Wall -g
 ++CFLAGS+= -Wall
  +CC?= gcc
   OBJS= llist.o cmp3fileio.o cmp3manager.o cmp3curses.o cmp3llist.o \
         cmp3main.o cmp3listfiles.o cmp3playlist.o
 @@ -20,3 +38,7 @@
   
   clean: 
   	rm -f *.o *~ DEADJOE core cmp3 rnmp3
 +@@ -75,4 +75,4 @@
 + 	    fi;
 + endif
 + 
 diff -u -urN -x CVS cmp3/pkg/MESSAGE cmp3.new/pkg/MESSAGE
 --- cmp3/pkg/MESSAGE	Wed Dec 31 16:00:00 1969
 +++ cmp3.new/pkg/MESSAGE	Sat Apr 10 23:00:51 1999
 @@ -0,0 +1,3 @@
 +*****NOTE*****
 +Please read ${PREFIX}/share/cmp3/README before using cmp3
 +*****NOTE*****
 diff -u -urN -x CVS cmp3/pkg/PLIST cmp3.new/pkg/PLIST
 --- cmp3/pkg/PLIST	Sat Apr 10 23:38:03 1999
 +++ cmp3.new/pkg/PLIST	Sat Apr 10 23:30:04 1999
 @@ -1,4 +1,4 @@
  bin/cmp3
  bin/rnmp3
 -share/cmp3/README
 -@dirrm share/cmp3
 +share/doc/cmp3/README
 +@dirrm share/doc/cmp3
 
 Michael
 
State-Changed-From-To: open->closed 
State-Changed-By: mharo 
State-Changed-When: Tue Apr 13 16:27:28 PDT 1999 
State-Changed-Why:  
Committed, Thanks! 
>Unformatted:
