From ed@hoeg.nl  Sat Mar 17 12:35:42 2007
Return-Path: <ed@hoeg.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7ADB216A400
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Mar 2007 12:35:42 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (palm.hoeg.nl [83.98.131.212])
	by mx1.freebsd.org (Postfix) with ESMTP id 4802C13C4BC
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 17 Mar 2007 12:35:42 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 071661CD33; Sat, 17 Mar 2007 13:35:41 +0100 (CET)
Message-Id: <20070317123541.071661CD33@palm.hoeg.nl>
Date: Sat, 17 Mar 2007 13:35:41 +0100 (CET)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [devel/xxgdb] Use termios.h instead of sgtty.h
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         110444
>Category:       ports
>Synopsis:       [devel/xxgdb] Use termios.h instead of sgtty.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 17 12:40:03 GMT 2007
>Closed-Date:    Wed Mar 21 09:59:21 GMT 2007
>Last-Modified:  Wed Mar 21 10:00:52 GMT 2007
>Originator:     Ed Schouten
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Feb 11 22:32:09 CET 2007 root@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The devel/xxgdb port uses <sgtty.h> features, which require COMPAT_43 or
COMPAT_43TTY. We're better off by using <termios.h>.
>How-To-Repeat:
>Fix:
Apply the patch below:

--- devel/xxgdb/files/patch-ac	Wed Nov 22 17:09:07 2000
+++ devel/xxgdb/files/patch-ac	Sat Mar 17 13:33:23 2007
@@ -1,5 +1,16 @@
 --- calldbx.c.orig	Tue Jun 20 07:11:00 1995
 +++ calldbx.c	Fri Nov 17 21:27:09 2000
+@@ -74,8 +74,8 @@
+ #include <string.h>
+ #include <fcntl.h>
+ #include "global.h"
+-#if !(defined(OLDSUNOS) || defined(BSD))
+-#include <termio.h>
++#if !(defined(OLDSUNOS) || defined(BSD)) || defined(__FreeBSD__)
++#include <termios.h>
+ #else
+ #include <sgtty.h>
+ #endif
 @@ -137,13 +137,17 @@
  
  #ifndef sco
@@ -19,3 +30,29 @@
  	    if ((master = open(pty, O_RDWR)) >= 0) 
  		return (master); 
  	}
+@@ -246,8 +250,8 @@
+ /*
+  * (JBL)10MAY91 : use sgttyb if generic BSD
+  */
+-#if !(defined(OLDSUNOS) || defined(BSD))
+-    struct termio Termio;
++#if !(defined(OLDSUNOS) || defined(BSD)) || defined(__FreeBSD__)
++    struct termios Termio;
+ #else
+     struct sgttyb Termio;
+ #endif
+@@ -355,11 +359,11 @@
+ 	/*
+ 	 * (JBL)10MAY91 : use sgttyb if OLDSUN or generic BSD
+ 	 */ 
+-#if !(defined(OLDSUNOS) || defined(BSD))
+-	ioctl(slave, TCGETA, &Termio);
++#if !(defined(OLDSUNOS) || defined(BSD)) || defined(__FreeBSD__)
++	tcgetattr(slave, &Termio);
+ 	Termio.c_lflag &= ~ECHO;	/* No echo */
+ 	Termio.c_oflag &= ~ONLCR;	/* Do not map NL to CR-NL on output */
+-	ioctl(slave, TCSETA, &Termio);
++	tcsetattr(slave, TCSANOW, &Termio);
+ #else
+ 	ioctl(slave, TIOCGETP, &Termio);
+ 	Termio.sg_flags &= ~ECHO;	/* No echo */
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Sun Mar 18 08:46:02 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110444 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Wed Mar 21 09:59:19 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110444 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110444: commit references a PR
Date: Wed, 21 Mar 2007 09:59:47 +0000 (UTC)

 miwi        2007-03-21 09:59:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/xxgdb/files    patch-ac 
   Log:
   - Use termios.h instead of sgtty.h
   
   PR:             110444
   Submitted by:   Ed Schouten <ed@fxq.nl>
   
   Revision  Changes    Path
   1.2       +37 -0     ports/devel/xxgdb/files/patch-ac
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
