From ed@hoeg.nl  Thu Mar 15 22:17:23 2007
Return-Path: <ed@hoeg.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3066316A402
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Mar 2007 22:17:23 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (palm.hoeg.nl [83.98.131.212])
	by mx1.freebsd.org (Postfix) with ESMTP id F305713C459
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Mar 2007 22:17:22 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 6AFB71CD39; Thu, 15 Mar 2007 23:17:56 +0100 (CET)
Message-Id: <20070315221756.6AFB71CD39@palm.hoeg.nl>
Date: Thu, 15 Mar 2007 23:17:56 +0100 (CET)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [ports-mgmt/portmanager] Remove inclusion of <sgtty.h>
X-Send-Pr-Version: 3.113
X-GNATS-Notify: rnoland@2hip.net

>Number:         110363
>Category:       ports
>Synopsis:       [ports-mgmt/portmanager] Remove inclusion of <sgtty.h>
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 15 22:20:01 GMT 2007
>Closed-Date:    Tue Mar 20 17:18:38 GMT 2007
>Last-Modified:  Tue Mar 20 17:20:02 GMT 2007
>Originator:     Ed Schouten
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Feb 11 22:32:09 CET 2007 root@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
Somewhere in the portmanager port the <sgtty.h> file gets included,
while it isn't needed at all. The file isn't used anywhere, so we can
safely remove the inclusion, making it possible to remove old tty stuff
in the future.
>How-To-Repeat:
>Fix:
--- files/patch-libMGPM__src__MGPMrShowLeavesDelete.c	Wed Dec 13 11:13:00 2006
+++ files/patch-libMGPM__src__MGPMrShowLeavesDelete.c	Thu Mar 15 23:14:04 2007
@@ -1,5 +1,13 @@
 --- ./libMGPM/src/MGPMrShowLeavesDelete.c.orig	Mon Dec 12 15:32:34 2005
 +++ ./libMGPM/src/MGPMrShowLeavesDelete.c	Fri Dec  8 17:13:00 2006
+@@ -28,7 +28,6 @@
+ */
+ 
+ #include	<libMGPM.h>
+-#include	<sgtty.h>
+ 
+ int	nuke( char* leafPortDir );
+ int	rebuildDb( structProperty* property );
 @@ -39,19 +39,21 @@
  	char	exact[]			= "exact";
  	char	id[]			= "MGPMrShowLeavesDelete";
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Mar 15 22:20:08 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110363 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Fri Mar 16 08:56:22 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110363 

From: "Robert C. Noland III" <rnoland@2hip.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110363: [ports-mgmt/portmanager] Remove inclusion of
	<sgtty.h>
Date: Tue, 20 Mar 2007 09:53:37 -0500

 On Thu, 2007-03-15 at 22:20 +0000, Edwin Groothuis wrote:
 > Maintainer of ports-mgmt/portmanager,
 > 
 > Please note that PR ports/110363 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 
 This patch looks fine, please commit.
 
 robert.
 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/110363
 > 
 
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Mar 20 17:18:34 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110363 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110363: commit references a PR
Date: Tue, 20 Mar 2007 17:18:29 +0000 (UTC)

 miwi        2007-03-20 17:18:19 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ports-mgmt/portmanager/files 
                                  patch-libMGPM__src__MGPMrShowLeavesDelete.c 
   Log:
   -  Remove inclusion of <sgtty.h>
   
   PR:             110363
   Submitted by:   Ed Schouten <ed@fxq.nl>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.2       +8 -0      ports/ports-mgmt/portmanager/files/patch-libMGPM__src__MGPMrShowLeavesDelete.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
