From ed@hoeg.nl  Thu Mar 15 21:52:40 2007
Return-Path: <ed@hoeg.nl>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CB08716A405
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Mar 2007 21:52:40 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (palm.hoeg.nl [83.98.131.212])
	by mx1.freebsd.org (Postfix) with ESMTP id 902FA13C46C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Mar 2007 21:52:40 +0000 (UTC)
	(envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id C69941CD3F; Thu, 15 Mar 2007 22:53:18 +0100 (CET)
Message-Id: <20070315215318.C69941CD3F@palm.hoeg.nl>
Date: Thu, 15 Mar 2007 22:53:18 +0100 (CET)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [misc/heyu] Don't let it touch sgtty.h
X-Send-Pr-Version: 3.113
X-GNATS-Notify: mstowe@chicago.us.mensa.org

>Number:         110360
>Category:       ports
>Synopsis:       [misc/heyu] Don't let it touch sgtty.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 15 22:00:09 GMT 2007
>Closed-Date:    Fri Mar 16 21:06:13 GMT 2007
>Last-Modified:  Fri Mar 16 21:10:19 GMT 2007
>Originator:     Ed Schouten
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD palm.hoeg.nl 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Feb 11 22:32:09 CET 2007 root@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386
>Description:
The heyu port makes use of <sgtty.h>, though it supports <termios.h>
when -DPOSIX is turned on. Using <sgtty.h> is bad, because it breaks
on kernels without  COMPAT_43TTY
>How-To-Repeat:
>Fix:
--- misc/heyu/files/patch-Configure	Thu Jan  1 01:00:00 1970
+++ misc/heyu/files/patch-Configure	Thu Mar 15 22:49:49 2007
@@ -0,0 +1,11 @@
+--- Configure	Mon Mar 31 08:58:14 2003
++++ Configure	Thu Mar 15 22:48:05 2007
+@@ -86,7 +86,7 @@
+ 		CC = gcc
+ 		CFLAGS = -g -O \$(DFLAGS) -Wall
+ 		LIBS = -lm -lc
+-		DFLAGS= -DHASSELECT -DNEEDGTIME -DFREEBSD
++		DFLAGS= -DPOSIX -DHASSELECT -DNEEDGTIME -DFREEBSD
+ EoF
+ 	;;
+     sco*)
--- misc/heyu/files/patch-tty.c	Thu Jan  1 01:00:00 1970
+++ misc/heyu/files/patch-tty.c	Thu Mar 15 22:49:49 2007
@@ -0,0 +1,16 @@
+--- tty.c	Sun Mar 30 22:57:59 2003
++++ tty.c	Thu Mar 15 22:48:59 2007
+@@ -86,11 +86,11 @@
+ #include <sgtty.h>
+ struct sgttyb oldsb, newsb;
+ #else
+-#ifndef POSIX
+-#include <termio.h>
+ #ifndef NCC
+ #define NCC NCCS
+ #endif
++#ifndef POSIX
++#include <termio.h>
+ struct termio oldsb, newsb;
+ #else
+ #include <termios.h>
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Mar 15 22:00:16 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110360 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Fri Mar 16 08:56:09 UTC 2007 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110360 

From: "Michael Stowe" <mstowe@chicago.us.mensa.org>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/110360: [misc/heyu] Don't let it touch sgtty.h
Date: Fri, 16 Mar 2007 13:28:08 -0500 (CDT)

 Works for me, thanks
 
 > Maintainer of misc/heyu,
 >
 > Please note that PR ports/110360 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/110360
 >
 > --
 > Edwin Groothuis
 > edwin@FreeBSD.org
 >
 
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Fri Mar 16 21:06:11 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110360 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110360: commit references a PR
Date: Fri, 16 Mar 2007 21:06:20 +0000 (UTC)

 miwi        2007-03-16 21:05:58 UTC
 
   FreeBSD ports repository
 
   Added files:
     misc/heyu/files      patch-tty.c 
   Log:
   The heyu port makes use of <sgtty.h>, though it supports <termios.h>
   when -DPOSIX is turned on. Using <sgtty.h> is bad, because it breaks
   on kernels without COMPAT_43TTY
   
   PR:             110360
   Submitted by:   Ed Schouten <ed@fxq.nl>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.1       +16 -0     ports/misc/heyu/files/patch-tty.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
