From hmo@sep.oldach.net  Wed Mar  7 22:29:42 2007
Return-Path: <hmo@sep.oldach.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9FC1C16A403
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2007 22:29:42 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from rigel.oldach.net (rigel.oldach.net [194.8.96.250])
	by mx1.freebsd.org (Postfix) with ESMTP id 1319513C4B6
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2007 22:29:41 +0000 (UTC)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (hmo.in-dsl.de [217.197.85.210])
	by rigel.oldach.net (8.13.8/8.13.8/hmo30jul04) with ESMTP id l27M2DGn006852
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Mar 2007 23:02:14 +0100 (CET)
	(envelope-from hmo@sep.oldach.net)
Received: from sep.oldach.net (localhost [127.0.0.1])
	by sep.oldach.net (8.13.8/8.13.8/hmo26jun05) with ESMTP id l27M2CHr001980
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 7 Mar 2007 23:02:12 +0100 (CET)
	(envelope-from hmo@sep.oldach.net)
Received: (from hmo@localhost)
	by sep.oldach.net (8.13.8/8.13.8/Submit/hmo26jun05) id l27M2Bqf001979;
	Wed, 7 Mar 2007 23:02:11 +0100 (CET)
	(envelope-from hmo)
Message-Id: <200703072202.l27M2Bqf001979@sep.oldach.net>
Date: Wed, 7 Mar 2007 23:02:11 +0100 (CET)
From: Helge Oldach <ports-graphviz-mar07@oldach.net>
Reply-To: Helge Oldach <ports-graphviz-mar07@oldach.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] ports/graphics/graphviz plugins do not work
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         110060
>Category:       ports
>Synopsis:       [patch] ports/graphics/graphviz plugins do not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 22:30:07 GMT 2007
>Closed-Date:    Fri Mar 09 11:50:22 CET 2007
>Last-Modified:  Fri Mar 09 11:50:22 CET 2007
>Originator:     Helge Oldach
>Release:        FreeBSD 6.2-740 i386
>Organization:
>Environment:

System: FreeBSD localhost 6.2-740 FreeBSD 6.2-740 #0: Thu Mar 1 10:40:54 CET 2007 toor@localhost:/usr/obj/usr/src/sys/HMO i386

>Description:

Graphviz' plugins to not work, making most common graphics formats
inaccessible. For example:

# dot -Tpng
Renderer type: "png" not recognized. Use one of: dia dot fig hpgl mif mp pcl pic
# 

Some debugging revealed that the plugin loading is broken.
lib/gv/gvconfig.c references the Makefile's GVLIBDIR
build-time environment variable which is defined as
/usr/local/lib/graphviz/graphviz. (Note the double "graphviz".)
This directory doesn't exist, Actually the correct directory is
/usr/local/lib/graphviz (single "graphviz").

The root cause is an incomplete ${REINPLACE_CMD} in the ports' Makefile,
applied to lib/Makefile.in. While it is correct to amend libdir, we must
consequently rectify pkglibdir to avoid the double "graphviz". See the
patch below.

After application of the patch:

# dot -Twhatever
Renderer type: "whatever" not recognized. Use one of: canon cmap cmapx dia dot fig gd gd2 gif hpgl imap ismap jpeg jpg mif mp pcl pic plain plain-ext png ps ps2 svg svgz vrml vtx wbmp xdot
# 

While we're at it, ports/graphviz/files/patch-configure is an empty file
that should be removed.

>How-To-Repeat:

See above.

>Fix:

rm ports/graphviz/files/patch-configure

--- Makefile.ORIG	Tue Mar  6 17:06:30 2007
+++ Makefile	Wed Mar  7 22:09:12 2007
@@ -192,7 +192,8 @@
 		${WRKSRC}/cmd/gvpr/Makefile.in
 	@${FIND} ${WRKSRC}/lib -name 'Makefile.in' | \
 		${XARGS} ${REINPLACE_CMD} \
-		-e 's|libdir = @libdir@|libdir = @libdir@/graphviz|g';
+		-e 's|pkglibdir = $$(libdir)/@PACKAGE@|pkglibdir = $$(libdir)|g' \
+		-e 's|libdir = @libdir@|libdir = @libdir@/@PACKAGE@|g';
 	@${REINPLACE_CMD} -e "s|/usr/include/php|${LOCALBASE}/include/php|g" \
 		-e "s|-lruby|-lruby${RUBY_SUFFIX}|g" ${WRKSRC}/configure
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 7 22:30:24 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110060 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110060: commit references a PR
Date: Fri,  9 Mar 2007 07:28:26 +0000 (UTC)

 dinoex      2007-03-09 07:28:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/graphviz    Makefile pkg-plist 
   Removed files:
     graphics/graphviz/files patch-configure 
   Log:
   - fix plugin handling
   PR:             110060
   Submitted by:   Helge Oldach
   
   - add options TK ICONV XPM
   PR:             110060
   Submitted by:   Helge Oldach
   
   - avoid starting "-help"
   - fix pkg-plist after patches
   - fix default options
   - bump PORTREVISION
   
   Revision  Changes    Path
   1.75      +53 -17    ports/graphics/graphviz/Makefile
   1.5       +0 -0      ports/graphics/graphviz/files/patch-configure (dead)
   1.34      +2 -1      ports/graphics/graphviz/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/110060: commit references a PR
Date: Fri,  9 Mar 2007 07:28:27 +0000 (UTC)

 dinoex      2007-03-09 07:28:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/graphviz    Makefile pkg-plist 
   Removed files:
     graphics/graphviz/files patch-configure 
   Log:
   - fix plugin handling
   PR:             110060
   Submitted by:   Helge Oldach
   
   - add options TK ICONV XPM
   PR:             110060
   Submitted by:   Helge Oldach
   
   - avoid starting "-help"
   - fix pkg-plist after patches
   - fix default options
   - bump PORTREVISION
   
   Revision  Changes    Path
   1.75      +53 -17    ports/graphics/graphviz/Makefile
   1.5       +0 -0      ports/graphics/graphviz/files/patch-configure (dead)
   1.34      +2 -1      ports/graphics/graphviz/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Fri Mar 9 11:50:08 CET 2007 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=110060 
>Unformatted:
