From nobody@FreeBSD.org  Thu Jan 25 16:14:17 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 987BB16A401
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Jan 2007 16:14:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 70D6213C43E
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Jan 2007 16:14:17 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0PGEGWu032848
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 25 Jan 2007 16:14:16 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l0PGEG7O032847;
	Thu, 25 Jan 2007 16:14:16 GMT
	(envelope-from nobody)
Message-Id: <200701251614.l0PGEG7O032847@www.freebsd.org>
Date: Thu, 25 Jan 2007 16:14:16 GMT
From: Michael Neumann<mneuma2s@smail.inf.fh-brs.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [fix] security/tor and security/tor-devel use pre-install instead of pre-su-install
X-Send-Pr-Version: www-3.0

>Number:         108339
>Category:       ports
>Synopsis:       [fix] security/tor and security/tor-devel use pre-install instead of pre-su-install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 25 16:20:20 GMT 2007
>Closed-Date:    Mon Feb 12 13:34:12 GMT 2007
>Last-Modified:  Mon Feb 12 13:40:06 GMT 2007
>Originator:     Michael Neumann
>Release:        6.2
>Organization:
>Environment:
>Description:
security/tor and security/tor-devel user pre-install to add an user and a group to the system. This fails when running `make install` as normal user.
>How-To-Repeat:
run `make install` as normal user
>Fix:
Change pre-install to pre-su-install in both ports.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 25 16:21:07 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108339 

From: Peter Thoenen <peter.thoenen@yahoo.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/108339: [fix] security/tor and security/tor-devel use pre-install instead of pre-su-install
Date: Thu, 25 Jan 2007 09:15:03 -0800 (PST)

 I was both unaware a pre-su-install stage existed OR that normal users
 could install ports period (via make install in the ports tree).
 
 Regardless installing the tor port as a non-su user will break the port
 period as it installs both a _tor user and _tor group.
 
 If the reporter wishes to be able to install this port as a normal user
 AND the committers don't find this to be a security issue, the the
 orginal PR submitter needs to provide a patch that will account for
 this (e.g. with some custom make options that modify things like
 pkg-install so _tor users don't get installed, chown issues, etc etc).
 
 Or just download and install it manually ... gmake && gmake install

From: Michael Neumann <mneuma2s@smail.inf.fh-bonn-rhein-sieg.de>
To: bug-followup@FreeBSD.org, peter.thoenen@yahoo.com
Cc:  
Subject: Re: ports/108339: [fix] security/tor and security/tor-devel use
 pre-install instead of pre-su-install
Date: Thu, 25 Jan 2007 23:33:26 +0100

 When started as a normal user `make install` will ask for the rootpw to su as
 root. This happens after the pre-install but before the pre-su-install target.
 The port will be able to create the user/group when they're created in the
 pre-su-install target.

From: "Thoenen, Peter" <peter.thoenen@yahoo.com>
To: Michael Neumann <mneuma2s@smail.inf.fh-bonn-rhein-sieg.de>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/108339: [fix] security/tor and security/tor-devel use pre-install
 instead of pre-su-install
Date: Thu, 25 Jan 2007 17:56:13 -0500

 In that case, I will include this change then when the next version is 
 released.
 
 -Peter

From: Peter Thoenen <peter.thoenen@yahoo.com>
To: bug-followup@FreeBSD.org, mneuma2s@smail.inf.fh-brs.de
Cc:  
Subject: Re: ports/108339: [fix] security/tor and security/tor-devel use pre-install instead of pre-su-install
Date: Fri, 9 Feb 2007 11:04:34 -0800 (PST)

 Closed in PR 108966
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=108966&cat=
 
 Thanks for pointing this out, never actually new that existed and
 missed the dicussion on the list about it.
Responsible-Changed-From-To: freebsd-ports-bugs->rafan 
Responsible-Changed-By: rafan 
Responsible-Changed-When: Mon Feb 12 13:07:32 UTC 2007 
Responsible-Changed-Why:  
Eat. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108339 
State-Changed-From-To: feedback->closed 
State-Changed-By: rafan 
State-Changed-When: Mon Feb 12 13:34:05 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108339 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/108339: commit references a PR
Date: Mon, 12 Feb 2007 13:34:06 +0000 (UTC)

 rafan       2007-02-12 13:33:56 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/tor         Makefile 
   Log:
   - Use pre-su-install to allow make install as normal user
   
   PR:             ports/108339
   Submitted by:   Michael Neumann<mneuma2s at smail.inf.fh-brs.de>
   Approved by:    Peter Thoenen <peter.thoenen at yahoo.com> (maintainer)
   
   Revision  Changes    Path
   1.27      +1 -1      ports/security/tor/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
