From nobody@FreeBSD.org  Tue Jan 23 17:18:15 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id D7D3516A400
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 17:18:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id C7D5D13C465
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 17:18:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0NHIFiX091651
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Jan 2007 17:18:15 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l0NHIFUB091650;
	Tue, 23 Jan 2007 17:18:15 GMT
	(envelope-from nobody)
Message-Id: <200701231718.l0NHIFUB091650@www.freebsd.org>
Date: Tue, 23 Jan 2007 17:18:15 GMT
From: Dirk Gouders<dirk.gouders@fh-gelsenkirchen.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Suggestion for additional options to linux-firefox port
X-Send-Pr-Version: www-3.0

>Number:         108268
>Category:       ports
>Synopsis:       Suggestion for additional options to linux-firefox port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    infofarmer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 23 17:20:17 GMT 2007
>Closed-Date:    Tue Jan 23 19:06:37 GMT 2007
>Last-Modified:  Tue Jan 23 19:10:20 GMT 2007
>Originator:     Dirk Gouders
>Release:        FreeBSD 5.5-STABLE
>Organization:
FH Gelsenkirchen, Abt. Bocholt
>Environment:
FreeBSD sora.hank.home 5.5-STABLE FreeBSD 5.5-STABLE #4: Tue Oct  3 17:17:54 CEST 2006     root@sora.hank.home:/usr/src/sys/i386/compile/SORA  i386

>Description:
I would like to suggest to add the options to also install the flash and
java plugins when installing linux-firefox.
>How-To-Repeat:

>Fix:
Here is a modified Makefile that enables these options:

# New ports collection makefile for:	linux-firefox
# Date created:				2004-09-17
# Whom:					voisine
#
# $FreeBSD: ports/www/linux-firefox/Makefile,v 1.33 2006/12/21 15:14:11 sat Exp $
#

PORTNAME=	firefox
PORTVERSION=	2.0.0.1
CATEGORIES=	www
MASTER_SITE_SUBDIR?=	firefox/releases/${PORTVERSION}/linux-i686/en-US

MAINTAINER=	infofarmer@FreeBSD.org
COMMENT=	Web browser based on the browser portion of Mozilla

.include "${.CURDIR}/../linux-seamonkey/Makefile.common"

OPTIONS=	FLASH		"Enable Flash Plugin"		off \
		JAVA		"Enable Java Plugin"		off

.include <bsd.port.pre.mk>

.if defined(WITH_JAVA)
USE_JAVA=	YES
JAVA_VERSION=	1.4
JAVA_OS=	linux
JAVA_VENDOR=	blackdown
.endif

.if defined(WITH_FLASH)
RUN_DEPENDS+=		${LOCALBASE}/lib/npapi/linux-flashplugin/libflashplayer.so:${PORTSDIR}/www/linux-flashplugin7
.endif

post-install:
.if defined(WITH_JAVA)
	@ln -s ${JAVA_HOME}/jre/plugin/i386/mozilla/libjavaplugin_oji.so \
		${LOCALBASE}/lib/linux-firefox/plugins/
.endif

.include <bsd.port.post.mk>

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-www->infofarmer 
Responsible-Changed-By: pav 
Responsible-Changed-When: Tue Jan 23 17:22:25 UTC 2007 
Responsible-Changed-Why:  
Make it a ports PR, assign to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108268 
State-Changed-From-To: open->closed 
State-Changed-By: sat 
State-Changed-When: Tue Jan 23 19:06:01 UTC 2007 
State-Changed-Why:  
Patch rejected, sorry. Thanks anyway! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108268 

From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
To: bug-followup@FreeBSD.org, "Dirk Gouders" <dirk.gouders@fh-gelsenkirchen.de>
Cc:  
Subject: Re: ports/108268: Suggestion for additional options to linux-firefox port
Date: Tue, 23 Jan 2007 22:05:37 +0300

 Hi Dirk,
 
 Thanks for your submission!
 
 I have several reasons to reject the change:
 
 1. I don't like Options.
 
 2. Options are used to change how application
    is built and installed. Using them just to
    define some dependencies sounds like abusal
    to me.
 
 3. This change is generic with regard to other
    ports that support npapi. You should
    probably contact gnome@FreeBSD.org to offer
    a design point. I'm working with them to
    improve npapi support in general, but it's
    been slow for a while now.
 
 I could name a few other reasons, but in fact
 I would like it very much if everything worked
 in firefox out-of-the-box. It's just that
 Flash and Java maintainers (I mean Adobe and
 Sun) are doing everything they can to prevent
 it.
 
 What I mean to say is that I understand you,
 and we probably want the same thing, but a
 couple of options won't solve anything, apart
 from violating the status quo. Sorry.
 
 Thanks for your interest in linux-firefox. It
 would be great if you could look at
 Makefile.npapi (in www/linux-mplayer-plugin)
 and propose some improvements for that one.
 
 Thanks!
>Unformatted:
