From delphij@tarsier.delphij.net  Thu Jan 18 01:30:40 2007
Return-Path: <delphij@tarsier.delphij.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BB36516A47C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 18 Jan 2007 01:30:40 +0000 (UTC)
	(envelope-from delphij@tarsier.delphij.net)
Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229])
	by mx1.freebsd.org (Postfix) with ESMTP id 70E6B13C44C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 18 Jan 2007 01:30:40 +0000 (UTC)
	(envelope-from delphij@tarsier.delphij.net)
Received: from localhost (tarsier.geekcn.org [210.51.165.229])
	by tarsier.geekcn.org (Postfix) with ESMTP id 787E9EB6EC5;
	Thu, 18 Jan 2007 09:11:03 +0800 (CST)
Received: from tarsier.geekcn.org ([210.51.165.229])
	by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024)
	with ESMTP id v58UDVoLKo42; Thu, 18 Jan 2007 09:10:51 +0800 (CST)
Received: from tarsier.delphij.net (tarsier.geekcn.org [210.51.165.229])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by tarsier.geekcn.org (Postfix) with ESMTP id E098BEB6D63;
	Thu, 18 Jan 2007 09:10:48 +0800 (CST)
Received: from tarsier.delphij.net (localhost [127.0.0.1])
	by tarsier.delphij.net (8.13.8/8.13.8) with ESMTP id l0I1AmBI042394;
	Thu, 18 Jan 2007 09:10:48 +0800 (CST)
	(envelope-from delphij@tarsier.delphij.net)
Received: (from delphij@localhost)
	by tarsier.delphij.net (8.13.8/8.13.8/Submit) id l0I1AleV042393;
	Thu, 18 Jan 2007 09:10:47 +0800 (CST)
	(envelope-from delphij)
Message-Id: <200701180110.l0I1AleV042393@tarsier.delphij.net>
Date: Thu, 18 Jan 2007 09:10:47 +0800 (CST)
From: Xin LI <delphij@freebsd.org>
Reply-To: Xin LI <delphij@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jbacon@mcw.edu
Subject: [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jbacon@mcw.edu

>Number:         108068
>Category:       ports
>Synopsis:       [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 18 01:40:20 GMT 2007
>Closed-Date:    Fri Jan 19 01:44:34 GMT 2007
>Last-Modified:  Fri Jan 19 01:50:18 GMT 2007
>Originator:     Xin LI
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD tarsier.delphij.net 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 12:23:27 CST 2007 delphij@tarsier.delphij.net:/usr/obj/usr/src/sys/TARSIER i386


>Description:
	In sysutils/mcweject, there is an instance of use of '-best'
option of gzip(1), which should be spelled as '--best'.  Because the
ports system already have '-9' in GZIP_CMD macro, the option should
be removed because it is useless.

	This would break the port after gzip(1) is replaced by a BSD
licensed one.
>How-To-Repeat:
	make install
>Fix:


--- patch-mcweject begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/sysutils/mcweject/Makefile,v
retrieving revision 1.2
diff -u -p -u -r1.2 Makefile
--- Makefile	4 Jan 2006 06:23:41 -0000	1.2
+++ Makefile	18 Jan 2007 01:03:23 -0000
@@ -30,7 +30,7 @@ do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/eject ${PREFIX}/sbin
 	${CHMOD} 4511 ${PREFIX}/sbin/eject
 	${INSTALL_DATA} ${WRKSRC}/eject.1 ${PREFIX}/man/man1
-	${GZIP_CMD} -best ${PREFIX}/man/man1/eject.1
+	${GZIP_CMD} ${PREFIX}/man/man1/eject.1
 
 post-install:
 	@${CAT} ${PKGMESSAGE}
--- patch-mcweject ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->delphij 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Jan 18 01:40:33 UTC 2007 
Responsible-Changed-Why:  
Submitter has GNATS access 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108068 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 18 01:40:45 UTC 2007 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108068 

From: Jason Bacon <jbacon@mcw.edu>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/108068: [PATCH] Fix misuse of gzip(1) in sysutils/mcweject
Date: Thu, 18 Jan 2007 09:48:18 -0600

 I approve.
 
 Thanks,
 
     JB
 
 Edwin Groothuis wrote:
 > Maintainer of sysutils/mcweject,
 >
 > Please note that PR ports/108068 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/108068
 >
 >   
 
State-Changed-From-To: feedback->open 
State-Changed-By: delphij 
State-Changed-When: Fri Jan 19 01:43:53 UTC 2007 
State-Changed-Why:  
Feedback received. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108068 
State-Changed-From-To: open->closed 
State-Changed-By: delphij 
State-Changed-When: Fri Jan 19 01:44:22 UTC 2007 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=108068 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/108068: commit references a PR
Date: Fri, 19 Jan 2007 01:43:31 +0000 (UTC)

 delphij     2007-01-19 01:43:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/mcweject    Makefile 
   Log:
   Correct a typo which will break build in a future version of
   FreeBSD.  Because we already have '-9' in our ${GZIP_CMD} we
   do not need to specify '--best' anyway.
   
   PR:             ports/108068
   Reported by:    pointyhat via kris
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.3       +1 -1      ports/sysutils/mcweject/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
