From obonilla@voyager.fisicc-ufm.edu Wed Mar 24 07:03:05 1999
Return-Path: <obonilla@voyager.fisicc-ufm.edu>
Received: from voyager.fisicc-ufm.edu (ip-46-094.guate.net [200.12.46.94])
	by hub.freebsd.org (Postfix) with ESMTP id 686AA14BFD
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 24 Mar 1999 07:02:55 -0800 (PST)
	(envelope-from obonilla@voyager.fisicc-ufm.edu)
Received: (from root@localhost)
	by voyager.fisicc-ufm.edu (8.9.2/8.9.2) id JAA03350;
	Wed, 24 Mar 1999 09:07:05 -0600 (CST)
	(envelope-from obonilla)
Message-Id: <199903241507.JAA03350@voyager.fisicc-ufm.edu>
Date: Wed, 24 Mar 1999 09:07:05 -0600 (CST)
From: obonilla@fisicc-ufm.edu
Sender: obonilla@voyager.fisicc-ufm.edu
Reply-To: obonilla@fisicc-ufm.edu
To: FreeBSD-gnats-submit@freebsd.org
Subject: New Port for kmp3
X-Send-Pr-Version: 3.2

>Number:         10770
>Category:       ports
>Synopsis:       New Port for kmp3 (a mp3 player for the KDE)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 24 07:10:01 PST 1999
>Closed-Date:    Sun May 2 20:47:47 PDT 1999
>Last-Modified:  Sun May  2 20:49:14 PDT 1999
>Originator:     Oscar Bonilla
>Release:        FreeBSD 3.1-STABLE i386
>Organization:
Universidad Francisco Marroquin
>Environment:
>Description:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	kmp3
#	kmp3/patches
#	kmp3/patches/patch-aa
#	kmp3/patches/patch-ab
#	kmp3/patches/patch-ac
#	kmp3/Makefile
#	kmp3/pkg
#	kmp3/pkg/DESCR
#	kmp3/pkg/COMMENT
#	kmp3/pkg/PLIST
#	kmp3/files
#	kmp3/files/md5
#
echo c - kmp3
mkdir -p kmp3 > /dev/null 2>&1
echo c - kmp3/patches
mkdir -p kmp3/patches > /dev/null 2>&1
echo x - kmp3/patches/patch-aa
sed 's/^X//' >kmp3/patches/patch-aa << 'END-of-kmp3/patches/patch-aa'
X--- src/player.cpp.orig	Tue Mar 23 18:24:59 1999
X+++ src/player.cpp	Tue Mar 23 18:25:25 1999
X@@ -169,8 +169,8 @@
X       fdhdr.cmsg_type = SCM_RIGHTS;
X       fdhdr.fd = fd;
X 
X-      hdr.msg_control = &fdhdr;
X-//      hdr.msg_control = (char *) &fdhdr;
X+//      hdr.msg_control = &fdhdr;
X+      hdr.msg_control = (char *) &fdhdr;
X       hdr.msg_controllen = sizeof(struct m_cmsghdr);
X 
X       if( amp.sendMsg( &hdr, 0) < 0 ){
END-of-kmp3/patches/patch-aa
echo x - kmp3/patches/patch-ab
sed 's/^X//' >kmp3/patches/patch-ab << 'END-of-kmp3/patches/patch-ab'
X--- amp/audioIO_Linux.c.orig	Tue Mar 23 18:25:44 1999
X+++ amp/audioIO_Linux.c	Tue Mar 23 18:26:08 1999
X@@ -26,7 +26,7 @@
X 
X /* optimal fragment size */
X 
X-int AUSIZ = 0;
X+int AUSIZ_IO = 0;
X 
X /* declare these static to effectively isolate the audio device */
X 
X@@ -78,7 +78,7 @@
X 	if (volume != -1)
X 		audioSetVolume(volume);
X 
X-	if (ioctl(audio_fd, SNDCTL_DSP_GETBLKSIZE, &AUSIZ) == -1)
X+	if (ioctl(audio_fd, SNDCTL_DSP_GETBLKSIZE, &AUSIZ_IO) == -1)
X 		die("Unable to get fragment size\n");
X }
X 
END-of-kmp3/patches/patch-ab
echo x - kmp3/patches/patch-ac
sed 's/^X//' >kmp3/patches/patch-ac << 'END-of-kmp3/patches/patch-ac'
X--- amp/Makefile.in.orig	Tue Mar 23 19:27:20 1999
X+++ amp/Makefile.in	Tue Mar 23 19:27:36 1999
X@@ -50,6 +50,6 @@
X 	gcc -MM ${DEFINES} ${DEBUG} *.c > .depend
X 
X install:
X-	cp kmp3player $(KDEDIR)/bin
X+	cp kmp3player /usr/local/bin
X 
X #-include .depend
END-of-kmp3/patches/patch-ac
echo x - kmp3/Makefile
sed 's/^X//' >kmp3/Makefile << 'END-of-kmp3/Makefile'
X# New ports collection makefile for:   kmpg
X# Version required:    0.4.3a
X# Date created:        23 May 1998
X# Whom:                Hans Petter Bieker <hanspb@persbraten.vgs.no>
X#
X# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $
X#
X
XDISTNAME=	kmp3-0.2.2
XCATEGORIES=	audio kde
XMASTER_SITES=	ftp://ftp.kde.org/pub/kde/stable/1.1/apps/multimedia/sound/
X
XMAINTAINER=	obonilla@fisicc-ufm.edu
X
XLIB_DEPENDS=	kdecore.1:${PORTSDIR}/x11/kdelibs \
X		kdeui.1:${PORTSDIR}/x11/kdelibs
X
XUSE_QT=		yes
XGNU_CONFIGURE=	yes
XUSE_GMAKE=	yes
XCONFIGURE_ENV=	CXXFLAGS="${CXXFLAGS}" \
X		INSTALL_SCRIPT="${INSTALL_SCRIPT}"
XWRKSRC=		${WRKDIR}/kmp3
X
X.include <bsd.port.mk>
END-of-kmp3/Makefile
echo c - kmp3/pkg
mkdir -p kmp3/pkg > /dev/null 2>&1
echo x - kmp3/pkg/DESCR
sed 's/^X//' >kmp3/pkg/DESCR << 'END-of-kmp3/pkg/DESCR'
XThis is an mp3 player for the K Desktop Environment. 
XLooks like the cd player that comes with kmultimedia (kscd).
X
X-Oscar Bonilla <obonilla@fisicc-ufm.edu>
END-of-kmp3/pkg/DESCR
echo x - kmp3/pkg/COMMENT
sed 's/^X//' >kmp3/pkg/COMMENT << 'END-of-kmp3/pkg/COMMENT'
XAn mp3 player for the KDE
END-of-kmp3/pkg/COMMENT
echo x - kmp3/pkg/PLIST
sed 's/^X//' >kmp3/pkg/PLIST << 'END-of-kmp3/pkg/PLIST'
Xbin/kmp3
Xbin/kmp3player
Xshare/applnk/Multimedia/KMp3.kdelnk
Xshare/icons/kmp3.xpm
Xshare/icons/mini/kmp3.xpm
Xshare/apps/kmp3/pics/dock_idle.xpm
Xshare/apps/kmp3/pics/dock_playing.xpm
Xshare/apps/kmp3/pics/logo.xpm
Xshare/locale/fr/LC_MESSAGES/kmp3.mo
Xshare/locale/de/LC_MESSAGES/kmp3.mo
Xshare/locale/es/LC_MESSAGES/kmp3.mo
Xshare/locale/is/LC_MESSAGES/kmp3.mo
X@dirrm share/apps/kmp3/pics
X@dirrm share/apps/kmp3
END-of-kmp3/pkg/PLIST
echo c - kmp3/files
mkdir -p kmp3/files > /dev/null 2>&1
echo x - kmp3/files/md5
sed 's/^X//' >kmp3/files/md5 << 'END-of-kmp3/files/md5'
XMD5 (kmp3-0.2.2.tar.gz) = 40afffe0902d7214e60b7ab8c669d285
END-of-kmp3/files/md5
exit













>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:

From: Tom Hukins <tom@eborcom.com>
To: obonilla@fisicc-ufm.edu
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/10770: New Port for kmp3
Date: Wed, 24 Mar 1999 22:08:33 +0000

 Oscar, thanks for submitting this port. There are a few problems
 with it, which I explain below:
 
 On Wed, Mar 24, 1999 at 09:07:05AM -0600, obonilla@fisicc-ufm.edu wrote:
 > 
 > >Synopsis:       New Port for kmp3 (a mp3 player for the KDE)
 > 
 > X# New ports collection makefile for:   kmpg
 > X# Version required:    0.4.3a
 > X# Date created:        23 May 1998
 > X# Whom:                Hans Petter Bieker <hanspb@persbraten.vgs.no>
 
 Each one of the lines above is incorrect. The "Making a port
 yourself" section of the Handbook explains how this should be done
 under the "Quick porting section".
 
 > X# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $
 
 A new port should be submitted with $Id$. Again, this is covered in
 the Handbook.
 
 I have tidied up this port (patch below), fixing the things
 mentioned above, using MASTER_SITE_KDE and sorting pkg/PLIST
 alphabetically.
 
 The kmp3/amp section of the port still fails to honour CFLAGS,
 however. I haven't fixed this.
 
 Tom
 
 
 
 diff -ruN kmp3.old/Makefile kmp3/Makefile
 --- kmp3.old/Makefile	Wed Mar 24 21:58:50 1999
 +++ kmp3/Makefile	Wed Mar 24 20:44:13 1999
 @@ -1,14 +1,15 @@
  # New ports collection makefile for:   kmpg
 -# Version required:    0.4.3a
 -# Date created:        23 May 1998
 -# Whom:                Hans Petter Bieker <hanspb@persbraten.vgs.no>
 +# Version required:    0.2.2
 +# Date created:        24 May 1999
 +# Whom:                Tom Hukins <tom@eborcom.com>
  #
 -# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $
 +# $Id$
  #
  
  DISTNAME=	kmp3-0.2.2
  CATEGORIES=	audio kde
 -MASTER_SITES=	ftp://ftp.kde.org/pub/kde/stable/1.1/apps/multimedia/sound/
 +MASTER_SITES=	${MASTER_SITE_KDE}
 +MASTER_SITE_SUBDIR= stable/1.1/apps/multimedia/sound/
  
  MAINTAINER=	obonilla@fisicc-ufm.edu
  
 diff -ruN kmp3.old/pkg/PLIST kmp3/pkg/PLIST
 --- kmp3.old/pkg/PLIST	Wed Mar 24 21:58:50 1999
 +++ kmp3/pkg/PLIST	Wed Mar 24 20:58:24 1999
 @@ -1,14 +1,14 @@
  bin/kmp3
  bin/kmp3player
  share/applnk/Multimedia/KMp3.kdelnk
 -share/icons/kmp3.xpm
 -share/icons/mini/kmp3.xpm
  share/apps/kmp3/pics/dock_idle.xpm
  share/apps/kmp3/pics/dock_playing.xpm
  share/apps/kmp3/pics/logo.xpm
 -share/locale/fr/LC_MESSAGES/kmp3.mo
 +share/icons/kmp3.xpm
 +share/icons/mini/kmp3.xpm
  share/locale/de/LC_MESSAGES/kmp3.mo
  share/locale/es/LC_MESSAGES/kmp3.mo
 +share/locale/fr/LC_MESSAGES/kmp3.mo
  share/locale/is/LC_MESSAGES/kmp3.mo
  @dirrm share/apps/kmp3/pics
  @dirrm share/apps/kmp3
 

From: Oscar Bonilla <obonilla@fisicc-ufm.edu>
To: Tom Hukins <tom@eborcom.com>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: ports/10770: New Port for kmp3
Date: Thu, 25 Mar 1999 08:46:38 -0600

 On Wed, Mar 24, 1999 at 10:08:33PM +0000, Tom Hukins wrote:
 > Oscar, thanks for submitting this port. There are a few problems
 > with it, which I explain below:
 > 
 >  [snip]
 > 
 > Each one of the lines above is incorrect. The "Making a port
 > yourself" section of the Handbook explains how this should be done
 > under the "Quick porting section".
 > 
 
 oops, i copied the makefile from another port instead of starting it
 from scratch :) guess i should have been more careful.
 
 > > X# $Id: Makefile,v 1.10 1999/03/09 06:22:44 fenner Exp $
 > 
 > A new port should be submitted with $Id$. Again, this is covered in
 > the Handbook.
 > 
 
 idem
 
 > I have tidied up this port (patch below), fixing the things
 > mentioned above, using MASTER_SITE_KDE and sorting pkg/PLIST
 > alphabetically.
 > 
 
 thanks,
 
 > The kmp3/amp section of the port still fails to honour CFLAGS,
 > however. I haven't fixed this.
 > 
 
 ok, i'll check it and submit a pr when it's fixed.
 
 thanks,
 
 -oscar
 
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Sun May 2 20:47:47 PDT 1999 
State-Changed-Why:  
New port committed, thanks! 
>Unformatted:
 
