From uspoerlein@gmail.com  Mon Jan  1 11:41:20 2007
Return-Path: <uspoerlein@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7DB4A16A412
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Jan 2007 11:41:17 +0000 (UTC)
	(envelope-from uspoerlein@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189])
	by mx1.freebsd.org (Postfix) with ESMTP id 1727413C448
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Jan 2007 11:41:16 +0000 (UTC)
	(envelope-from uspoerlein@gmail.com)
Received: by nf-out-0910.google.com with SMTP id x37so6432125nfc
        for <FreeBSD-gnats-submit@freebsd.org>; Mon, 01 Jan 2007 03:41:16 -0800 (PST)
Received: by 10.49.41.3 with SMTP id t3mr3224917nfj.1167651675982;
        Mon, 01 Jan 2007 03:41:15 -0800 (PST)
Received: from roadrunner.q.local ( [85.180.170.141])
        by mx.google.com with ESMTP id v20sm80631337nfc.2007.01.01.03.41.15;
        Mon, 01 Jan 2007 03:41:15 -0800 (PST)
Received: from roadrunner.q.local (localhost [127.0.0.1])
	by roadrunner.q.local (8.13.8/8.13.8) with ESMTP id kBUHqOYU097960;
	Sat, 30 Dec 2006 18:52:24 +0100 (CET)
	(envelope-from q@roadrunner.q.local)
Received: (from q@localhost)
	by roadrunner.q.local (8.13.8/8.13.8/Submit) id kBUHqN7S097959;
	Sat, 30 Dec 2006 18:52:23 +0100 (CET)
	(envelope-from q)
Message-Id: <200612301752.kBUHqN7S097959@roadrunner.q.local>
Date: Sat, 30 Dec 2006 18:52:23 +0100 (CET)
From: Ulrich Spoerlein <uspoerlein@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: itetcu@freebsd.org
Subject: [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         107394
>Category:       ports
>Synopsis:       [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 01 11:50:17 GMT 2007
>Closed-Date:    Fri Jan 05 00:24:58 GMT 2007
>Last-Modified:  Fri Jan  5 00:30:23 GMT 2007
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD roadrunner.q.local 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #3: Fri Dec 29 20:43:07 CET 2006
>Description:
The OPTIONS framework is flawed wrt. to BATCH mode. There are around 600
instances where wrong checks are performed. For a general fix see ports/105147

This is the same problem as
http://www.freebsd.org/cgi/query-pr.cgi?pr=107349

Port maintainer (itetcu@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
% cd /usr/ports/misc/tinderbox
% make __MAKE_CONF=/dev/null -DBATCH -DWITH_PGSQL -DWITHOUT_MYSQL 
===>  tinderbox-2.3.4_2 is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL.
*** Error code 1

>Fix:

--- tinderbox-2.3.4_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/tinderbox/Makefile,v
retrieving revision 1.26
diff -u -p -u -r1.26 Makefile
--- Makefile	17 Dec 2006 19:07:47 -0000	1.26
+++ Makefile	30 Dec 2006 17:48:11 -0000
@@ -31,7 +31,7 @@ MAN1=		tc-configCcache.1 tc-configDistfi
 
 .include <bsd.port.pre.mk>
 
-.if defined(WITHOUT_PGSQL) && defined(WITHOUT_MYSQL)
+.if !defined(WITH_PGSQL) && defined(WITHOUT_MYSQL)
 IGNORE=	is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL
 .endif
 
--- tinderbox-2.3.4_2.patch ends here ---

The pre-everything:: target already has this right.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 1 11:50:33 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107394 
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Fri Jan 5 00:24:57 UTC 2007 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107394 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/107394: commit references a PR
Date: Fri,  5 Jan 2007 00:24:47 +0000 (UTC)

 itetcu      2007-01-05 00:24:44 UTC
 
   FreeBSD ports repository
 
   Modified files:
     misc/tinderbox       Makefile 
   Log:
   Fix OPTIONS handling.
   
   PR:             ports/107394
   Submitted by:   Ulrich Spoerlein
   
   Revision  Changes    Path
   1.27      +1 -1      ports/misc/tinderbox/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
