From pete@tortall.net  Wed Dec 27 22:04:24 2006
Return-Path: <pete@tortall.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5773D16A407
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Dec 2006 22:04:24 +0000 (UTC)
	(envelope-from pete@tortall.net)
Received: from cvs.tortall.net (cvs.tortall.net [69.55.238.110])
	by mx1.freebsd.org (Postfix) with ESMTP id 42A0513C46E
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Dec 2006 22:04:24 +0000 (UTC)
	(envelope-from pete@tortall.net)
Received: from localhost (cvs [69.55.238.110])
	by cvs.tortall.net (Postfix) with ESMTP id 7366917002
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 27 Dec 2006 13:37:45 -0800 (PST)
Received: from cvs.tortall.net ([69.55.238.110])
	by localhost (cvs.tortall.net [69.55.238.110]) (amavisd-new, port 10024)
	with ESMTP id 7A1sI2DW8FQC for <FreeBSD-gnats-submit@freebsd.org>;
	Wed, 27 Dec 2006 13:37:44 -0800 (PST)
Received: by cvs.tortall.net (Postfix, from userid 1000)
	id 5A33F17003; Wed, 27 Dec 2006 13:37:44 -0800 (PST)
Message-Id: <20061227213744.5A33F17003@cvs.tortall.net>
Date: Wed, 27 Dec 2006 13:37:44 -0800 (PST)
From: Peter Johnson <johnson.peter@gmail.com>
Reply-To: Peter Johnson <johnson.peter@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINT] multimedia/gstreamer: Add gstreamer-plugins-good dep
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         107256
>Category:       ports
>Synopsis:       [MAINT] multimedia/gstreamer: Add gstreamer-plugins-good dep
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mezz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 27 22:10:05 GMT 2006
>Closed-Date:    Thu Dec 28 18:47:11 GMT 2006
>Last-Modified:  Thu Dec 28 18:50:18 GMT 2006
>Originator:     Peter Johnson
>Release:        FreeBSD 6.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 6.1-RELEASE
>Description:
Port does not currently depend on gstreamer-plugins-good, but this is required
for media with ID3 tags to be playable (as this needs id3demux, part of
gstreamer-plugins-good, to be installed).
>How-To-Repeat:
Clean install of port will not install gstreamer-plugins-good, and thus will
not play media with ID3 tags.
>Fix:
Patch attached.

--- quodlibet-gstreamer.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/multimedia/quodlibet/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- Makefile	10 Dec 2006 23:47:40 -0000	1.16
+++ Makefile	27 Dec 2006 21:30:51 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	quodlibet
 PORTVERSION=	0.24
+PORTREVISION=	1
 CATEGORIES=	multimedia audio python gnome
 MASTER_SITES=	http://www.sacredchao.net/~piman/software/
 
@@ -25,7 +26,7 @@
 USE_GMAKE=	yes
 USE_X_PREFIX=	yes
 USE_GSTREAMER=	yes
-USE_GSTREAMER+=	gconf
+USE_GSTREAMER+=	gconf good
 
 MAN1=		exfalso.1 quodlibet.1
 
--- quodlibet-gstreamer.patch ends here ---


>Release-Note:
>Audit-Trail:
Class-Changed-From-To: maintainer-update->change-request 
Class-Changed-By: edwin 
Class-Changed-When: Wed Dec 27 22:10:16 UTC 2006 
Class-Changed-Why:  
Fix category (submitter is not maintainer) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 27 22:10:24 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 
Class-Changed-From-To: change-request->maintainer-update 
Class-Changed-By: mezz 
Class-Changed-When: Wed Dec 27 23:09:49 UTC 2006 
Class-Changed-Why:  
Actually, the 'multimedia/gstreamer' is a typo, which it is supposed to be 
'multimedia/quodlibet' by looked at his patch. Therefore, it is correct that 
he is a maintainer. 


Responsible-Changed-From-To: freebsd-multimedia->freebsd-ports-bugs 
Responsible-Changed-By: mezz 
Responsible-Changed-When: Wed Dec 27 23:09:49 UTC 2006 
Responsible-Changed-Why:  
Actually, the 'multimedia/gstreamer' is a typo, which it is supposed to be 
'multimedia/quodlibet' by looked at his patch. Therefore, it is correct that 
he is a maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 
Responsible-Changed-From-To: freebsd-ports-bugs->mezz 
Responsible-Changed-By: mezz 
Responsible-Changed-When: Wed Dec 27 23:18:02 UTC 2006 
Responsible-Changed-Why:  
I'll take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 
State-Changed-From-To: open->feedback 
State-Changed-By: mezz 
State-Changed-When: Wed Dec 27 23:29:15 UTC 2006 
State-Changed-Why:  
I have tweaked it a bit, so what do you think of this before I commit it? 

http://people.freebsd.org/~mezz/diff/quodlibet.diff 

-Remove USE_GSTREAMER=yes, taken care by USE_GSTREAMER=foobar 
-Move from (BUILD|RUN)_DEPENDS=[...]py-gstreamer to USE_GSTREAMER=python 
-Move from (BUILD|RUN)_DEPENDS=[...]py-gnome-extras to USE_GNOME+=pygnomeextras 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 
State-Changed-From-To: feedback->closed 
State-Changed-By: mezz 
State-Changed-When: Thu Dec 28 18:46:57 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=107256 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/107256: commit references a PR
Date: Thu, 28 Dec 2006 18:46:56 +0000 (UTC)

 mezz        2006-12-28 18:46:50 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/quodlibet Makefile 
   Log:
   - Add the gstreamer-plugins-good dependency to make ID3 tags to be playable,
     bump the PORTREVISION.
   - Remove USE_GSTREAMER=yes, taken care by USE_GSTREAMER=foobar
   - Move from (BUILD|RUN)_DEPENDS=[...]py-gstreamer to USE_GSTREAMER=python
   - Move from (BUILD|RUN)_DEPENDS=[...]py-gnome-extras to USE_GNOME+=pygnomeextras
   
   PR:             ports/107256
   Submitted by:   Peter Johnson <johnson.peter@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.17      +5 -9      ports/multimedia/quodlibet/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
