From nobody@FreeBSD.org  Tue Dec 19 14:20:22 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9D95216A6A3
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Dec 2006 14:20:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3A4F443CA3
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Dec 2006 14:20:22 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kBJEKMVe037868
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 19 Dec 2006 14:20:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id kBJEKMcX037867;
	Tue, 19 Dec 2006 14:20:22 GMT
	(envelope-from nobody)
Message-Id: <200612191420.kBJEKMcX037867@www.freebsd.org>
Date: Tue, 19 Dec 2006 14:20:22 GMT
From: Simon Phoenix<phoenix.simon@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] fix default value in rcscript for emulators/kqemu-kmod
X-Send-Pr-Version: www-3.0

>Number:         106917
>Category:       ports
>Synopsis:       [patch] fix default value in rcscript for emulators/kqemu-kmod
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 19 14:30:16 GMT 2006
>Closed-Date:    Thu Dec 21 22:14:03 GMT 2006
>Last-Modified:  Thu Dec 21 22:20:13 GMT 2006
>Originator:     Simon Phoenix
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
Phoenix Lab.
>Environment:
FreeBSD sp0-host.lan 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Tue Dec 19 16:28:58 EET 2006     root@:/usr/obj/usr/src/sys/PHOENIX  i386
>Description:
Have not default value for $kqemu_enable in /usr/local/etc/rc.d/kqemu
Than -
"/etc/rc: WARNING: $kqemu_enable is not set properly - see rc.conf(5)."
while starting system.

>How-To-Repeat:

>Fix:
- Fix default value $kqemu_enable in /usr/ports/emulators/kqemu-kmod/files/kqemu.in to "NO"


Patch attached with submission follows:

--- /usr/ports/emulators/kqemu-kmod/files/kqemu.in	Fri Dec 15 10:38:11 2006
+++ /home/phoenix/ports/kqemu.in	Tue Dec 19 15:18:41 2006
@@ -12,8 +12,12 @@
 . /etc/rc.subr
 
 name="kqemu"
+rcvar=${name}_enable
+
 load_rc_config $name
-rcvar=`set_rcvar`
+
+: ${kqemu_enable="NO"}
+
 start_cmd=kqemu_start
 stop_cmd=kqemu_stop
 

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Dec 19 14:30:48 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106917 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Tue Dec 19 14:41:32 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106917 

From: Juergen Lock <nox@jelal.kn-bremen.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/106917: [patch] fix default value in rcscript for emulators/kqemu-kmod
Date: Tue, 19 Dec 2006 23:22:10 +0100

 On Tue, Dec 19, 2006 at 02:30:44PM +0000, Edwin Groothuis wrote:
 > Maintainer of emulators/kqemu-kmod,
 > 
 > Please note that PR ports/106917 has just been submitted.
 
 Looks good!
 
 	Juergen
State-Changed-From-To: feedback->open 
State-Changed-By: miwi 
State-Changed-When: Tue Dec 19 23:11:16 UTC 2006 
State-Changed-Why:  
Maintainer Approved! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106917 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu Dec 21 22:14:00 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106917 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/106917: commit references a PR
Date: Thu, 21 Dec 2006 22:13:30 +0000 (UTC)

 miwi        2006-12-21 22:13:24 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/kqemu-kmod Makefile 
     emulators/kqemu-kmod/files kqemu.in 
   Log:
   - Fix rc script for 6.X
   - Bump PORTREVISION
   
   PR:             ports/106917
   Submitted by:   Simon Phoenix<phoenix.simon@gmail.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.10      +1 -1      ports/emulators/kqemu-kmod/Makefile
   1.2       +6 -2      ports/emulators/kqemu-kmod/files/kqemu.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
