From rafan@svm.csie.ntu.edu.tw  Fri Dec  8 17:01:49 2006
Return-Path: <rafan@svm.csie.ntu.edu.tw>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 995B316A47B;
	Fri,  8 Dec 2006 17:01:49 +0000 (UTC)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6589343CA6;
	Fri,  8 Dec 2006 17:00:48 +0000 (GMT)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1])
	by svm.csie.ntu.edu.tw (8.13.8/8.13.8) with ESMTP id kB8H1kMD085674;
	Sat, 9 Dec 2006 01:01:46 +0800 (CST)
	(envelope-from rafan@svm.csie.ntu.edu.tw)
Received: (from rafan@localhost)
	by svm.csie.ntu.edu.tw (8.13.8/8.13.8/Submit) id kB8H1kFr090245;
	Sat, 9 Dec 2006 01:01:46 +0800 (CST)
	(envelope-from rafan)
Message-Id: <200612081701.kB8H1kFr090245@svm.csie.ntu.edu.tw>
Date: Sat, 9 Dec 2006 01:01:46 +0800 (CST)
From: Rong-En Fan <rafan@freebsd.org>
Reply-To: Rong-En Fan <rafan@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: kde@freebsd.org
Subject: [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         106486
>Category:       ports
>Synopsis:       [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 08 17:10:17 GMT 2006
>Closed-Date:    Tue Dec 19 21:23:23 GMT 2006
>Last-Modified:  Tue Dec 19 21:23:23 GMT 2006
>Originator:     Rong-En Fan
>Release:        FreeBSD 6.2-PRERELEASE amd64
>Organization:
NTU CSIE 
>Environment:


	
>Description:
	QTDIR/KDEDIR is not passwd when USE_QT_VER != CVS. When X11BASE
	sets to a non-standard, say /usr/X11R6, value, some ports fail
	to build:

	devel/libchipcard-kde
	graphics/djvulibre
	graphics/gephex
	irc/kvirc
	net-p2p/dctc-gui-qt

	I fixed some of them by passing QTDIR. However, fixing this in
	bsd.kde.mk is much better. Moreover, we can clean up some ports
	that manually set QTDIR.

	I tested this patch with the five ports mentioned above in
	tinderbox. All build fine.
>How-To-Repeat:
	
>Fix:

Index: bsd.kde.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.kde.mk,v
retrieving revision 1.63
diff -u -r1.63 bsd.kde.mk
--- bsd.kde.mk	12 Sep 2006 23:26:10 -0000	1.63
+++ bsd.kde.mk	8 Dec 2006 16:47:49 -0000
@@ -125,7 +125,8 @@
 				--with-qt-libraries=${QT_PREFIX}/lib \
 				--with-extra-libs=${LOCALBASE}/lib \
 				--with-extra-includes=${LOCALBASE}/include
-CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}"
+CONFIGURE_ENV+=	MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" \
+				QTDIR="${QT_PREFIX}" KDEDIR="${KDE_PREFIX}"
 .endif # !defined(QT_NONSTANDARD)
 .else
 IGNORE=			cannot install: unsupported value of USE_QT_VER
	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-kde 
Responsible-Changed-By: rafan 
Responsible-Changed-When: Fri Dec 8 17:29:24 UTC 2006 
Responsible-Changed-Why:  
Over to KDE Team. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106486 
Responsible-Changed-From-To: freebsd-kde->kde 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Fri Dec 8 17:33:12 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106486 
State-Changed-From-To: open->closed 
State-Changed-By: lofi 
State-Changed-When: Tue Dec 19 21:23:04 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=106486 
>Unformatted:
