From gmarco@scotty.masternet.it Tue Mar 16 01:20:59 1999
Return-Path: <gmarco@scotty.masternet.it>
Received: from scotty.masternet.it (scotty.masternet.it [194.184.65.2])
	by hub.freebsd.org (Postfix) with ESMTP
	id 90D10154EE; Tue, 16 Mar 1999 01:20:46 -0800 (PST)
	(envelope-from gmarco@scotty.masternet.it)
Received: from suzy (modem34.masternet.it [194.184.65.44])
	by scotty.masternet.it (8.8.8/8.8.8) with SMTP id KAA25780;
	Tue, 16 Mar 1999 10:20:18 +0100 (CET)
	(envelope-from gmarco@scotty.masternet.it)
Message-Id: <4.1.19990317101009.009b5580@194.184.65.4>
Date: Wed, 17 Mar 1999 10:21:51 +0100
From: Gianmarco Giovannelli <gmarco@scotty.masternet.it>
To: FreeBSD-gnats-submit@freebsd.org
Cc: billf@freebsd.org, freebsd@scotty.masternet.it
Subject: Update port: net/mtr-0.33

>Number:         10613
>Category:       ports
>Synopsis:       Update port:  net/mtr-0.33
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    billf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 16 01:30:00 PST 1999
>Closed-Date:    Tue Apr 13 12:56:17 PDT 1999
>Last-Modified:  Tue Apr 13 12:56:47 PDT 1999
>Originator:     Gianmarco Giovannelli
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
< Private >
>Environment:

FreeBSD gmarco.eclipse.org 4.0-CURRENT FreeBSD 4.0-CURRENT #0: Mon Mar 15
10:08:29 CET 1999     gmarco@gmarco.eclipse.org:/usr/src/sys/compile/GMARCO
 i386

>Description:

mtr combines the functionality of the "traceroute" and "ping" programs
into a single network diagnostic tool. 

>How-To-Repeat:

Please read also the questions at the end of report.

portlint : 0e:1w due to position of the LIBS_DEPENDS clause.

>Fix:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	mtr
#	mtr/files
#	mtr/files/md5
#	mtr/patches
#	mtr/pkg
#	mtr/pkg/COMMENT
#	mtr/pkg/DESCR
#	mtr/pkg/PLIST
#	mtr/Makefile
#
echo c - mtr
mkdir -p mtr > /dev/null 2>&1
echo c - mtr/files
mkdir -p mtr/files > /dev/null 2>&1
echo x - mtr/files/md5
sed 's/^X//' >mtr/files/md5 << 'END-of-mtr/files/md5'
XMD5 (mtr-0.33.tar.gz) = fe3609bb64bdf0344b51860222cf8b43
END-of-mtr/files/md5
echo c - mtr/patches
mkdir -p mtr/patches > /dev/null 2>&1
echo c - mtr/pkg
mkdir -p mtr/pkg > /dev/null 2>&1
echo x - mtr/pkg/COMMENT
sed 's/^X//' >mtr/pkg/COMMENT << 'END-of-mtr/pkg/COMMENT'
Xtraceroute and ping in a single graphical network diagnostic tool.
END-of-mtr/pkg/COMMENT
echo x - mtr/pkg/DESCR
sed 's/^X//' >mtr/pkg/DESCR << 'END-of-mtr/pkg/DESCR'
Xmtr combines the functionality of the "traceroute" and "ping" programs
Xinto a single network diagnostic tool. 
X
XAuthors:   Matt Kimball <mkimball@xmission.com> is the primary author of mtr.
X	   Roger Wolff <R.E.Wolff@BitWizard.nl> is currently maintaing mtr. 
XHomepage:  http://www.bitwizard.nl/mtr
XDistfile:  mtr-0.33.tar.gz (79333 bytes)
X
X
XPorted to FreeBSD by:
XBill Fumerola (billf@chc-chimes.com)
XGianmarco Giovannelli (gmarco@giovannelli.it)
END-of-mtr/pkg/DESCR
echo x - mtr/pkg/PLIST
sed 's/^X//' >mtr/pkg/PLIST << 'END-of-mtr/pkg/PLIST'
Xsbin/mtr
END-of-mtr/pkg/PLIST
echo x - mtr/Makefile
sed 's/^X//' >mtr/Makefile << 'END-of-mtr/Makefile'
X# New ports collection makefile for:   mtr
X# Version required:    0.33
X# Date created:        15 March 1999
X# Whom:                Gianmarco Giovannelli <gmarco@giovannelli.it>
X#
X# $Id:$
X#
X
XDISTNAME=	mtr-0.33
XCATEGORIES=	net
XMASTER_SITES=	ftp://ftp.bitwizard.nl/mtr/ \
X		http://www.giovannelli.it/~gmarco/files/
X
XMAINTAINER=	billf@FreeBSD.org
X
XHAS_CONFIGURE=	yes
XUSE_XLIB=	yes
X
XMAN8=	mtr.8
X
Xpre-fetch:
X.if !defined(USE_GTK)
X	@${ECHO} ""
X	@${ECHO} "If you want to compile with GTK support,"
X	@${ECHO} "hit Ctrl-C right now and use \"make USE_GTK=yes\" "
X	@${ECHO} ""
XCONFIGURE_ARGS=--with-gtk-prefix=/nopath
X.else
XLIB_DEPENDS=    gtk12.1:${PORTSDIR}/x11-toolkits/gtk12
XCONFIGURE_ENV=	GTK_CONFIG="${X11BASE}/bin/gtk12-config"
X.endif
X
Xdo-install:
X	${INSTALL} -c -s -m 4755 -o root -g wheel ${WRKSRC}/mtr ${PREFIX}/sbin
X	${INSTALL_DATA} ${WRKSRC}/mtr.8 ${PREFIX}/man/man8
X
Xpost-install:
X	@${ECHO} ""
X	@${ECHO} "${PREFIX}/sbin/mtr is setuid \"root\" "
X	@${ECHO} ""
X	@${ECHO} "Please read about potential security iussues"
X	@${ECHO} "in file ${WRKSRC}/SECURITY (not installed)"
X	@${ECHO} ""
X
X.include <bsd.port.mk>
END-of-mtr/Makefile
exit

Questions:
1) I don't know which GTK version I have to use. I choose the 1.2 but I
don't know if it's ok.
2) I found in the code such lines:

  if (first && (rv < 0) && (errno == EINVAL)) {
    first = 0;
    ip->len = packetsize;
    rv = sendto(sendsock, packet, packetsize, 0, 
                (struct sockaddr *)&remoteaddress, sizeof(remoteaddress));
    if (rv >= 0) {
      fprintf (stderr, "You've got a broken (FreeBSD?) system\n");
      BSDfix = 1;
    }
  }

I am not able to judge (I am not a C programmer at all) but it is not
"beautifull" that every time I launch the program I see that sentence :-) .
Perhaps a little patch that remove this line would be appropriate. I can
make it, but I'd like to ask first.

Thanks...







Best Regards,
Gianmarco Giovannelli ,  "Unix expert since yesterday"
http://www.giovannelli.it/~gmarco  
http://www2.masternet.it 




>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->billf 
Responsible-Changed-By: billf 
Responsible-Changed-When: Tue Mar 16 11:15:46 PST 1999 
Responsible-Changed-Why:  
This is my port. 
State-Changed-From-To: open->feedback 
State-Changed-By: billf 
State-Changed-When: Fri Mar 19 12:26:49 PST 1999 
State-Changed-Why:  
The submitter should send port updates as patches, not shar archives. 
State-Changed-From-To: feedback->closed 
State-Changed-By: billf 
State-Changed-When: Tue Apr 13 12:56:17 PDT 1999 
State-Changed-Why:  
outdated by ports/11053 
>Unformatted:
