From snb@smtp.earth.threerings.net  Fri Nov  3 05:57:21 2006
Return-Path: <snb@smtp.earth.threerings.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 97A7616A403
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Nov 2006 05:57:21 +0000 (UTC)
	(envelope-from snb@smtp.earth.threerings.net)
Received: from smtp.earth.threerings.net (mail.threerings.net [64.127.109.101])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7177843D5F
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Nov 2006 05:57:21 +0000 (GMT)
	(envelope-from snb@smtp.earth.threerings.net)
Received: by smtp.earth.threerings.net (Postfix, from userid 10038)
	id C915A6682; Thu,  2 Nov 2006 21:57:20 -0800 (PST)
Message-Id: <20061103055720.C915A6682@smtp.earth.threerings.net>
Date: Thu,  2 Nov 2006 21:57:20 -0800 (PST)
From: Nick Barkas <snb@threerings.net>
Reply-To: Nick Barkas <snb@threerings.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer update] [patch] Set IGNORE on sysutils/ipmi-kmod in 6-STABLE 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         105097
>Category:       ports
>Synopsis:       [maintainer update] [patch] Set IGNORE on sysutils/ipmi-kmod in 6-STABLE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    alepulver
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 03 06:00:36 GMT 2006
>Closed-Date:    Mon Nov 06 01:39:51 GMT 2006
>Last-Modified:  Mon Nov  6 01:40:20 GMT 2006
>Originator:     Nick Barkas
>Release:        FreeBSD 5.4-RELEASE-p20 i386
>Organization:
Three Rings Design
>Environment:
System: FreeBSD mail.earth.threerings.net 5.4-RELEASE-p20 FreeBSD 5.4-RELEASE-p20 #12: Thu Sep 28 14:09:16 PDT 2006 root@mail.earth.threerings.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
sysutils/ipmi-kmod should not be installed on systems where it is part of the
base system. The port checks OSVERSION currently to determine whether the base
system is a version it should work on. This doesn't work on 6-STABLE because
OSVERSION is currently the same as 6.1, though -STABLE does have ipmi drivers in
the base system (unlike 6.1). Instead of checking OSVERSION, this patch makes
the port just check for the existence of ipmi driver code in the kernel sources,
and if it's there IGNORE will be set. (The port already requires that kernel
sources be installed).
>How-To-Repeat:
On a system running -STABLE, try installing sysutils/ipmi-kmod. Currently (for
me) the port will not build properly, but it should not even try because of the
presense of an ipmi driver in the base system.
>Fix:

Index: Makefile
===================================================================
--- Makefile	(revision 1173)
+++ Makefile	(working copy)
@@ -7,6 +7,7 @@
 
 PORTNAME=	ipmi-kmod
 PORTVERSION=	20060926
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	http://dpw.threerings.net/projects/ipmi-kmod/
 
@@ -37,8 +38,8 @@
 IGNORE=		requires kernel source to be installed
 .endif
 
-.if ${OSVERSION} >= 601102
-IGNORE=		already in the base system
+.if exists(${SRC_BASE}/sys/dev/ipmi)
+IGNORE=		is already included in the base system
 .elif ${OSVERSION} < 503000
 IGNORE=		does not support FreeBSD before 5.3
 .endif
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->alepulver 
Responsible-Changed-By: alepulver 
Responsible-Changed-When: Mon Nov 6 01:32:58 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=105097 
State-Changed-From-To: open->closed 
State-Changed-By: alepulver 
State-Changed-When: Mon Nov 6 01:39:49 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=105097 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/105097: commit references a PR
Date: Mon,  6 Nov 2006 01:39:29 +0000 (UTC)

 alepulver    2006-11-06 01:39:22 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/ipmi-kmod   Makefile 
   Log:
   - Check for existence of ipmi driver code in kernel sources instead of
     checking OSVERSION.
   
   PR:             ports/105097
   Submitted by:   Nick Barkas <snb@threerings.net> (maintainer)
   
   Revision  Changes    Path
   1.9       +2 -2      ports/sysutils/ipmi-kmod/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
