From fmysh@quad.dyndns.org  Sat Oct 28 19:56:07 2006
Return-Path: <fmysh@quad.dyndns.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 41C8B16A403
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Oct 2006 19:56:07 +0000 (UTC)
	(envelope-from fmysh@quad.dyndns.org)
Received: from xeon.quad.dyndns.org (228.142.138.210.bn.2iij.net [210.138.142.228])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3278A43D66
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Oct 2006 19:56:02 +0000 (GMT)
	(envelope-from fmysh@quad.dyndns.org)
Received: from localhost (localhost [127.0.0.1])
	by xeon.quad.dyndns.org (Postfix) with ESMTP id 9DB69153469;
	Sun, 29 Oct 2006 04:56:00 +0900 (JST)
Received: from xeon.quad.dyndns.org ([127.0.0.1])
	by localhost (xeon.quad.dyndns.org [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id VNyqkpPgVPaY; Sun, 29 Oct 2006 04:55:51 +0900 (JST)
Received: by xeon.quad.dyndns.org (Postfix, from userid 1001)
	id 8D9E1153468; Sun, 29 Oct 2006 04:55:51 +0900 (JST)
Message-Id: <20061028195551.8D9E1153468@xeon.quad.dyndns.org>
Date: Sun, 29 Oct 2006 04:55:51 +0900 (JST)
From: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>
Reply-To: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>
Subject: databases/grass-i18n installs files with invalid ownership
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         104887
>Category:       ports
>Synopsis:       databases/grass-i18n installs files with invalid ownership
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    hrs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 28 20:00:40 GMT 2006
>Closed-Date:    Wed Jan 03 03:54:43 GMT 2007
>Last-Modified:  Wed Jan  3 04:00:39 GMT 2007
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:

Installing the port with Tcl/Tk support, you'll see some files have
owner 1004 and group 513, which may be assigned to someone.
I think files installed by ports should have normally owner 0 (root)
and group 0 (wheel).

These files are from an extra tar ball, FILES_TKI18N.
As being a tar ball unpacked by root, permissions in the archive are
preserved, do-extract target does chmod -R ug-s and chown -R 0:0
explicitly.  FILES_TKI18N is, however, unpacked by not do-extract
but post-extract target and not chowned.

The port has two extra tar balls, FILES_TKI18N and FILES_FONTS.
and they are both unpacked by post-extract target.
They should be treated as do-extract does
(though FILES_FONTS is currently not an issue). 


>How-To-Repeat:

# cd /usr/ports/databases/grass-i18n
# make WITH_TCLTK=yes install
# ls -ln /usr/local/grass/scripts
total 330
-rwxr-xr-x  1 0     0     5262 Jun 13 22:11 3d.view.sh
-rwxr-xr-x  1 0     0      711 Jun 13 22:11 blend.sh
-rwxr-xr-x  1 0     0     3475 Jun 13 22:11 bug.report.sh
-rwxr-xr-x  1 0     0     1960 Jun 13 22:11 create_fifos.sh
-rwxr-xr-x  1 0     0    22949 Jun 13 22:04 d.dm
-rwxr-xr-x  1 1004  513  23260 Dec  9  2003 d.dm-i18n

(snip)

# ls -lnR /usr/local/grass/tcltkgrass

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/grass-i18n/Makefile,v
retrieving revision 1.36
diff -u -r1.36 Makefile
--- Makefile	15 Nov 2005 06:48:19 -0000	1.36
+++ Makefile	28 Oct 2006 19:21:17 -0000
@@ -6,6 +6,7 @@
 
 PORTNAME=	grass-i18n
 PORTVERSION=	5.0.3
+PORTREVISION=	1
 CATEGORIES=	databases
 MASTER_SITES=	http://www.grass-japan.org/FOSS4G/GRASS/:grass \
 		http://www.grass-japan.org/FOSS4G/ipafonts/:ipafonts
@@ -103,6 +104,10 @@
 	${MV} ${WRKSRC}/src/tcltkgrass/${D} ${WRKSRC}/src/tcltkgrass/${D}.orig
 	${MV} ${WRKDIR}/tcltkgrass-i18n/tcltkgrass-i18n/${D} ${WRKSRC}/src/tcltkgrass/${D}
 .endfor
+	@if [ `${ID} -u` = 0 ]; then \
+		${CHMOD} -R ug-s ${WRKDIR}; \
+		${CHOWN} -R 0:0 ${WRKDIR}; \
+	fi
 
 post-patch:
 	${CP} ${WRKSRC}/configure.in ${WRKSRC}/configure.in.orig
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->hrs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Oct 28 20:00:49 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104887 
State-Changed-From-To: open->closed 
State-Changed-By: hrs 
State-Changed-When: Wed Jan 3 03:53:57 UTC 2007 
State-Changed-Why:  
Committed with small modification.  Thank you for the submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104887 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/104887: commit references a PR
Date: Wed,  3 Jan 2007 03:53:54 +0000 (UTC)

 hrs         2007-01-03 03:53:47 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/grass-i18n Makefile 
   Log:
   Fix wrong ownership of installed files.  Bump PORTREVISION.
   
   Submitted by:   TAOKA Fumiyoshi
   PR:             ports/104887
   
   Revision  Changes    Path
   1.37      +5 -0      ports/databases/grass-i18n/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
