From nobody@FreeBSD.org  Sat Oct 21 16:19:55 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F3BC16A4AB
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Oct 2006 16:19:55 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F00F43DA2
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Oct 2006 16:19:49 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k9LGJkSc015322
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Oct 2006 16:19:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k9LGJkdV015321;
	Sat, 21 Oct 2006 16:19:46 GMT
	(envelope-from nobody)
Message-Id: <200610211619.k9LGJkdV015321@www.freebsd.org>
Date: Sat, 21 Oct 2006 16:19:46 GMT
From: Yuan Jue<yuanjue@yuanjue.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [maintainer update] devel/kdesvn pkg-plist fixed
X-Send-Pr-Version: www-3.0

>Number:         104654
>Category:       ports
>Synopsis:       [maintainer update] devel/kdesvn pkg-plist fixed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 21 16:20:16 GMT 2006
>Closed-Date:    Sun Oct 22 13:45:17 GMT 2006
>Last-Modified:  Sun Oct 22 13:45:17 GMT 2006
>Originator:     Yuan Jue
>Release:        FreeBSD 6.1-RELEASE
>Organization:
Institute of Computing Technology, CAS, China
>Environment:
FreeBSD maver-freebsd.net 6.1-RELEASE FreeBSD 6.1-RELEASE #4: Mon Jul 31 12:14:40 CST 2006     maver@maver-freebsd.net:/usr/obj/usr/src/sys/MYKERNEL_6_1  i386
>Description:
two empty directory could be left after deinstallation. fix pkg-plist in response to this.
>How-To-Repeat:

>Fix:
===> Generating patch
===> Viewing diff with more
diff -ruN --exclude=CVS /usr/ports/devel/kdesvn/Makefile /usr/home/maver/Develop/test/kdesvn/Makefile
--- /usr/ports/devel/kdesvn/Makefile	Sat Oct 21 10:52:45 2006
+++ /usr/home/maver/Develop/test/kdesvn/Makefile	Fri Oct 13 12:18:58 2006
@@ -2,7 +2,7 @@
 # Date created:				08 April 2006
 # Whom:					Yuan Jue <yuanjue@yuanjue.net>
 #
-# $FreeBSD: ports/devel/kdesvn/Makefile,v 1.10 2006/10/21 02:52:45 kris Exp $
+# $FreeBSD: ports/devel/kdesvn/Makefile,v 1.2 2006/04/15 02:53:53 markus Exp $
 
 PORTNAME=	kdesvn
 PORTVERSION=	0.10.0
@@ -15,8 +15,6 @@
 
 BUILD_DEPENDS=	cmake:${PORTSDIR}/devel/cmake
 
-BROKEN=		Incomplete pkg-plist
-
 WRKSRC=		${WRKDIR}/${DISTNAME}-build
 PATCH_WRKSRC=	${WRKDIR}/${DISTNAME}
 
@@ -50,6 +48,9 @@
 do-configure:
 	@(cd ${WRKSRC}; \
 	${LOCALBASE}/bin/cmake ${CMAKE_ARGS} ${PATCH_WRKSRC})
+
+post-build:
+	@${CAT} ${PKGMESSAGE}
 
 post-install:
 	@${MV} ${PREFIX}/share/man/man1/kdesvn.1 ${PREFIX}/man/man1/kdesvn.1
diff -ruN --exclude=CVS /usr/ports/devel/kdesvn/pkg-message /usr/home/maver/Develop/test/kdesvn/pkg-message
--- /usr/ports/devel/kdesvn/pkg-message	Thu Jan  1 08:00:00 1970
+++ /usr/home/maver/Develop/test/kdesvn/pkg-message	Fri Oct 13 11:24:16 2006
@@ -0,0 +1,6 @@
+*************************************************************************
+			NOTE
+If you cannot build kdesvn successfully, please pkg_delete the existing 
+kdesvn on your machine first and then try again. This issue should be 
+fixed in the next release version of kdesvn, hopefully.
+*************************************************************************
diff -ruN --exclude=CVS /usr/ports/devel/kdesvn/pkg-plist /usr/home/maver/Develop/test/kdesvn/pkg-plist
--- /usr/ports/devel/kdesvn/pkg-plist	Tue Oct 10 00:48:41 2006
+++ /usr/home/maver/Develop/test/kdesvn/pkg-plist	Sun Oct 22 00:11:03 2006
@@ -278,3 +278,5 @@
 @dirrm share/apps/kdesvn
 @dirrmtry share/applications/kde
 @dirrm include/svnqt
+@dirrmtry share/man/man1
+@dirrmtry share/man
===> Done

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Sat Oct 21 16:24:53 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104654 

From: Rong-En Fan <rafan@freebsd.org>
To: Yuan Jue <yuanjue@yuanjue.net>
Cc: freebsd-gnats-submit@freebsd.org, iteicu@freebsd.org
Subject: Re: ports/104654: [maintainer update] devel/kdesvn pkg-plist fixed
Date: Sun, 22 Oct 2006 01:06:35 +0800

 --EDJsL2R9iCFAt7IV
 Content-Type: multipart/mixed; boundary="kbCYTQG2MZjuOjyn"
 Content-Disposition: inline
 
 
 --kbCYTQG2MZjuOjyn
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 On Sat, Oct 21, 2006 at 04:19:46PM +0000, Yuan Jue wrote:
 > diff -ruN --exclude=CVS /usr/ports/devel/kdesvn/pkg-plist /usr/home/maver/Develop/test/kdesvn/pkg-plist
 > --- /usr/ports/devel/kdesvn/pkg-plist	Tue Oct 10 00:48:41 2006
 > +++ /usr/home/maver/Develop/test/kdesvn/pkg-plist	Sun Oct 22 00:11:03 2006
 > @@ -278,3 +278,5 @@
 >  @dirrm share/apps/kdesvn
 >  @dirrmtry share/applications/kde
 >  @dirrm include/svnqt
 > +@dirrmtry share/man/man1
 > +@dirrmtry share/man
 
  From pointyhat log, it installs manual pages into share/man/man1:
 
 -- Installing /usr/local/share/man/man1/kdesvn.1
 -- Installing /usr/local/share/man/man1/kdesvnaskpass.1
 
 This is not right. Our manual pages live in PREFIX/man.
 
 Another thing is that I don't think that you need a pkg-message here.
 Since the message is for users who build kdesvn from ports. I move
 them into post-build with ${ECHO_CMD}.
 
 In addition, I add USE_GETTEXT (this port uses msgfmt from gettext).
 
 The patch is attached. :-)
 
 Regards,
 Rong-En Fan
 
 
 --kbCYTQG2MZjuOjyn
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="kdesvn.diff"
 Content-Transfer-Encoding: quoted-printable
 
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/pcvs/ports/devel/kdesvn/Makefile,v
 retrieving revision 1.10
 diff -u -r1.10 Makefile
 --- Makefile	21 Oct 2006 02:52:45 -0000	1.10
 +++ Makefile	21 Oct 2006 17:02:18 -0000
 @@ -15,8 +15,6 @@
 =20
  BUILD_DEPENDS=3D	cmake:${PORTSDIR}/devel/cmake
 =20
 -BROKEN=3D		Incomplete pkg-plist
 -
  WRKSRC=3D		${WRKDIR}/${DISTNAME}-build
  PATCH_WRKSRC=3D	${WRKDIR}/${DISTNAME}
 =20
 @@ -32,6 +30,7 @@
  USE_BZIP2=3D	yes
  USE_KDELIBS_VER=3D3
  USE_GMAKE=3D	yes
 +USE_GETTEXT=3D	yes
  USE_LDCONFIG=3D	yes
 =20
  CXXFLAGS+=3D	-lc
 @@ -51,8 +50,12 @@
  	@(cd ${WRKSRC}; \
  	${LOCALBASE}/bin/cmake ${CMAKE_ARGS} ${PATCH_WRKSRC})
 =20
 -post-install:
 -	@${MV} ${PREFIX}/share/man/man1/kdesvn.1 ${PREFIX}/man/man1/kdesvn.1
 -	@${MV} ${PREFIX}/share/man/man1/kdesvnaskpass.1 ${PREFIX}/man/man1/kdesvn=
 askpass.1
 +post-build:
 +	@${ECHO_CMD} "***********************************************************=
 **************"
 +	@${ECHO_CMD} "                       NOTE                                =
               "
 +	@${ECHO_CMD} "If you cannot build kdesvn successfully, please pkg_delete =
 the existing  "
 +	@${ECHO_CMD} "kdesvn on your machine first and then try again. This issue=
  should be    "
 +	@${ECHO_CMD} "fixed in the next release version of kdesvn, hopefully.    =
               "
 +	@${ECHO_CMD} "***********************************************************=
 **************"
 =20
  .include <bsd.port.post.mk>
 Index: files/patch-doc-man-CMakeLists.txt
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: files/patch-doc-man-CMakeLists.txt
 diff -N files/patch-doc-man-CMakeLists.txt
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-doc-man-CMakeLists.txt	21 Oct 2006 17:02:18 -0000
 @@ -0,0 +1,9 @@
 +--- doc/man/CMakeLists.txt.orig	Sun Oct 22 00:46:16 2006
 ++++ doc/man/CMakeLists.txt	Sun Oct 22 00:46:22 2006
 +@@ -4,5 +4,5 @@
 +=20
 + INSTALL(FILES=20
 +     ${MANFILES}
 +-    DESTINATION share/man/man1)
 ++    DESTINATION man/man1)
 +=20
 
 --kbCYTQG2MZjuOjyn--
 
 --EDJsL2R9iCFAt7IV
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.5 (FreeBSD)
 
 iD8DBQFFOlOZ144QkYb9jGgRAmMsAJ49m61dVW+g03iEOgMhLWlsPEUUbwCgjHoE
 BOT7vGUNlbpaxpxGL8i5YeU=
 =2YOK
 -----END PGP SIGNATURE-----
 
 --EDJsL2R9iCFAt7IV--

From: "Yuan, Jue" <yuanjue02@gmail.com>
To: "Rong-En Fan" <rafan@freebsd.org>
Cc: freebsd-gnats-submit@freebsd.org, iteicu@freebsd.org
Subject: Re: ports/104654: [maintainer update] devel/kdesvn pkg-plist fixed
Date: Sun, 22 Oct 2006 19:23:13 +0800

 Hi,
 
 Thanks very much for your kind suggestions. It is really helpfully :-)
 
 the new problem report is at http://www.freebsd.org/cgi/query-pr.cgi?pr=104674
 
 
 On 10/22/06, Rong-En Fan <rafan@freebsd.org> wrote:
 > On Sat, Oct 21, 2006 at 04:19:46PM +0000, Yuan Jue wrote:
 > > diff -ruN --exclude=CVS /usr/ports/devel/kdesvn/pkg-plist /usr/home/maver/Develop/test/kdesvn/pkg-plist
 > > --- /usr/ports/devel/kdesvn/pkg-plist Tue Oct 10 00:48:41 2006
 > > +++ /usr/home/maver/Develop/test/kdesvn/pkg-plist     Sun Oct 22 00:11:03 2006
 > > @@ -278,3 +278,5 @@
 > >  @dirrm share/apps/kdesvn
 > >  @dirrmtry share/applications/kde
 > >  @dirrm include/svnqt
 > > +@dirrmtry share/man/man1
 > > +@dirrmtry share/man
 >
 >  From pointyhat log, it installs manual pages into share/man/man1:
 >
 > -- Installing /usr/local/share/man/man1/kdesvn.1
 > -- Installing /usr/local/share/man/man1/kdesvnaskpass.1
 >
 > This is not right. Our manual pages live in PREFIX/man.
 >
 > Another thing is that I don't think that you need a pkg-message here.
 > Since the message is for users who build kdesvn from ports. I move
 > them into post-build with ${ECHO_CMD}.
 >
 > In addition, I add USE_GETTEXT (this port uses msgfmt from gettext).
 
 -- 
 Best Regards
 Yuan, Jue @ http://www.yuanjue.net
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Sun Oct 22 13:45:16 UTC 2006 
State-Changed-Why:  
superceded by 104674 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104654 
>Unformatted:
